glitch-soc/mastodon

View on GitHub
app/javascript/flavours/glitch/features/directory/index.jsx

Summary

Maintainability
F
1 wk
Test Coverage

Function render has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render () {
    const { isLoading, accountIds, intl, columnId, multiColumn, domain } = this.props;
    const { order, local }  = this.getParams(this.props, this.state);
    const pinned = !!columnId;

Severity: Minor
Found in app/javascript/flavours/glitch/features/directory/index.jsx - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    class Directory extends PureComponent {
    
      static propTypes = {
        isLoading: PropTypes.bool,
        accountIds: ImmutablePropTypes.list.isRequired,
    Severity: Major
    Found in app/javascript/flavours/glitch/features/directory/index.jsx and 1 other location - About 1 wk to fix
    app/javascript/mastodon/features/directory/index.jsx on lines 38..179

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 1554.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 14 locations. Consider refactoring.
    Open

    const messages = defineMessages({
      title: { id: 'column.directory', defaultMessage: 'Browse profiles' },
      recentlyActive: { id: 'directory.recently_active', defaultMessage: 'Recently active' },
      newArrivals: { id: 'directory.new_arrivals', defaultMessage: 'New arrivals' },
      local: { id: 'directory.local', defaultMessage: 'From {domain} only' },
    app/javascript/flavours/glitch/actions/compose.js on lines 89..95
    app/javascript/flavours/glitch/components/column_header.jsx on lines 21..27
    app/javascript/flavours/glitch/features/compose/components/compose_form.jsx on lines 40..46
    app/javascript/flavours/glitch/features/compose/components/federation_button.jsx on lines 14..20
    app/javascript/flavours/glitch/features/list_timeline/index.jsx on lines 31..37
    app/javascript/flavours/glitch/features/ui/components/mute_modal.jsx on lines 23..29
    app/javascript/mastodon/actions/compose.js on lines 83..89
    app/javascript/mastodon/components/column_header.jsx on lines 21..27
    app/javascript/mastodon/components/status.jsx on lines 72..78
    app/javascript/mastodon/features/compose/components/compose_form.jsx on lines 36..42
    app/javascript/mastodon/features/directory/index.jsx on lines 24..30
    app/javascript/mastodon/features/list_timeline/index.jsx on lines 31..37
    app/javascript/mastodon/features/ui/components/mute_modal.jsx on lines 23..29

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 92.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    const mapStateToProps = state => ({
      accountIds: state.getIn(['user_lists', 'directory', 'items'], ImmutableList()),
      isLoading: state.getIn(['user_lists', 'directory', 'isLoading'], true),
      domain: state.getIn(['meta', 'domain']),
    });
    Severity: Major
    Found in app/javascript/flavours/glitch/features/directory/index.jsx and 1 other location - About 1 hr to fix
    app/javascript/mastodon/features/directory/index.jsx on lines 32..36

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 67.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status