Sign upLogin

glitch-soc/mastodon

View on GitHub
Star
app/javascript/flavours/glitch/features/list_adder/index.tsx

Summary

Maintainability
F
1 wk
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

const ListAdder: React.FC<{
  accountId: string;
  onClose: () => void;
}> = ({ accountId, onClose }) => {
  const intl = useIntl();
Severity: Major
Found in app/javascript/flavours/glitch/features/list_adder/index.tsx and 1 other location - About 4 days to fix
app/javascript/mastodon/features/list_adder/index.tsx on lines 114..210

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 795.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

const NewListItem: React.FC<{
  onCreate: (list: ApiListJSON) => void;
}> = ({ onCreate }) => {
  const intl = useIntl();
  const dispatch = useAppDispatch();
Severity: Major
Found in app/javascript/flavours/glitch/features/list_adder/index.tsx and 1 other location - About 2 days to fix
app/javascript/mastodon/features/list_adder/index.tsx on lines 65..112

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 404.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

const ListItem: React.FC<{
  id: string;
  title: string;
  checked: boolean;
  onChange: (id: string, checked: boolean) => void;
Severity: Major
Found in app/javascript/flavours/glitch/features/list_adder/index.tsx and 1 other location - About 1 day to fix
app/javascript/mastodon/features/list_adder/index.tsx on lines 39..63

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 248.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 18 locations. Consider refactoring.
Open

const messages = defineMessages({
  newList: {
    id: 'lists.new_list_name',
    defaultMessage: 'New list name',
  },
Severity: Major
Found in app/javascript/flavours/glitch/features/list_adder/index.tsx and 17 other locations - About 1 hr to fix
app/javascript/entrypoints/public.tsx on lines 25..38
app/javascript/flavours/glitch/entrypoints/public.tsx on lines 25..38
app/javascript/flavours/glitch/features/onboarding/follows.tsx on lines 24..31
app/javascript/flavours/glitch/features/onboarding/profile.tsx on lines 24..37
app/javascript/flavours/glitch/features/ui/components/confirmation_modals/clear_notifications.tsx on lines 11..25
app/javascript/flavours/glitch/features/ui/components/confirmation_modals/delete_list.tsx on lines 14..27
app/javascript/flavours/glitch/features/ui/components/confirmation_modals/edit_status.tsx on lines 11..22
app/javascript/flavours/glitch/features/ui/components/confirmation_modals/log_out.tsx on lines 10..20
app/javascript/flavours/glitch/features/ui/components/confirmation_modals/reply.tsx on lines 12..23
app/javascript/mastodon/features/list_adder/index.tsx on lines 24..37
app/javascript/mastodon/features/onboarding/follows.tsx on lines 24..31
app/javascript/mastodon/features/onboarding/profile.tsx on lines 24..37
app/javascript/mastodon/features/ui/components/confirmation_modals/clear_notifications.tsx on lines 11..25
app/javascript/mastodon/features/ui/components/confirmation_modals/delete_list.tsx on lines 14..27
app/javascript/mastodon/features/ui/components/confirmation_modals/edit_status.tsx on lines 11..22
app/javascript/mastodon/features/ui/components/confirmation_modals/log_out.tsx on lines 10..20
app/javascript/mastodon/features/ui/components/confirmation_modals/reply.tsx on lines 12..23

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status