glitch-soc/mastodon

View on GitHub
app/javascript/flavours/glitch/features/ui/components/deprecated_settings_modal.jsx

Summary

Maintainability
B
5 hrs
Test Coverage

Function render has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render () {
    const { settings, intl } = this.props;

    return (
      <div className='modal-root__modal confirmation-modal'>

    Similar blocks of code found in 23 locations. Consider refactoring.
    Open

    const messages = defineMessages({
      discardChanges: { id: 'confirmations.deprecated_settings.confirm', defaultMessage: 'Use Mastodon preferences' },
      user_setting_expand_spoilers: { id: 'settings.enable_content_warnings_auto_unfold', defaultMessage: 'Automatically unfold content-warnings' },
      user_setting_disable_swiping: { id: 'settings.swipe_to_change_columns', defaultMessage: 'Allow swiping to change columns (Mobile only)' },
    });
    app/javascript/flavours/glitch/components/poll.jsx on lines 20..33
    app/javascript/flavours/glitch/features/account_timeline/containers/header_container.jsx on lines 25..29
    app/javascript/flavours/glitch/features/compose/components/language_dropdown.jsx on lines 18..22
    app/javascript/flavours/glitch/features/compose/containers/compose_form_container.js on lines 23..36
    app/javascript/flavours/glitch/features/explore/components/card.jsx on lines 19..23
    app/javascript/flavours/glitch/features/getting_started/components/announcements.jsx on lines 29..33
    app/javascript/flavours/glitch/features/home_timeline/index.jsx on lines 28..32
    app/javascript/flavours/glitch/features/notifications/containers/column_settings_container.js on lines 12..16
    app/javascript/flavours/glitch/features/notifications/index.jsx on lines 46..50
    app/javascript/flavours/glitch/features/notifications/request.jsx on lines 22..26
    app/javascript/flavours/glitch/features/ui/components/bundle_modal_error.jsx on lines 10..14
    app/javascript/flavours/glitch/features/ui/components/media_modal.jsx on lines 25..29
    app/javascript/mastodon/components/poll.jsx on lines 20..33
    app/javascript/mastodon/features/account_timeline/containers/header_container.jsx on lines 27..31
    app/javascript/mastodon/features/compose/components/language_dropdown.jsx on lines 18..22
    app/javascript/mastodon/features/explore/components/card.jsx on lines 19..23
    app/javascript/mastodon/features/getting_started/components/announcements.jsx on lines 29..33
    app/javascript/mastodon/features/home_timeline/index.jsx on lines 28..32
    app/javascript/mastodon/features/notifications/containers/column_settings_container.js on lines 12..16
    app/javascript/mastodon/features/notifications/request.jsx on lines 22..26
    app/javascript/mastodon/features/ui/components/bundle_modal_error.jsx on lines 10..14
    app/javascript/mastodon/features/ui/components/media_modal.jsx on lines 25..29

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                  app_settings: (
                    <strong className='deprecated-settings-label'>
                      <Icon id='cogs' icon={ManufacturingIcon} /> <FormattedMessage id='navigation_bar.app_settings' defaultMessage='App settings' />
                    </strong>
                  ),
    app/javascript/flavours/glitch/features/ui/components/deprecated_settings_modal.jsx on lines 54..58

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 59.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                  preferences: (
                    <strong className='deprecated-settings-label'>
                      <Icon id='cog' icon={SettingsIcon} /> <FormattedMessage id='navigation_bar.preferences' defaultMessage='Preferences' />
                    </strong>
                  ),
    app/javascript/flavours/glitch/features/ui/components/deprecated_settings_modal.jsx on lines 49..53

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 59.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status