Sign upLogin

glitch-soc/mastodon

View on GitHub
Star
app/javascript/mastodon/components/column_header.jsx

Summary

Maintainability
F
1 wk
Test Coverage

Function render has 97 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render () {
    const { title, icon, iconComponent, active, children, pinned, multiColumn, extraButton, showBackButton, intl: { formatMessage }, placeholder, appendContent, collapseIssues, history } = this.props;
    const { collapsed, animating } = this.state;

    const wrapperClassName = classNames('column-header__wrapper', {
Severity: Major
Found in app/javascript/mastodon/components/column_header.jsx - About 3 hrs to fix

    Function render has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

      render () {
    const { title, icon, iconComponent, active, children, pinned, multiColumn, extraButton, showBackButton, intl: { formatMessage }, placeholder, appendContent, collapseIssues, history } = this.props;
    const { collapsed, animating } = this.state;

    const wrapperClassName = classNames('column-header__wrapper', {
    Severity: Minor
    Found in app/javascript/mastodon/components/column_header.jsx - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    class ColumnHeader extends PureComponent {

  static contextTypes = {
    identity: PropTypes.object,
  };
    Severity: Major
    Found in app/javascript/mastodon/components/column_header.jsx and 1 other location - About 1 wk to fix
    app/javascript/flavours/glitch/components/column_header.jsx on lines 53..233

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 1608.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    const BackButton = ({ onlyIcon }) => {
  const history = useAppHistory();
  const intl = useIntl();

  const handleBackClick = useCallback(() => {
    Severity: Major
    Found in app/javascript/mastodon/components/column_header.jsx and 1 other location - About 1 day to fix
    app/javascript/flavours/glitch/components/column_header.jsx on lines 29..47

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 211.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 15 locations. Consider refactoring.
    Open

    const messages = defineMessages({
  show: { id: 'column_header.show_settings', defaultMessage: 'Show settings' },
  hide: { id: 'column_header.hide_settings', defaultMessage: 'Hide settings' },
  moveLeft: { id: 'column_header.moveLeft_settings', defaultMessage: 'Move column to the left' },
  moveRight: { id: 'column_header.moveRight_settings', defaultMessage: 'Move column to the right' },
    Severity: Major
    Found in app/javascript/mastodon/components/column_header.jsx and 14 other locations - About 2 hrs to fix
    app/javascript/flavours/glitch/actions/compose.js on lines 89..95
    app/javascript/flavours/glitch/components/column_header.jsx on lines 21..27
    app/javascript/flavours/glitch/features/compose/components/compose_form.jsx on lines 40..46
    app/javascript/flavours/glitch/features/compose/components/federation_button.jsx on lines 14..20
    app/javascript/flavours/glitch/features/directory/index.jsx on lines 24..30
    app/javascript/flavours/glitch/features/list_timeline/index.jsx on lines 31..37
    app/javascript/flavours/glitch/features/notifications/components/notification.jsx on lines 29..35
    app/javascript/flavours/glitch/features/ui/components/mute_modal.jsx on lines 23..29
    app/javascript/mastodon/actions/compose.js on lines 83..89
    app/javascript/mastodon/components/status.jsx on lines 72..78
    app/javascript/mastodon/features/compose/components/compose_form.jsx on lines 36..42
    app/javascript/mastodon/features/directory/index.jsx on lines 24..30
    app/javascript/mastodon/features/list_timeline/index.jsx on lines 31..37
    app/javascript/mastodon/features/ui/components/mute_modal.jsx on lines 23..29

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 92.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status