Sign upLogin

glitch-soc/mastodon

View on GitHub
Star
app/javascript/mastodon/reducers/relationships.ts

Summary

Maintainability
F
5 days
Test Coverage

Function relationshipsReducer has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

export const relationshipsReducer: Reducer<State> = (
  state = initialState,
  action,
) => {
  if (authorizeFollowRequestSuccess.match(action))
Severity: Minor
Found in app/javascript/mastodon/reducers/relationships.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function relationshipsReducer has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const relationshipsReducer: Reducer<State> = (
  state = initialState,
  action,
) => {
  if (authorizeFollowRequestSuccess.match(action))
Severity: Major
Found in app/javascript/mastodon/reducers/relationships.ts - About 2 hrs to fix

    Consider simplifying this complex logical expression.
    Open

      else if (
    followAccountSuccess.match(action) ||
    unfollowAccountSuccess.match(action) ||
    blockAccountSuccess.match(action) ||
    unblockAccountSuccess.match(action) ||
    Severity: Critical
    Found in app/javascript/mastodon/reducers/relationships.ts - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

          return state.setIn([action.payload.id, 'following'], true);
      Severity: Major
      Found in app/javascript/mastodon/reducers/relationships.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return state.setIn(
      [action.payload.id, action.payload.locked ? 'requested' : 'following'],
      false,
    );
        Severity: Major
        Found in app/javascript/mastodon/reducers/relationships.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return normalizeRelationship(state, action.payload.relationship);
          Severity: Major
          Found in app/javascript/mastodon/reducers/relationships.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return setDomainBlocking(state, action.payload.accounts, false);
            Severity: Major
            Found in app/javascript/mastodon/reducers/relationships.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return setDomainBlocking(state, action.payload.accounts, true);
              Severity: Major
              Found in app/javascript/mastodon/reducers/relationships.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                  else return state;
                Severity: Major
                Found in app/javascript/mastodon/reducers/relationships.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                      return state.setIn([action.payload.id, 'following'], false);
                  Severity: Major
                  Found in app/javascript/mastodon/reducers/relationships.ts - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                        return normalizeRelationships(state, action.payload.relationships);
                    Severity: Major
                    Found in app/javascript/mastodon/reducers/relationships.ts - About 30 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                      export const relationshipsReducer: Reducer<State> = (
  state = initialState,
  action,
) => {
  if (authorizeFollowRequestSuccess.match(action))
                      Severity: Major
                      Found in app/javascript/mastodon/reducers/relationships.ts and 1 other location - About 3 days to fix
                      app/javascript/flavours/glitch/reducers/relationships.ts on lines 65..122

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 625.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                      const setDomainBlocking = (
  state: State,
  accounts: Account[],
  blocking: boolean,
) => {
                      Severity: Major
                      Found in app/javascript/mastodon/reducers/relationships.ts and 1 other location - About 2 hrs to fix
                      app/javascript/flavours/glitch/reducers/relationships.ts on lines 53..63

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 82.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                      const normalizeRelationships = (
  state: State,
  relationships: ApiRelationshipJSON[],
) => {
  relationships.forEach((relationship) => {
                      Severity: Major
                      Found in app/javascript/mastodon/reducers/relationships.ts and 1 other location - About 1 hr to fix
                      app/javascript/flavours/glitch/reducers/relationships.ts on lines 42..51

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 60.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status