Sign upLogin

glitch-soc/mastodon

View on GitHub
Star
app/models/notification_group.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method from_notifications has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

  def self.from_notifications(notifications, pagination_range: nil, grouped_types: nil)
    return [] if notifications.empty?

    grouped_types = grouped_types.presence&.map(&:to_sym) || Notification::GROUPABLE_NOTIFICATION_TYPES
Severity: Minor
Found in app/models/notification_group.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method load_groups_data has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def load_groups_data(account_id, group_keys, pagination_range: nil)
      return {} if group_keys.empty?

      if pagination_range.present?
        binds = [
Severity: Minor
Found in app/models/notification_group.rb - About 1 hr to fix

    Method from_notifications has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def self.from_notifications(notifications, pagination_range: nil, grouped_types: nil)
    return [] if notifications.empty?

    grouped_types = grouped_types.presence&.map(&:to_sym) || Notification::GROUPABLE_NOTIFICATION_TYPES
    Severity: Minor
    Found in app/models/notification_group.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status