Sign upLogin

glitch-soc/mastodon

View on GitHub
Star
app/services/activitypub/fetch_remote_status_service.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method call has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

  def call(uri, prefetched_body: nil, on_behalf_of: nil, expected_actor_uri: nil, request_id: nil)
    return if domain_not_allowed?(uri)

    @request_id = request_id || "#{Time.now.utc.to_i}-status-#{uri}"
    @json = if prefetched_body.nil?
Severity: Minor
Found in app/services/activitypub/fetch_remote_status_service.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method call has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def call(uri, prefetched_body: nil, on_behalf_of: nil, expected_actor_uri: nil, request_id: nil)
    return if domain_not_allowed?(uri)

    @request_id = request_id || "#{Time.now.utc.to_i}-status-#{uri}"
    @json = if prefetched_body.nil?
Severity: Minor
Found in app/services/activitypub/fetch_remote_status_service.rb - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

        return ActivityPub::TagManager.instance.uri_to_resource(object_uri, Status) if ActivityPub::TagManager.instance.local_uri?(object_uri)
    Severity: Major
    Found in app/services/activitypub/fetch_remote_status_service.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

            return nil if discoveries > DISCOVERIES_PER_REQUEST
      Severity: Major
      Found in app/services/activitypub/fetch_remote_status_service.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

            return if actor.nil? || actor.suspended?
        Severity: Major
        Found in app/services/activitypub/fetch_remote_status_service.rb - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status