glitch-soc/mastodon

View on GitHub

Showing 4,903 of 4,903 total issues

Avoid too many return statements within this function.
Open

    return setDomainBlocking(state, action.payload.accounts, false);
Severity: Major
Found in app/javascript/flavours/glitch/reducers/relationships.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return setDomainBlocking(state, action.payload.accounts, true);
    Severity: Major
    Found in app/javascript/flavours/glitch/reducers/relationships.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return state.setIn([action.payload.id, 'following'], true);
      Severity: Major
      Found in app/javascript/flavours/glitch/reducers/relationships.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

          return [sourceNumber, DECIMAL_UNITS.ONE, 0];
        Severity: Major
        Found in app/javascript/mastodon/utils/numbers.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return state.setIn(
                [action.payload.id, action.payload.locked ? 'requested' : 'following'],
                false,
              );
          Severity: Major
          Found in app/javascript/mastodon/reducers/relationships.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return normalizeRelationships(state, action.payload.relationships);
            Severity: Major
            Found in app/javascript/mastodon/reducers/relationships.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return setDomainBlocking(state, action.payload.accounts, true);
              Severity: Major
              Found in app/javascript/mastodon/reducers/relationships.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return state.setIn([action.payload.id, 'following'], true);
                Severity: Major
                Found in app/javascript/mastodon/reducers/relationships.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                    else return state;
                  Severity: Major
                  Found in app/javascript/mastodon/reducers/accounts.ts - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                        return state.setIn([action.payload.id, 'following'], false);
                    Severity: Major
                    Found in app/javascript/mastodon/reducers/relationships.ts - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                        else return state;
                      Severity: Major
                      Found in app/javascript/mastodon/reducers/modal.ts - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                            return setDomainBlocking(state, action.payload.accounts, false);
                        Severity: Major
                        Found in app/javascript/mastodon/reducers/relationships.ts - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                            else return state;
                          Severity: Major
                          Found in app/javascript/mastodon/reducers/relationships.ts - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                return normalizeRelationship(state, action.payload.relationship);
                            Severity: Major
                            Found in app/javascript/mastodon/reducers/relationships.ts - About 30 mins to fix

                              Similar blocks of code found in 6 locations. Consider refactoring.
                              Open

                                onChangeLanguages (account) {
                                  dispatch(openModal({
                                    modalType: 'SUBSCRIBED_LANGUAGES',
                                    modalProps: {
                                      accountId: account.get('id'),
                              app/javascript/flavours/glitch/containers/status_container.js on lines 109..114
                              app/javascript/flavours/glitch/features/account_timeline/containers/header_container.jsx on lines 117..124
                              app/javascript/flavours/glitch/features/account_timeline/containers/header_container.jsx on lines 126..133
                              app/javascript/mastodon/containers/status_container.jsx on lines 99..104
                              app/javascript/mastodon/features/account_timeline/containers/header_container.jsx on lines 119..126

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 45.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 6 locations. Consider refactoring.
                              Open

                                onAddToList (account) {
                                  dispatch(openModal({
                                    modalType: 'LIST_ADDER',
                                    modalProps: {
                                      accountId: account.get('id'),
                              app/javascript/flavours/glitch/containers/status_container.js on lines 109..114
                              app/javascript/flavours/glitch/features/account_timeline/containers/header_container.jsx on lines 126..133
                              app/javascript/mastodon/containers/status_container.jsx on lines 99..104
                              app/javascript/mastodon/features/account_timeline/containers/header_container.jsx on lines 119..126
                              app/javascript/mastodon/features/account_timeline/containers/header_container.jsx on lines 128..135

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 45.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 6 locations. Consider refactoring.
                              Open

                                onAddToList (account) {
                                  dispatch(openModal({
                                    modalType: 'LIST_ADDER',
                                    modalProps: {
                                      accountId: account.get('id'),
                              app/javascript/flavours/glitch/containers/status_container.js on lines 109..114
                              app/javascript/flavours/glitch/features/account_timeline/containers/header_container.jsx on lines 117..124
                              app/javascript/flavours/glitch/features/account_timeline/containers/header_container.jsx on lines 126..133
                              app/javascript/mastodon/containers/status_container.jsx on lines 99..104
                              app/javascript/mastodon/features/account_timeline/containers/header_container.jsx on lines 128..135

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 45.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 6 locations. Consider refactoring.
                              Open

                                onChangeLanguages (account) {
                                  dispatch(openModal({
                                    modalType: 'SUBSCRIBED_LANGUAGES',
                                    modalProps: {
                                      accountId: account.get('id'),
                              app/javascript/flavours/glitch/containers/status_container.js on lines 109..114
                              app/javascript/flavours/glitch/features/account_timeline/containers/header_container.jsx on lines 117..124
                              app/javascript/mastodon/containers/status_container.jsx on lines 99..104
                              app/javascript/mastodon/features/account_timeline/containers/header_container.jsx on lines 119..126
                              app/javascript/mastodon/features/account_timeline/containers/header_container.jsx on lines 128..135

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 45.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 6 locations. Consider refactoring.
                              Open

                                onEmbed (status) {
                                  dispatch(openModal({
                                    modalType: 'EMBED',
                                    modalProps: { id: status.get('id') },
                                  }));
                              Severity: Major
                              Found in app/javascript/mastodon/containers/status_container.jsx and 5 other locations - About 30 mins to fix
                              app/javascript/flavours/glitch/containers/status_container.js on lines 109..114
                              app/javascript/flavours/glitch/features/account_timeline/containers/header_container.jsx on lines 117..124
                              app/javascript/flavours/glitch/features/account_timeline/containers/header_container.jsx on lines 126..133
                              app/javascript/mastodon/features/account_timeline/containers/header_container.jsx on lines 119..126
                              app/javascript/mastodon/features/account_timeline/containers/header_container.jsx on lines 128..135

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 45.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 6 locations. Consider refactoring.
                              Open

                                onEmbed (status) {
                                  dispatch(openModal({
                                    modalType: 'EMBED',
                                    modalProps: { id: status.get('id') },
                                  }));
                              Severity: Major
                              Found in app/javascript/flavours/glitch/containers/status_container.js and 5 other locations - About 30 mins to fix
                              app/javascript/flavours/glitch/features/account_timeline/containers/header_container.jsx on lines 117..124
                              app/javascript/flavours/glitch/features/account_timeline/containers/header_container.jsx on lines 126..133
                              app/javascript/mastodon/containers/status_container.jsx on lines 99..104
                              app/javascript/mastodon/features/account_timeline/containers/header_container.jsx on lines 119..126
                              app/javascript/mastodon/features/account_timeline/containers/header_container.jsx on lines 128..135

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 45.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Severity
                              Category
                              Status
                              Source
                              Language