Sign upLogin

go-rel/rel

View on GitHub
Star

Showing 35 of 37 total issues

Method repository.saveHasMany has a Cognitive Complexity of 47 (exceeds 20 allowed). Consider refactoring.
Open

func (r repository) saveHasMany(cw contextWrapper, doc *Document, mutation *Mutation, insertion bool) error {
    for _, field := range doc.HasMany() {
        var (
            assoc              = doc.Association(field)
            assocMuts, changed = mutation.Assoc[field]
Severity: Minor
Found in repository.go - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function convertAssign has 140 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func convertAssign(dest, src any) error {
    // Common cases, without reflect.
    switch s := src.(type) {
    case string:
        switch d := dest.(type) {
Severity: Major
Found in convert.go - About 4 hrs to fix

    FilterQuery has 34 methods (exceeds 20 allowed). Consider refactoring.
    Open

    type FilterQuery struct {
    Type  FilterOp
    Field string
    Value any
    Inner []FilterQuery
    Severity: Minor
    Found in filter_query.go - About 4 hrs to fix

      Query has 33 methods (exceeds 20 allowed). Consider refactoring.
      Open

      type Query struct {
    empty           bool // TODO: use bitmask to mark what is updated and use it when merging two queries
    Table           string
    SelectQuery     SelectQuery
    JoinQuery       []JoinQuery
      Severity: Minor
      Found in query.go - About 4 hrs to fix

        Function convertAssign has a Cognitive Complexity of 43 (exceeds 20 allowed). Consider refactoring.
        Open

        func convertAssign(dest, src any) error {
    // Common cases, without reflect.
    switch s := src.(type) {
    case string:
        switch d := dest.(type) {
        Severity: Minor
        Found in convert.go - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method repository.mapPreloadTargets has a Cognitive Complexity of 40 (exceeds 20 allowed). Consider refactoring.
        Open

        func (r repository) mapPreloadTargets(sl slice, path []string) (map[any][]slice, string, string, reflect.Type, DocumentMeta, bool) {
    type frame struct {
        index int
        doc   *Document
    }
        Severity: Minor
        Found in repository.go - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Document has 28 methods (exceeds 20 allowed). Consider refactoring.
        Open

        type Document struct {
    v    any
    rv   reflect.Value
    rt   reflect.Type
    meta DocumentMeta
        Severity: Minor
        Found in document.go - About 3 hrs to fix

          Method Query.String has 89 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func (q Query) String() string {
    if q.SQLQuery.Statement != "" {
        return q.SQLQuery.String()
    }
          Severity: Major
          Found in query.go - About 2 hrs to fix

            Function convertAssign has 28 return statements (exceeds 4 allowed).
            Open

            func convertAssign(dest, src any) error {
    // Common cases, without reflect.
    switch s := src.(type) {
    case string:
        switch d := dest.(type) {
            Severity: Major
            Found in convert.go - About 2 hrs to fix

              Table has 22 methods (exceeds 20 allowed). Consider refactoring.
              Open

              type Table struct {
    Op          SchemaOp
    Name        string
    Rename      string
    Definitions []TableDefinition
              Severity: Minor
              Found in table.go - About 2 hrs to fix

                Method repository.saveHasMany has 79 lines of code (exceeds 50 allowed). Consider refactoring.
                Open

                func (r repository) saveHasMany(cw contextWrapper, doc *Document, mutation *Mutation, insertion bool) error {
    for _, field := range doc.HasMany() {
        var (
            assoc              = doc.Association(field)
            assocMuts, changed = mutation.Assoc[field]
                Severity: Major
                Found in repository.go - About 2 hrs to fix

                  Method repository.mapPreloadTargets has 77 lines of code (exceeds 50 allowed). Consider refactoring.
                  Open

                  func (r repository) mapPreloadTargets(sl slice, path []string) (map[any][]slice, string, string, reflect.Type, DocumentMeta, bool) {
    type frame struct {
        index int
        doc   *Document
    }
                  Severity: Major
                  Found in repository.go - About 2 hrs to fix

                    Function getDocumentMeta has 74 lines of code (exceeds 50 allowed). Consider refactoring.
                    Open

                    func getDocumentMeta(rt reflect.Type, skipAssoc bool) DocumentMeta {
    if meta, cached := documentMetaCache.Load(rt); cached {
        return DocumentMeta{
            cachedDocumentMeta: meta.(cachedDocumentMeta),
            rt:                 rt,
                    Severity: Minor
                    Found in document_meta.go - About 1 hr to fix

                      Function getAssociationMeta has 73 lines of code (exceeds 50 allowed). Consider refactoring.
                      Open

                      func getAssociationMeta(rt reflect.Type, index []int) AssociationMeta {
    var (
        key = associationKey{
            rt:    rt,
            index: encodeIndices(index),
                      Severity: Minor
                      Found in association_meta.go - About 1 hr to fix

                        Function getDocumentMeta has a Cognitive Complexity of 30 (exceeds 20 allowed). Consider refactoring.
                        Open

                        func getDocumentMeta(rt reflect.Type, skipAssoc bool) DocumentMeta {
    if meta, cached := documentMetaCache.Load(rt); cached {
        return DocumentMeta{
            cachedDocumentMeta: meta.(cachedDocumentMeta),
            rt:                 rt,
                        Severity: Minor
                        Found in document_meta.go - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                        func NewCollection(entities any, readonly ...bool) *Collection {
    switch v := entities.(type) {
    case *Collection:
        return v
    case reflect.Value:
                        Severity: Major
                        Found in collection.go and 1 other location - About 1 hr to fix
                        document.go on lines 316..329

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 157.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                        func NewDocument(entity any, readonly ...bool) *Document {
    switch v := entity.(type) {
    case *Document:
        return v
    case reflect.Value:
                        Severity: Major
                        Found in document.go and 1 other location - About 1 hr to fix
                        collection.go on lines 185..198

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 157.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Method Map.Apply has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
                        Open

                        func (m Map) Apply(doc *Document, mutation *Mutation) {
    var (
        pField = doc.PrimaryField()
        pValue = doc.PrimaryValue()
    )
                        Severity: Minor
                        Found in map.go - About 55 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method Document.Scanners has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
                        Open

                        func (d Document) Scanners(fields []string) []any {
    var (
        result    = make([]any, len(fields))
        assocRefs map[string]struct {
            fields  []string
                        Severity: Minor
                        Found in document.go - About 55 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function getAssociationMeta has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
                        Open

                        func getAssociationMeta(rt reflect.Type, index []int) AssociationMeta {
    var (
        key = associationKey{
            rt:    rt,
            index: encodeIndices(index),
                        Severity: Minor
                        Found in association_meta.go - About 55 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language