Sign upLogin

go-rel/rel

View on GitHub
Star

Showing 35 of 37 total issues

Method Changeset.applyAssocMany has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
Open

func (c Changeset) applyAssocMany(field string, mut *Mutation) {
    if chs, ok := c.assocMany[field]; ok {
        var (
            assoc      = c.doc.Association(field)
            col, _     = assoc.Collection()
Severity: Minor
Found in changeset.go - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        case reflect.Uint, reflect.Uint8, reflect.Uint16, reflect.Uint32, reflect.Uint64:
            u64, err := strconv.ParseUint(s, 10, dv.Type().Bits())
            if err != nil {
                // The errors that ParseUint returns have concrete type *NumError
                err = err.(*strconv.NumError).Err
Severity: Minor
Found in convert.go and 1 other location - About 50 mins to fix
convert.go on lines 148..156

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 120.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        case reflect.Int, reflect.Int8, reflect.Int16, reflect.Int32, reflect.Int64:
            i64, err := strconv.ParseInt(s, 10, dv.Type().Bits())
            if err != nil {
                // The errors that ParseInt returns have concrete type *NumError
                err = err.(*strconv.NumError).Err
Severity: Minor
Found in convert.go and 1 other location - About 50 mins to fix
convert.go on lines 157..165

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 120.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (q Query) SortDesc(fields ...string) Query {
    var (
        offset = len(q.SortQuery)
    )
Severity: Minor
Found in query.go and 1 other location - About 50 mins to fix
query.go on lines 257..268

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 118.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (q Query) SortAsc(fields ...string) Query {
    var (
        offset = len(q.SortQuery)
    )
Severity: Minor
Found in query.go and 1 other location - About 50 mins to fix
query.go on lines 271..282

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 118.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function isDeepZero has 6 return statements (exceeds 4 allowed).
Open

func isDeepZero(rv reflect.Value, depth int) bool {
    if depth < 0 {
        return true
    }
Severity: Major
Found in util.go - About 40 mins to fix

    Method repository.saveHasMany has 6 return statements (exceeds 4 allowed).
    Open

    func (r repository) saveHasMany(cw contextWrapper, doc *Document, mutation *Mutation, insertion bool) error {
    for _, field := range doc.HasMany() {
        var (
            assoc              = doc.Association(field)
            assocMuts, changed = mutation.Assoc[field]
    Severity: Major
    Found in repository.go - About 40 mins to fix

      Function JoinWith has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      func JoinWith(mode string, table string, from string, to string, filter ...FilterQuery) Query {
      Severity: Minor
      Found in query.go - About 35 mins to fix

        Method Structset.set has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        func (s Structset) set(doc *Document, mut *Mutation, field string, value any, force bool) {
        Severity: Minor
        Found in structset.go - About 35 mins to fix

          Function NewJoinWith has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          func NewJoinWith(mode string, table string, from string, to string, filter ...FilterQuery) JoinQuery {
          Severity: Minor
          Found in join_query.go - About 35 mins to fix

            Method Query.JoinWith has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            func (q Query) JoinWith(mode string, table string, from string, to string, filter ...FilterQuery) Query {
            Severity: Minor
            Found in query.go - About 35 mins to fix

              Method Collection.PrimaryValues has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
              Open

              func (c Collection) PrimaryValues() []any {
    if p, ok := c.v.(primary); ok {
        return p.PrimaryValues()
    }
              Severity: Minor
              Found in collection.go - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method Query.String has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
              Open

              func (q Query) String() string {
    if q.SQLQuery.Statement != "" {
        return q.SQLQuery.String()
    }
              Severity: Minor
              Found in query.go - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method repository.insert has 5 return statements (exceeds 4 allowed).
              Open

              func (r repository) insert(cw contextWrapper, doc *Document, mutation Mutation) error {
    var (
        pField   string
        pFields  = doc.PrimaryFields()
        queriers = Build(doc.Table())
              Severity: Major
              Found in repository.go - About 35 mins to fix

                Method repository.update has 5 return statements (exceeds 4 allowed).
                Open

                func (r repository) update(cw contextWrapper, doc *Document, mutation Mutation, filter FilterQuery) error {
    if mutation.Cascade {
        if err := r.saveBelongsTo(cw, doc, &mutation); err != nil {
            return err
        }
                Severity: Major
                Found in repository.go - About 35 mins to fix
                  Severity
                  Category
                  Status
                  Source
                  Language