Sign upLogin

gocodebox/lifterlms

View on GitHub
Star

Showing 1,389 of 1,394 total issues

Function create_pending_order has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function create_pending_order() {

        $verify = $this->verify_request( '_llms_checkout_nonce', self::ACTION_CREATE_PENDING_ORDER );
        if ( ! $verify ) {
            return $verify;
Severity: Minor
Found in includes/controllers/class-llms-controller-checkout.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method meta_auth_callback has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function meta_auth_callback( $allowed, $meta_key, $object_id, $user_id, $cap, $caps ) {
Severity: Minor
Found in includes/forms/class-llms-form-post-type.php - About 45 mins to fix

    Function explode_options_to_fields has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function explode_options_to_fields( $is_hidden = false ) {

        $fields = array();
        $value  = ! empty( $this->settings['value'] ) || is_array( $this->settings['value'] )
            ? $this->settings['value']
    Severity: Minor
    Found in includes/forms/class-llms-form-field.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function cascade_visibility_attrs has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        private function cascade_visibility_attrs( $blocks, $visibility = null ) {

        foreach ( $blocks as &$block ) {

            // If a visibility setting has been passed from the parent and the block does not have visibility setting of it's own.
    Severity: Minor
    Found in includes/forms/class-llms-forms.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function add_recipient has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function add_recipient( $address, $type = 'to', $name = '' ) {

        // If an ID was supplied, get the information from the student object.
        if ( is_numeric( $address ) ) {
            $student = llms_get_student( $address );
    Severity: Minor
    Found in includes/emails/class.llms.email.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_test_settings has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function get_test_settings( $type ) {

        if ( 'email' !== $type ) {
            return;
        }
    Severity: Minor
    Found in includes/notifications/controllers/class.llms.notification.controller.quiz.passed.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_test_settings has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function get_test_settings( $type ) {

        if ( 'email' !== $type ) {
            return array();
        }
    Severity: Minor
    Found in includes/notifications/controllers/class.llms.notification.controller.quiz.failed.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                            if ( $instructor && $student ) {
                            foreach ( $instructor->get_posts(
                                array(
                                    'posts_per_page' => -1,
                                ),
    Severity: Major
    Found in includes/functions/llms.functions.person.php - About 45 mins to fix

      Function get_test_settings has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public function get_test_settings( $type ) {

        if ( 'email' !== $type ) {
            return;
        }
      Severity: Minor
      Found in includes/notifications/controllers/class.llms.notification.controller.quiz.graded.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function get_output has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function get_output() {

        $course  = new LLMS_Course( $this->get_attribute( 'course_id' ) );
        $student = llms_get_student();
      Severity: Minor
      Found in includes/shortcodes/class.llms.shortcode.course.outline.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

                  get_l10n_type: function( plural ) {

                if ( plural ) {
                    return LLMS.l10n.translate( 'questions' );
                }
      Severity: Major
      Found in assets/js/builder/Models/Question.js and 3 other locations - About 45 mins to fix
      assets/js/builder/Models/Lesson.js on lines 129..136
      assets/js/builder/Models/Quiz.js on lines 145..152
      assets/js/builder/Models/Section.js on lines 98..105

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

              get_l10n_type: function( plural ) {

            if ( plural ) {
                return LLMS.l10n.translate( 'sections' );
            }
      Severity: Major
      Found in assets/js/builder/Models/Section.js and 3 other locations - About 45 mins to fix
      assets/js/builder/Models/Lesson.js on lines 129..136
      assets/js/builder/Models/Question.js on lines 218..225
      assets/js/builder/Models/Quiz.js on lines 145..152

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                              if ( info.id != info.orig_id ) {
                            model.set( 'id', info.id );
                            delete model._unsavedChanges.id;
                        }
      Severity: Minor
      Found in assets/js/builder/Controllers/Sync.js and 1 other location - About 45 mins to fix
      assets/js/builder/Controllers/Sync.js on lines 429..432

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

              get_l10n_type: function( plural ) {

            if ( plural ) {
                return LLMS.l10n.translate( 'quizzes' );
            }
      Severity: Major
      Found in assets/js/builder/Models/Quiz.js and 3 other locations - About 45 mins to fix
      assets/js/builder/Models/Lesson.js on lines 129..136
      assets/js/builder/Models/Question.js on lines 218..225
      assets/js/builder/Models/Section.js on lines 98..105

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                          if ( info.id != info.orig_id ) {
                        model.set( 'id', info.id );
                        delete model._unsavedChanges.id;
                    }
      Severity: Minor
      Found in assets/js/builder/Controllers/Sync.js and 1 other location - About 45 mins to fix
      assets/js/builder/Controllers/Sync.js on lines 459..462

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

              get_l10n_type: function( plural ) {

            if ( plural ) {
                return LLMS.l10n.translate( 'lessons' );
            }
      Severity: Major
      Found in assets/js/builder/Models/Lesson.js and 3 other locations - About 45 mins to fix
      assets/js/builder/Models/Question.js on lines 218..225
      assets/js/builder/Models/Quiz.js on lines 145..152
      assets/js/builder/Models/Section.js on lines 98..105

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      this.choiceListView = new ChoiceListView( {
                    el: this.$el.find( '.llms-question-choices' ),
                    collection: this.model.get( 'choices' ),
                } );
      Severity: Minor
      Found in assets/js/builder/Views/Question.js and 1 other location - About 45 mins to fix
      assets/js/builder/Views/Section.js on lines 112..115

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  this.lessonListView = new LessonListView( {
                el: this.$el.find( '.llms-lessons' ),
                collection: this.model.get( 'lessons' ),
            } );
      Severity: Minor
      Found in assets/js/builder/Views/Section.js and 1 other location - About 45 mins to fix
      assets/js/builder/Views/Question.js on lines 96..99

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                          array(
                        'type'       => 'text',
                        'label'      => __( 'Email CC:', 'lifterlms' ),
                        'desc'       => __( 'Separate multiple address with a comma.', 'lifterlms' ) . llms_merge_code_button( '#' . $this->prefix . 'email_cc', false, $email_merge ),
                        'id'         => $this->prefix . 'email_cc',
      Severity: Minor
      Found in includes/admin/post-types/meta-boxes/class.llms.meta.box.email.settings.php and 1 other location - About 45 mins to fix
      includes/admin/post-types/meta-boxes/class.llms.meta.box.email.settings.php on lines 110..118

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 95.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                          array(
                        'type'       => 'text',
                        'label'      => __( 'Email BCC:', 'lifterlms' ),
                        'desc'       => __( 'Separate multiple address with a comma.', 'lifterlms' ) . llms_merge_code_button( '#' . $this->prefix . 'email_bcc', false, $email_merge ),
                        'id'         => $this->prefix . 'email_bcc',
      Severity: Minor
      Found in includes/admin/post-types/meta-boxes/class.llms.meta.box.email.settings.php and 1 other location - About 45 mins to fix
      includes/admin/post-types/meta-boxes/class.llms.meta.box.email.settings.php on lines 101..109

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 95.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language