Sign upLogin

gomoob/php-pushwoosh

View on GitHub
Star
src/main/php/Gomoob/Pushwoosh/Model/Notification/Notification.php

Summary

Maintainability
D
2 days
Test Coverage
A
100%

Notification has 59 functions (exceeds 20 allowed). Consider refactoring.
Open

class Notification implements \JsonSerializable
{
    /**
     * An object which contains specific Pushwoosh notification informations for ADM (Amazon Device Messaging).
     *
Severity: Major
Found in src/main/php/Gomoob/Pushwoosh/Model/Notification/Notification.php - About 1 day to fix

    File Notification.php has 359 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

/**
 * gomoob/php-pushwoosh
 *
    Severity: Minor
    Found in src/main/php/Gomoob/Pushwoosh/Model/Notification/Notification.php - About 4 hrs to fix

      Method jsonSerialize has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function jsonSerialize()
    {
        $json = [];
    
        // Mandatory parameters
      Severity: Minor
      Found in src/main/php/Gomoob/Pushwoosh/Model/Notification/Notification.php - About 1 hr to fix

        Function setSendDate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function setSendDate(/* \DateTime */ $sendDate)
    {
        // Try to parse a string date
        if (is_string($sendDate) && $sendDate !== 'now') {
            $newSendDate = \DateTime::createFromFormat('Y-m-d H:i', $sendDate);
        Severity: Minor
        Found in src/main/php/Gomoob/Pushwoosh/Model/Notification/Notification.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function jsonSerialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function jsonSerialize()
    {
        $json = [];
    
        // Mandatory parameters
        Severity: Minor
        Found in src/main/php/Gomoob/Pushwoosh/Model/Notification/Notification.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function setSendDate(/* \DateTime */ $sendDate)
    {
        // Try to parse a string date
        if (is_string($sendDate) && $sendDate !== 'now') {
            $newSendDate = \DateTime::createFromFormat('Y-m-d H:i', $sendDate);
        Severity: Major
        Found in src/main/php/Gomoob/Pushwoosh/Model/Notification/Notification.php and 1 other location - About 1 hr to fix
        src/main/php/Gomoob/Pushwoosh/Model/Request/CreateTargetedMessageRequest.php on lines 522..545

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 120.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status