grokify/lita_dotenv

View on GitHub

Showing 35 of 35 total issues

Assignment Branch Condition size for config_env is too high. [47.39/15]
Open

     def config_env
      ENV.keys.grep(/^LITA_/i) do |key|
        val = ENV[key]
        slugs = key.split('__')
         # Convert value types
Severity: Minor
Found in lib/lita_dotenv/loader.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [33/10]
Open

     def config_env
      ENV.keys.grep(/^LITA_/i) do |key|
        val = ENV[key]
        slugs = key.split('__')
         # Convert value types
Severity: Minor
Found in lib/lita_dotenv/loader.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method config_env has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

     def config_env
      ENV.keys.grep(/^LITA_/i) do |key|
        val = ENV[key]
        slugs = key.split('__')
         # Convert value types
Severity: Minor
Found in lib/lita_dotenv/loader.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Perceived complexity for config_env is too high. [14/7]
Open

     def config_env
      ENV.keys.grep(/^LITA_/i) do |key|
        val = ENV[key]
        slugs = key.split('__')
         # Convert value types
Severity: Minor
Found in lib/lita_dotenv/loader.rb by rubocop

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Cyclomatic complexity for config_env is too high. [12/6]
Open

     def config_env
      ENV.keys.grep(/^LITA_/i) do |key|
        val = ENV[key]
        slugs = key.split('__')
         # Convert value types
Severity: Minor
Found in lib/lita_dotenv/loader.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method config_env has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

     def config_env
      ENV.keys.grep(/^LITA_/i) do |key|
        val = ENV[key]
        slugs = key.split('__')
         # Convert value types
Severity: Minor
Found in lib/lita_dotenv/loader.rb - About 1 hr to fix

    Block has too many lines. [31/25]
    Open

          ENV.keys.grep(/^LITA_/i) do |key|
            val = ENV[key]
            slugs = key.split('__')
             # Convert value types
            if slugs.length==2
    Severity: Minor
    Found in lib/lita_dotenv/loader.rb by rubocop

    This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

    Final newline missing.
    Open

    task default: :spec
    Severity: Minor
    Found in Rakefile by rubocop

    Missing top-level module documentation comment.
    Open

    module LitaDotenv
    Severity: Minor
    Found in lib/lita_dotenv.rb by rubocop

    This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

    The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

    Example:

    # bad
    class Person
      # ...
    end
    
    # good
    # Description/Explanation of Person class
    class Person
      # ...
    end

    Space missing after comma.
    Open

              @config.send(path[0]).send("#{path[1]}=",val)
    Severity: Minor
    Found in lib/lita_dotenv/loader.rb by rubocop

    Checks for comma (,) not followed by some kind of space.

    Example:

    # bad
    [1,2]
    { foo:bar,}
    
    # good
    [1, 2]
    { foo:bar, }

    Surrounding space missing for operator ==.
    Open

            if slugs.length==2
    Severity: Minor
    Found in lib/lita_dotenv/loader.rb by rubocop

    Checks that operators have space around them, except for ** which should not have surrounding space.

    Example:

    # bad
    total = 3*4
    "apple"+"juice"
    my_number = 38/4
    a ** b
    
    # good
    total = 3 * 4
    "apple" + "juice"
    my_number = 38 / 4
    a**b

    %q-literals should be delimited by ( and ).
    Open

      spec.description   = %q{A Lita .env config loader.}
    Severity: Minor
    Found in lita_dotenv.gemspec by rubocop

    This cop enforces the consistent usage of %-literal delimiters.

    Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

    Example:

    # Style/PercentLiteralDelimiters:
    #   PreferredDelimiters:
    #     default: '[]'
    #     '%i':    '()'
    
    # good
    %w[alpha beta] + %i(gamma delta)
    
    # bad
    %W(alpha #{beta})
    
    # bad
    %I(alpha beta)

    Incorrect indentation detected (column 9 instead of 8).
    Open

             # Convert value types
    Severity: Minor
    Found in lib/lita_dotenv/loader.rb by rubocop

    This cops checks the indentation of comments.

    Example:

    # bad
      # comment here
    def method_name
    end
    
      # comment here
    a = 'hello'
    
    # yet another comment
      if true
        true
      end
    
    # good
    # comment here
    def method_name
    end
    
    # comment here
    a = 'hello'
    
    # yet another comment
    if true
      true
    end

    Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Open

    require "rspec/core/rake_task"
    Severity: Minor
    Found in Rakefile by rubocop

    Checks if uses of quotes match the configured preference.

    Example: EnforcedStyle: single_quotes (default)

    # bad
    "No special symbols"
    "No string interpolation"
    "Just text"
    
    # good
    'No special symbols'
    'No string interpolation'
    'Just text'
    "Wait! What's #{this}!"

    Example: EnforcedStyle: double_quotes

    # bad
    'Just some text'
    'No special chars or interpolation'
    
    # good
    "Just some text"
    "No special chars or interpolation"
    "Every string in #{project} uses double_quotes"

    Line is too long. [110/80]
    Open

      spec.summary       = %q{A Lita .env config loader that loads ENV values directly into Lita's configuration.}
    Severity: Minor
    Found in lita_dotenv.gemspec by rubocop

    Use %q only for strings that contain both single quotes and double quotes.
    Open

      spec.description   = %q{A Lita .env config loader.}
    Severity: Minor
    Found in lita_dotenv.gemspec by rubocop

    %q-literals should be delimited by ( and ).
    Open

      spec.summary       = %q{A Lita .env config loader that loads ENV values directly into Lita's configuration.}
    Severity: Minor
    Found in lita_dotenv.gemspec by rubocop

    This cop enforces the consistent usage of %-literal delimiters.

    Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

    Example:

    # Style/PercentLiteralDelimiters:
    #   PreferredDelimiters:
    #     default: '[]'
    #     '%i':    '()'
    
    # good
    %w[alpha beta] + %i(gamma delta)
    
    # bad
    %W(alpha #{beta})
    
    # bad
    %I(alpha beta)

    Missing top-level class documentation comment.
    Open

      class Loader
    Severity: Minor
    Found in lib/lita_dotenv/loader.rb by rubocop

    This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

    The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

    Example:

    # bad
    class Person
      # ...
    end
    
    # good
    # Description/Explanation of Person class
    class Person
      # ...
    end

    Freeze mutable objects assigned to constants.
    Open

      VERSION = '0.0.2'
    Severity: Minor
    Found in lib/lita_dotenv.rb by rubocop

    This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

    Example:

    # bad
    CONST = [1, 2, 3]
    
    # good
    CONST = [1, 2, 3].freeze

    Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
    Open

              if part =~ /[a-z]/
    Severity: Minor
    Found in lib/lita_dotenv/loader.rb by rubocop

    Checks for if and unless statements that would fit on one line if written as a modifier if/unless. The maximum line length is configured in the Metrics/LineLength cop.

    Example:

    # bad
    if condition
      do_stuff(bar)
    end
    
    unless qux.empty?
      Foo.do_something
    end
    
    # good
    do_stuff(bar) if condition
    Foo.do_something unless qux.empty?
    Severity
    Category
    Status
    Source
    Language