Sign upLogin

grokify/lita_dotenv

View on GitHub
Star

Showing 35 of 35 total issues

Final newline missing.
Open

gemspec
Severity: Minor
Found in Gemfile by rubocop

Inconsistent indentation detected.
Open

     def config_env
      ENV.keys.grep(/^LITA_/i) do |key|
        val = ENV[key]
        slugs = key.split('__')
         # Convert value types
Severity: Minor
Found in lib/lita_dotenv/loader.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Use 2 (not 1) spaces for indentation.
Open

      ENV.keys.grep(/^LITA_/i) do |key|
Severity: Minor
Found in lib/lita_dotenv/loader.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Space missing after comma.
Open

          @config.send(path[0]).send(path[1]).send("#{path[2]}=",val)
Severity: Minor
Found in lib/lita_dotenv/loader.rb by rubocop

Checks for comma (,) not followed by some kind of space.

Example:

# bad
[1,2]
{ foo:bar,}

# good
[1, 2]
{ foo:bar, }

Inconsistent indentation detected.
Open

     def initialize(config)
       @config = config
       Dotenv.load
       config_env
     end
Severity: Minor
Found in lib/lita_dotenv/loader.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

end at 50, 4 is not aligned with def at 14, 5.
Open

    end
Severity: Minor
Found in lib/lita_dotenv/loader.rb by rubocop

This cop checks whether the end keywords of method definitions are aligned properly.

Two modes are supported through the EnforcedStyleAlignWith configuration parameter. If it's set to start_of_line (which is the default), the end shall be aligned with the start of the line where the def keyword is. If it's set to def, the end shall be aligned with the def keyword.

Example: EnforcedStyleAlignWith: startofline (default)

# bad

private def foo
            end

# good

private def foo
end

Example: EnforcedStyleAlignWith: def

# bad

private def foo
            end

# good

private def foo
        end

Incorrect indentation detected (column 9 instead of 8).
Open

         # Convert path
Severity: Minor
Found in lib/lita_dotenv/loader.rb by rubocop

This cops checks the indentation of comments.

Example:

# bad
  # comment here
def method_name
end

  # comment here
a = 'hello'

# yet another comment
  if true
    true
  end

# good
# comment here
def method_name
end

# comment here
a = 'hello'

# yet another comment
if true
  true
end

Use casecmp instead of downcase ==.
Open

            val = val.downcase == 'true' ? true : false
Severity: Minor
Found in lib/lita_dotenv/loader.rb by rubocop

This cop identifies places where a case-insensitive string comparison can better be implemented using casecmp.

Example:

# bad
str.downcase == 'abc'
str.upcase.eql? 'ABC'
'abc' == str.downcase
'ABC'.eql? str.upcase
str.downcase == str.downcase

# good
str.casecmp('ABC').zero?
'abc'.casecmp(str).zero?

Use %q only for strings that contain both single quotes and double quotes.
Open

  spec.summary       = %q{A Lita .env config loader that loads ENV values directly into Lita's configuration.}
Severity: Minor
Found in lita_dotenv.gemspec by rubocop

Final newline missing.
Open

end
Severity: Minor
Found in lib/lita_dotenv.rb by rubocop

Surrounding space missing for operator ==.
Open

          if type=='typesym'
Severity: Minor
Found in lib/lita_dotenv/loader.rb by rubocop

Checks that operators have space around them, except for ** which should not have surrounding space.

Example:

# bad
total = 3*4
"apple"+"juice"
my_number = 38/4
a ** b

# good
total = 3 * 4
"apple" + "juice"
my_number = 38 / 4
a**b

Line is too long. [88/80]
Open

          raise "Config path length #{path.length} not supported for #{path.join('.')}."
Severity: Minor
Found in lib/lita_dotenv/loader.rb by rubocop

This conditional expression can just be replaced by val.downcase == 'true'.
Open

            val = val.downcase == 'true' ? true : false
Severity: Minor
Found in lib/lita_dotenv/loader.rb by rubocop

This cop checks for redundant returning of true/false in conditionals.

Example:

# bad
x == y ? true : false

# bad
if x == y
  true
else
  false
end

# good
x == y

# bad
x == y ? false : true

# good
x != y

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

require "bundler/gem_tasks"
Severity: Minor
Found in Rakefile by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

source "https://rubygems.org"
Severity: Minor
Found in Gemfile by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"
Severity
Category
Status
Source
Language