Sign upLogin

grokify/mogo

View on GitHub
Star
time/timeutil/timeutil_delta.go

Summary

Maintainability
A
2 hrs
Test Coverage

Function TimeDeltaDowString has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

func TimeDeltaDowString(base time.Time, wantDowS string, deltaUnits int, wantInclusive bool, wantStartOfDay bool) (time.Time, error) {
Severity: Minor
Found in time/timeutil/timeutil_delta.go - About 35 mins to fix

    Function TimeDeltaDow has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    func TimeDeltaDow(base time.Time, wantDow time.Weekday, deltaUnits int, wantInclusive bool, wantStartOfDay bool) (time.Time, error) {
    Severity: Minor
    Found in time/timeutil/timeutil_delta.go - About 35 mins to fix

      Function TimeDeltaDowInt has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      func TimeDeltaDowInt(base time.Time, wantDow time.Weekday, deltaUnits int, wantInclusive bool, wantStartOfDay bool) (time.Time, error) {
      Severity: Minor
      Found in time/timeutil/timeutil_delta.go - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func DaysToDow(baseDow, wantDow time.Weekday, wantInclusive bool) int {
    deltaDays1 := int(WeekdayNormalized(wantDow)) - int(WeekdayNormalized(baseDow))
    deltaDays2 := deltaDays1
    if deltaDays2 < 0 {
        deltaDays2 += 7
        Severity: Minor
        Found in time/timeutil/timeutil_delta.go and 1 other location - About 30 mins to fix
        time/timeutil/timeutil_delta.go on lines 81..91

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 101.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func DaysAgoDow(baseDow, wantDow time.Weekday, wantInclusive bool) int {
    deltaDays1 := int(WeekdayNormalized(baseDow)) - int(WeekdayNormalized(wantDow))
    deltaDays2 := deltaDays1
    if deltaDays2 < 0 {
        deltaDays2 += 7
        Severity: Minor
        Found in time/timeutil/timeutil_delta.go and 1 other location - About 30 mins to fix
        time/timeutil/timeutil_delta.go on lines 106..116

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 101.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status