Sign upLogin

guibranco/MaxiPago-SDK-dotnet

View on GitHub
Star
Src/MaxiPago/Gateway/Api.cs

Summary

Maintainability
C
1 day
Test Coverage

Method AddCardOnFile has 19 arguments (exceeds 4 allowed). Consider refactoring.
Open

            string merchantId,
            string merchantKey,
            string customerId,
            string creditCardNumber,
            string expirationMonth,
Severity: Major
Found in Src/MaxiPago/Gateway/Api.cs - About 2 hrs to fix

    Method UpdateConsumer has 16 arguments (exceeds 4 allowed). Consider refactoring.
    Open

                string merchantId,
            string merchantKey,
            string customerId,
            string customerIdExt,
            string firstName,
    Severity: Major
    Found in Src/MaxiPago/Gateway/Api.cs - About 2 hrs to fix

      Method AddConsumer has 15 arguments (exceeds 4 allowed). Consider refactoring.
      Open

                  string merchantId,
            string merchantKey,
            string customerIdExt,
            string firstName,
            string lastName,
      Severity: Major
      Found in Src/MaxiPago/Gateway/Api.cs - About 1 hr to fix

        Method AddCardOnFile has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                public ApiResponse AddCardOnFile(
            string merchantId,
            string merchantKey,
            string customerId,
            string creditCardNumber,
        Severity: Minor
        Found in Src/MaxiPago/Gateway/Api.cs - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  public ApiResponse DeleteConsumer(string merchantId, string merchantKey, string customerId)
        {
            _request = new ApiRequest(merchantId, merchantKey)
            {
                Command = "delete-consumer",
          Severity: Minor
          Found in Src/MaxiPago/Gateway/Api.cs and 1 other location - About 40 mins to fix
          Src/MaxiPago/Gateway/Api.cs on lines 321..329

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 72.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  public ApiResponse CancelRecurring(string merchantId, string merchantKey, string orderID)
        {
            _request = new ApiRequest(merchantId, merchantKey)
            {
                Command = "cancel-recurring",
          Severity: Minor
          Found in Src/MaxiPago/Gateway/Api.cs and 1 other location - About 40 mins to fix
          Src/MaxiPago/Gateway/Api.cs on lines 120..128

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 72.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status