Sign upLogin

guibranco/MaxiPago-SDK-dotnet

View on GitHub
Star

Showing 52 of 52 total issues

File Transaction.cs has 997 lines of code (exceeds 250 allowed). Consider refactoring.
Open

using System.Threading;
using MaxiPago.DataContract;
using MaxiPago.DataContract.Transactional;

namespace MaxiPago.Gateway
Severity: Major
Found in Src/MaxiPago/Gateway/Transaction.cs - About 2 days to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            public ResponseBase Sale(
            string merchantId,
            string merchantKey,
            string referenceNum,
            decimal chargeTotal,
    Severity: Major
    Found in Src/MaxiPago/Gateway/Transaction.cs and 1 other location - About 4 hrs to fix
    Src/MaxiPago/Gateway/Transaction.cs on lines 658..750

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 320.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            public ResponseBase Auth(
            string merchantId,
            string merchantKey,
            string referenceNum,
            decimal chargeTotal,
    Severity: Major
    Found in Src/MaxiPago/Gateway/Transaction.cs and 1 other location - About 4 hrs to fix
    Src/MaxiPago/Gateway/Transaction.cs on lines 272..364

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 320.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method Sale has 37 arguments (exceeds 4 allowed). Consider refactoring.
    Open

                string merchantId,
            string merchantKey,
            string referenceNum,
            decimal chargeTotal,
            string creditCardNumber,
    Severity: Major
    Found in Src/MaxiPago/Gateway/Transaction.cs - About 4 hrs to fix

      Method Auth has 37 arguments (exceeds 4 allowed). Consider refactoring.
      Open

                  string merchantId,
            string merchantKey,
            string referenceNum,
            decimal chargeTotal,
            string creditCardNumber,
      Severity: Major
      Found in Src/MaxiPago/Gateway/Transaction.cs - About 4 hrs to fix

        Class CommandRequest has 32 methods (exceeds 20 allowed). Consider refactoring.
        Open

            [Serializable]
    [XmlRoot(ElementName = "request")]
    public class CommandRequest
    {
        /// <summary>
        Severity: Minor
        Found in Src/MaxiPago/DataContract/NonTransactional/CommandRequest.cs - About 4 hrs to fix

          Method PaySavingCreditCardAutomatically has 32 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                      string operation,
            string merchantId,
            string merchantKey,
            string referenceNum,
            decimal chargeTotal,
          Severity: Major
          Found in Src/MaxiPago/Gateway/Transaction.cs - About 4 hrs to fix

            Method Auth has 31 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                        string merchantId,
            string merchantKey,
            string referenceNum,
            decimal chargeTotal,
            string creditCardNumber,
            Severity: Major
            Found in Src/MaxiPago/Gateway/Transaction.cs - About 3 hrs to fix

              Method Sale has 31 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                          string merchantId,
            string merchantKey,
            string referenceNum,
            decimal chargeTotal,
            string creditCardNumber,
              Severity: Major
              Found in Src/MaxiPago/Gateway/Transaction.cs - About 3 hrs to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        public ResponseBase Auth(
            string merchantId,
            string merchantKey,
            string referenceNum,
            decimal chargeTotal,
                Severity: Major
                Found in Src/MaxiPago/Gateway/Transaction.cs and 1 other location - About 2 hrs to fix
                Src/MaxiPago/Gateway/Transaction.cs on lines 455..523

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 205.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        public ResponseBase Sale(
            string merchantId,
            string merchantKey,
            string referenceNum,
            decimal chargeTotal,
                Severity: Major
                Found in Src/MaxiPago/Gateway/Transaction.cs and 1 other location - About 2 hrs to fix
                Src/MaxiPago/Gateway/Transaction.cs on lines 841..909

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 205.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Method FillRequestBase has 20 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                            string operation,
            string merchantId,
            string merchantKey,
            string referenceNum,
            decimal chargeTotal,
                Severity: Major
                Found in Src/MaxiPago/Gateway/Transaction.cs - About 2 hrs to fix

                  Method Recurring has 20 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                              string merchantId,
            string merchantKey,
            string referenceNum,
            decimal chargeTotal,
            string creditCardNumber,
                  Severity: Major
                  Found in Src/MaxiPago/Gateway/Transaction.cs - About 2 hrs to fix

                    Method PaySavingCreditCardAutomatically has 62 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            private ResponseBase PaySavingCreditCardAutomatically(
            string operation,
            string merchantId,
            string merchantKey,
            string referenceNum,
                    Severity: Major
                    Found in Src/MaxiPago/Gateway/Transaction.cs - About 2 hrs to fix

                      Method Boleto has 19 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                                  string merchantId,
            string merchantKey,
            string referenceNum,
            decimal chargeTotal,
            string processorId,
                      Severity: Major
                      Found in Src/MaxiPago/Gateway/Transaction.cs - About 2 hrs to fix

                        Method Sale has 19 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                                    string merchantId,
            string merchantKey,
            string referenceNum,
            decimal chargeTotal,
            string creditCardNumber,
                        Severity: Major
                        Found in Src/MaxiPago/Gateway/Transaction.cs - About 2 hrs to fix

                          Method Auth has 19 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                                      string merchantId,
            string merchantKey,
            string referenceNum,
            decimal chargeTotal,
            string creditCardNumber,
                          Severity: Major
                          Found in Src/MaxiPago/Gateway/Transaction.cs - About 2 hrs to fix

                            Method AddCardOnFile has 19 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                        string merchantId,
            string merchantKey,
            string customerId,
            string creditCardNumber,
            string expirationMonth,
                            Severity: Major
                            Found in Src/MaxiPago/Gateway/Api.cs - About 2 hrs to fix

                              Method Recurring has 17 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                          string merchantId,
            string merchantKey,
            string referenceNum,
            decimal chargeTotal,
            string customerId,
                              Severity: Major
                              Found in Src/MaxiPago/Gateway/Transaction.cs - About 2 hrs to fix

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                        public ResponseBase Auth(
            string merchantId,
            string merchantKey,
            string referenceNum,
            decimal chargeTotal,
                                Severity: Major
                                Found in Src/MaxiPago/Gateway/Transaction.cs and 1 other location - About 2 hrs to fix
                                Src/MaxiPago/Gateway/Transaction.cs on lines 82..128

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 152.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Severity
                                Category
                                Status
                                Source
                                Language