Showing 52 of 52 total issues
Similar blocks of code found in 2 locations. Consider refactoring. Open
public ResponseBase Sale(
string merchantId,
string merchantKey,
string referenceNum,
decimal chargeTotal,
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 152.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Method Auth
has 50 lines of code (exceeds 25 allowed). Consider refactoring. Open
public ResponseBase Auth(
string merchantId,
string merchantKey,
string referenceNum,
decimal chargeTotal,
Method Sale
has 50 lines of code (exceeds 25 allowed). Consider refactoring. Open
public ResponseBase Sale(
string merchantId,
string merchantKey,
string referenceNum,
decimal chargeTotal,
Method UpdateConsumer
has 16 arguments (exceeds 4 allowed). Consider refactoring. Open
string merchantId,
string merchantKey,
string customerId,
string customerIdExt,
string firstName,
Method PayWithToken
has 15 arguments (exceeds 4 allowed). Consider refactoring. Open
string operation,
string merchantId,
string merchantKey,
string referenceNum,
decimal chargeTotal,
Method FillRecurringBase
has 15 arguments (exceeds 4 allowed). Consider refactoring. Open
string merchantId,
string merchantKey,
string referenceNum,
decimal chargeTotal,
string processorId,
Method AddConsumer
has 15 arguments (exceeds 4 allowed). Consider refactoring. Open
string merchantId,
string merchantKey,
string customerIdExt,
string firstName,
string lastName,
Method Sale
has 14 arguments (exceeds 4 allowed). Consider refactoring. Open
string merchantId,
string merchantKey,
string referenceNum,
decimal chargeTotal,
string processorId,
Method Auth
has 14 arguments (exceeds 4 allowed). Consider refactoring. Open
string merchantId,
string merchantKey,
string referenceNum,
decimal chargeTotal,
string processorId,
Method FillRequestBase
has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
private void FillRequestBase(
string operation,
string merchantId,
string merchantKey,
string referenceNum,
Method PayWithToken
has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
private ResponseBase PayWithToken(
string operation,
string merchantId,
string merchantKey,
string referenceNum,
Method GetTransactionDetailReport
has 12 arguments (exceeds 4 allowed). Consider refactoring. Open
string merchantId,
string merchantKey,
string period,
string pageSize,
string startDate,
Method Auth
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
public ResponseBase Auth(
string merchantId,
string merchantKey,
string referenceNum,
decimal chargeTotal,
Method Sale
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
public ResponseBase Sale(
string merchantId,
string merchantKey,
string referenceNum,
decimal chargeTotal,
Similar blocks of code found in 2 locations. Consider refactoring. Open
public ResponseBase Capture(
string merchantId,
string merchantKey,
string orderID,
string referenceNum,
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 114.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
public ResponseBase Return(
string merchantId,
string merchantKey,
string orderID,
string referenceNum,
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 114.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Method Boleto
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
public ResponseBase Boleto(
string merchantId,
string merchantKey,
string referenceNum,
decimal chargeTotal,
Method FillRecurringBase
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
private void FillRecurringBase(
string merchantId,
string merchantKey,
string referenceNum,
decimal chargeTotal,
Similar blocks of code found in 2 locations. Consider refactoring. Open
public ResponseBase Sale(
string merchantId,
string merchantKey,
string referenceNum,
decimal chargeTotal,
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 103.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
public ResponseBase Auth(
string merchantId,
string merchantKey,
string referenceNum,
decimal chargeTotal,
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 103.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76