guibranco/MaxiPago-SDK-dotnet

View on GitHub

Showing 52 of 52 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        public ResponseBase Sale(
            string merchantId,
            string merchantKey,
            string referenceNum,
            decimal chargeTotal,
Severity: Major
Found in Src/MaxiPago/Gateway/Transaction.cs and 1 other location - About 2 hrs to fix
Src/MaxiPago/Gateway/Transaction.cs on lines 569..615

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 152.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method Auth has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        public ResponseBase Auth(
            string merchantId,
            string merchantKey,
            string referenceNum,
            decimal chargeTotal,
Severity: Minor
Found in Src/MaxiPago/Gateway/Transaction.cs - About 2 hrs to fix

    Method Sale has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            public ResponseBase Sale(
                string merchantId,
                string merchantKey,
                string referenceNum,
                decimal chargeTotal,
    Severity: Minor
    Found in Src/MaxiPago/Gateway/Transaction.cs - About 2 hrs to fix

      Method UpdateConsumer has 16 arguments (exceeds 4 allowed). Consider refactoring.
      Open

                  string merchantId,
                  string merchantKey,
                  string customerId,
                  string customerIdExt,
                  string firstName,
      Severity: Major
      Found in Src/MaxiPago/Gateway/Api.cs - About 2 hrs to fix

        Method PayWithToken has 15 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                    string operation,
                    string merchantId,
                    string merchantKey,
                    string referenceNum,
                    decimal chargeTotal,
        Severity: Major
        Found in Src/MaxiPago/Gateway/Transaction.cs - About 1 hr to fix

          Method FillRecurringBase has 15 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                      string merchantId,
                      string merchantKey,
                      string referenceNum,
                      decimal chargeTotal,
                      string processorId,
          Severity: Major
          Found in Src/MaxiPago/Gateway/Transaction.cs - About 1 hr to fix

            Method AddConsumer has 15 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                        string merchantId,
                        string merchantKey,
                        string customerIdExt,
                        string firstName,
                        string lastName,
            Severity: Major
            Found in Src/MaxiPago/Gateway/Api.cs - About 1 hr to fix

              Method Sale has 14 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                          string merchantId,
                          string merchantKey,
                          string referenceNum,
                          decimal chargeTotal,
                          string processorId,
              Severity: Major
              Found in Src/MaxiPago/Gateway/Transaction.cs - About 1 hr to fix

                Method Auth has 14 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                            string merchantId,
                            string merchantKey,
                            string referenceNum,
                            decimal chargeTotal,
                            string processorId,
                Severity: Major
                Found in Src/MaxiPago/Gateway/Transaction.cs - About 1 hr to fix

                  Method FillRequestBase has 42 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          private void FillRequestBase(
                              string operation,
                              string merchantId,
                              string merchantKey,
                              string referenceNum,
                  Severity: Minor
                  Found in Src/MaxiPago/Gateway/Transaction.cs - About 1 hr to fix

                    Method PayWithToken has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            private ResponseBase PayWithToken(
                                string operation,
                                string merchantId,
                                string merchantKey,
                                string referenceNum,
                    Severity: Minor
                    Found in Src/MaxiPago/Gateway/Transaction.cs - About 1 hr to fix

                      Method GetTransactionDetailReport has 12 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                                  string merchantId,
                                  string merchantKey,
                                  string period,
                                  string pageSize,
                                  string startDate,
                      Severity: Major
                      Found in Src/MaxiPago/Gateway/Report.cs - About 1 hr to fix

                        Method Auth has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                                public ResponseBase Auth(
                                    string merchantId,
                                    string merchantKey,
                                    string referenceNum,
                                    decimal chargeTotal,
                        Severity: Minor
                        Found in Src/MaxiPago/Gateway/Transaction.cs - About 1 hr to fix

                          Method Sale has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                                  public ResponseBase Sale(
                                      string merchantId,
                                      string merchantKey,
                                      string referenceNum,
                                      decimal chargeTotal,
                          Severity: Minor
                          Found in Src/MaxiPago/Gateway/Transaction.cs - About 1 hr to fix

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                    public ResponseBase Capture(
                                        string merchantId,
                                        string merchantKey,
                                        string orderID,
                                        string referenceNum,
                            Severity: Major
                            Found in Src/MaxiPago/Gateway/Transaction.cs and 1 other location - About 1 hr to fix
                            Src/MaxiPago/Gateway/Transaction.cs on lines 1288..1312

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 114.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                    public ResponseBase Return(
                                        string merchantId,
                                        string merchantKey,
                                        string orderID,
                                        string referenceNum,
                            Severity: Major
                            Found in Src/MaxiPago/Gateway/Transaction.cs and 1 other location - About 1 hr to fix
                            Src/MaxiPago/Gateway/Transaction.cs on lines 1247..1271

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 114.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Method Boleto has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                    public ResponseBase Boleto(
                                        string merchantId,
                                        string merchantKey,
                                        string referenceNum,
                                        decimal chargeTotal,
                            Severity: Minor
                            Found in Src/MaxiPago/Gateway/Transaction.cs - About 1 hr to fix

                              Method FillRecurringBase has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                      private void FillRecurringBase(
                                          string merchantId,
                                          string merchantKey,
                                          string referenceNum,
                                          decimal chargeTotal,
                              Severity: Minor
                              Found in Src/MaxiPago/Gateway/Transaction.cs - About 1 hr to fix

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                        public ResponseBase Sale(
                                            string merchantId,
                                            string merchantKey,
                                            string referenceNum,
                                            decimal chargeTotal,
                                Severity: Major
                                Found in Src/MaxiPago/Gateway/Transaction.cs and 1 other location - About 1 hr to fix
                                Src/MaxiPago/Gateway/Transaction.cs on lines 770..804

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 103.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                        public ResponseBase Auth(
                                            string merchantId,
                                            string merchantKey,
                                            string referenceNum,
                                            decimal chargeTotal,
                                Severity: Major
                                Found in Src/MaxiPago/Gateway/Transaction.cs and 1 other location - About 1 hr to fix
                                Src/MaxiPago/Gateway/Transaction.cs on lines 384..418

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 103.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Severity
                                Category
                                Status
                                Source
                                Language