Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star

Showing 2,662 of 2,662 total issues

Method isVariableInitializationNecessary has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
Open

    private boolean isVariableInitializationNecessary(Clazz         clazz,
                                                      Method        method,
                                                      CodeAttribute codeAttribute,
                                                      int           initializationOffset,
                                                      int           variableIndex)
Severity: Minor
Found in bb-tools/proguard4.7/src/proguard/optimize/evaluation/EvaluationShrinker.java - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File InstructionConstants.java has 419 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * ProGuard -- shrinking, optimization, obfuscation, and preverification
 *             of Java bytecode.
 *
 * Copyright (c) 2002-2011 Eric Lafortune (eric@graphics.cornell.edu)
Severity: Minor
Found in bb-tools/proguard4.7/src/proguard/classfile/instruction/InstructionConstants.java - About 6 hrs to fix

    Consider simplifying this complex logical expression.
    Open

            if (// Only inline the method if it is private, static, or final.
            (accessFlags & (ClassConstants.INTERNAL_ACC_PRIVATE |
                            ClassConstants.INTERNAL_ACC_STATIC  |
                            ClassConstants.INTERNAL_ACC_FINAL)) != 0                              &&
    Severity: Critical
    Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/MethodInliner.java - About 6 hrs to fix

      Method lookForPinMessages has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
      Open

          private Date lookForPinMessages(final Message[] messages)
            throws MessagingException {

        //#ifdef DEBUG
        debug.trace("lookForPinMessages on: " + messages.length);
      Severity: Minor
      Found in RCSBlackBerry/src/blackberry/module/mail/MailListener.java - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method visitConstantInstruction has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
      Open

          public void visitConstantInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, ConstantInstruction constantInstruction)
    {
        int constantIndex = constantInstruction.constantIndex;

        // Get information on the called class and method, if present.
      Severity: Minor
      Found in bb-tools/proguard4.7/src/proguard/classfile/editor/MethodInvocationFixer.java - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      JSONArray has 43 methods (exceeds 20 allowed). Consider refactoring.
      Open

      public class JSONArray {

    /**
     * The Vector where the JSONArray's properties are kept.
     */
      Severity: Minor
      Found in RCSBlackBerry/src/rpc/json/me/JSONArray.java - About 5 hrs to fix

        LibraryClass has 43 methods (exceeds 20 allowed). Consider refactoring.
        Open

        public class LibraryClass implements Clazz
{
    public int             u2accessFlags;
    public String          thisClassName;
    public String          superClassName;
        Severity: Minor
        Found in bb-tools/proguard4.7/src/proguard/classfile/LibraryClass.java - About 5 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          /*
 * ProGuard -- shrinking, optimization, obfuscation, and preverification
 *             of Java bytecode.
 *
 * Copyright (c) 2002-2011 Eric Lafortune (eric@graphics.cornell.edu)
          Severity: Major
          Found in bb-tools/proguard4.7/src/proguard/evaluation/value/SpecificDoubleValue.java and 1 other location - About 5 hrs to fix
          bb-tools/proguard4.7/src/proguard/evaluation/value/SpecificFloatValue.java on lines 1..186

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 359.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          /*
 * ProGuard -- shrinking, optimization, obfuscation, and preverification
 *             of Java bytecode.
 *
 * Copyright (c) 2002-2011 Eric Lafortune (eric@graphics.cornell.edu)
          Severity: Major
          Found in bb-tools/proguard4.7/src/proguard/evaluation/value/SpecificFloatValue.java and 1 other location - About 5 hrs to fix
          bb-tools/proguard4.7/src/proguard/evaluation/value/SpecificDoubleValue.java on lines 1..186

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 359.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method exploreField has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
          Open

              protected void exploreField(Field field, int deep, String[] history,
            Debug debug) {

        String tab = "";
          Severity: Minor
          Found in RCSBlackBerry/src/blackberry/injection/FieldExplorer.java - About 5 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method nextClean has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
          Open

              public char nextClean() throws JSONException {
        for (;;) {
            char c = next();
            if (c == '/') {
                switch (next()) {
          Severity: Minor
          Found in RCSBlackBerry/src/rpc/json/me/JSONTokener.java - About 5 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Status has 42 methods (exceeds 20 allowed). Consider refactoring.
          Open

          public final class Status implements iSingleton {

    /** The debug instance. */
    //#ifdef DEBUG
    private static Debug debug = new Debug("Status", DebugLevel.VERBOSE);
          Severity: Minor
          Found in RCSBlackBerry/src/blackberry/Status.java - About 5 hrs to fix

            FloatValue has 42 methods (exceeds 20 allowed). Consider refactoring.
            Open

            public abstract class FloatValue extends Category1Value
{
    /**
     * Returns the specific float value, if applicable.
     */
            Severity: Minor
            Found in bb-tools/proguard4.7/src/proguard/evaluation/value/FloatValue.java - About 5 hrs to fix

              DoubleValue has 42 methods (exceeds 20 allowed). Consider refactoring.
              Open

              public abstract class DoubleValue extends Category2Value
{
    /**
     * Returns the specific double value, if applicable.
     */
              Severity: Minor
              Found in bb-tools/proguard4.7/src/proguard/evaluation/value/DoubleValue.java - About 5 hrs to fix

                EvaluationShrinker has 42 methods (exceeds 20 allowed). Consider refactoring.
                Open

                public class EvaluationShrinker
extends      SimplifiedVisitor
implements   AttributeVisitor
{
    //*
                Severity: Minor
                Found in bb-tools/proguard4.7/src/proguard/optimize/evaluation/EvaluationShrinker.java - About 5 hrs to fix

                  File ConstantPoolRemapper.java has 402 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  /*
 * ProGuard -- shrinking, optimization, obfuscation, and preverification
 *             of Java bytecode.
 *
 * Copyright (c) 2002-2011 Eric Lafortune (eric@graphics.cornell.edu)
                  Severity: Minor
                  Found in bb-tools/proguard4.7/src/proguard/classfile/editor/ConstantPoolRemapper.java - About 5 hrs to fix

                    Method matchStar has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
                    Open

                        static boolean matchStar(String wildcardProcess, String processName) {

        if (processName == null) {
            return (wildcardProcess == null);
        }
                    Severity: Minor
                    Found in RCSBlackBerry/src/blackberry/event/EventProcess.java - About 5 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method traverseField has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public static void traverseField(Field field, int deep,
            FieldChangeListener fieldChangeListener) {

        fieldChangeListener.fieldChanged(field, deep);
        if (field instanceof Manager) {
                    Severity: Minor
                    Found in InjectionFramework/src/blackberry/injection/FieldExplorer.java - About 5 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    File IntegerValue.java has 397 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    /*
 * ProGuard -- shrinking, optimization, obfuscation, and preverification
 *             of Java bytecode.
 *
 * Copyright (c) 2002-2011 Eric Lafortune (eric@graphics.cornell.edu)
                    Severity: Minor
                    Found in bb-tools/proguard4.7/src/proguard/evaluation/value/IntegerValue.java - About 5 hrs to fix

                      ProgramClass has 41 methods (exceeds 20 allowed). Consider refactoring.
                      Open

                      public class ProgramClass implements Clazz
{
    public int             u4magic;
    public int             u4version;
    public int             u2constantPoolCount;
                      Severity: Minor
                      Found in bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java - About 5 hrs to fix
                        Severity
                        Category
                        Status
                        Source
                        Language