Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star

Showing 2,662 of 2,662 total issues

Method parseClassSpecificationArguments has 123 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private ClassSpecification parseClassSpecificationArguments()
    throws ParseException, IOException
    {
        // Clear the annotation type.
        String annotationType = null;
Severity: Major
Found in bb-tools/proguard4.7/src/proguard/ConfigurationParser.java - About 4 hrs to fix

    Method exploreField has 123 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected static void exploreField(Field field, int deep, String[] history,
            Debug debug, String deleteName) {

        String tab = "";
    Severity: Major
    Found in InjectionFramework/src/blackberry/injection/FieldExplorer.java - About 4 hrs to fix

      Clazz has 37 methods (exceeds 20 allowed). Consider refactoring.
      Open

      public interface Clazz extends VisitorAccepter
{
    /**
     * Returns the access flags of this class.
     * @see ClassConstants
      Severity: Minor
      Found in bb-tools/proguard4.7/src/proguard/classfile/Clazz.java - About 4 hrs to fix

        Method internalClassVersion has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
        Open

            public static int internalClassVersion(String classVersion)
    {
        return
            classVersion.equals(ClassConstants.EXTERNAL_CLASS_VERSION_1_0) ||
            classVersion.equals(ClassConstants.EXTERNAL_CLASS_VERSION_1_1) ? ClassConstants.INTERNAL_CLASS_VERSION_1_0 :
        Severity: Minor
        Found in bb-tools/proguard4.7/src/proguard/classfile/util/ClassUtil.java - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File BranchTargetFinder.java has 362 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        /*
 * ProGuard -- shrinking, optimization, obfuscation, and preverification
 *             of Java bytecode.
 *
 * Copyright (c) 2002-2011 Eric Lafortune (eric@graphics.cornell.edu)
        Severity: Minor
        Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/BranchTargetFinder.java - About 4 hrs to fix

          Consider simplifying this complex logical expression.
          Open

                  if (opcode == InstructionConstants.OP_IASTORE      ||
            opcode == InstructionConstants.OP_LASTORE      ||
            opcode == InstructionConstants.OP_FASTORE      ||
            opcode == InstructionConstants.OP_DASTORE      ||
            opcode == InstructionConstants.OP_AASTORE      ||
          Severity: Critical
          Found in bb-tools/proguard4.7/src/proguard/optimize/info/SideEffectInstructionChecker.java - About 4 hrs to fix

            File MailListener.java has 358 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            //#preprocess

/* *************************************************
 * Copyright (c) 2010 - 2011
 * HT srl,   All rights reserved.
            Severity: Minor
            Found in RCSBlackBerry/src/blackberry/module/mail/MailListener.java - About 4 hrs to fix

              File Protocol.java has 355 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              //#preprocess

/* *************************************************
 * Copyright (c) 2010 - 2011
 * HT srl,   All rights reserved.
              Severity: Minor
              Found in RCSBlackBerry/src/blackberry/action/sync/Protocol.java - About 4 hrs to fix

                ConfigurationTask has 35 methods (exceeds 20 allowed). Consider refactoring.
                Open

                public class ConfigurationTask extends Task
{
    protected final Configuration configuration = new Configuration();
                Severity: Minor
                Found in bb-tools/proguard4.7/src/proguard/ant/ConfigurationTask.java - About 4 hrs to fix

                  BranchTargetFinder has 35 methods (exceeds 20 allowed). Consider refactoring.
                  Open

                  public class BranchTargetFinder
extends      SimplifiedVisitor
implements   AttributeVisitor,
             InstructionVisitor,
             ExceptionInfoVisitor,
                  Severity: Minor
                  Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/BranchTargetFinder.java - About 4 hrs to fix

                    Method parse has 112 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        private static boolean parse(XMLTokener x, JSONObject context, String name)
            throws JSONException {
        char c;
        int i;
        String n;
                    Severity: Major
                    Found in RCSBlackBerry/src/rpc/json/me/util/XML.java - About 4 hrs to fix

                      File MethodInliner.java has 353 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      /*
 * ProGuard -- shrinking, optimization, obfuscation, and preverification
 *             of Java bytecode.
 *
 * Copyright (c) 2002-2011 Eric Lafortune (eric@graphics.cornell.edu)
                      Severity: Minor
                      Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/MethodInliner.java - About 4 hrs to fix

                        Method visitCodeAttribute0 has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public void visitCodeAttribute0(Clazz clazz, Method method, CodeAttribute codeAttribute)
    {
//        DEBUG =
//            clazz.getName().equals("abc/Def") &&
//            method.getName(clazz).equals("abc");
                        Severity: Minor
                        Found in bb-tools/proguard4.7/src/proguard/preverify/CodePreverifier.java - About 4 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method perform has 110 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public boolean perform() {
        //#ifdef DBC
        Check.requires(transport != null, "perform: transport = null"); //$NON-NLS-1$
        //#endif
                        Severity: Major
                        Found in RCSBlackBerry/src/blackberry/action/sync/protocol/ZProtocol.java - About 4 hrs to fix

                          File ClassSpecificationDialog.java has 349 lines of code (exceeds 250 allowed). Consider refactoring.
                          Open

                          /*
 * ProGuard -- shrinking, optimization, obfuscation, and preverification
 *             of Java bytecode.
 *
 * Copyright (c) 2002-2011 Eric Lafortune (eric@graphics.cornell.edu)
                          Severity: Minor
                          Found in bb-tools/proguard4.7/src/proguard/gui/ClassSpecificationDialog.java - About 4 hrs to fix

                            UnknownIntegerValue has 34 methods (exceeds 20 allowed). Consider refactoring.
                            Open

                            public class UnknownIntegerValue extends IntegerValue
{
    // Basic unary methods.

    public IntegerValue negate()
                            Severity: Minor
                            Found in bb-tools/proguard4.7/src/proguard/evaluation/value/UnknownIntegerValue.java - About 4 hrs to fix

                              ChangedCodePrinter has 34 methods (exceeds 20 allowed). Consider refactoring.
                              Open

                              public class ChangedCodePrinter
implements   AttributeVisitor
{
    private final AttributeVisitor attributeVisitor;
                              Severity: Minor
                              Found in bb-tools/proguard4.7/src/proguard/optimize/ChangedCodePrinter.java - About 4 hrs to fix

                                PartialEvaluator has 34 methods (exceeds 20 allowed). Consider refactoring.
                                Open

                                public class PartialEvaluator
extends      SimplifiedVisitor
implements   AttributeVisitor,
             ExceptionInfoVisitor
{
                                Severity: Minor
                                Found in bb-tools/proguard4.7/src/proguard/optimize/evaluation/PartialEvaluator.java - About 4 hrs to fix

                                  MultiAttributeVisitor has 34 methods (exceeds 20 allowed). Consider refactoring.
                                  Open

                                  public class MultiAttributeVisitor implements AttributeVisitor
{
    private AttributeVisitor[] attributeVisitors;
                                  Severity: Minor
                                  Found in bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java - About 4 hrs to fix

                                    Method nextWord has 107 lines of code (exceeds 25 allowed). Consider refactoring.
                                    Open

                                        public String nextWord(boolean isFileName) throws IOException
    {
        currentWord = null;

        // See if we have an included reader to produce a word.
                                    Severity: Major
                                    Found in bb-tools/proguard4.7/src/proguard/WordReader.java - About 4 hrs to fix
                                      Severity
                                      Category
                                      Status
                                      Source
                                      Language