hackedteam/rcs-console

View on GitHub

Showing 6 of 6 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

(function(window)
{
    window.StageWebViewBridge = (function()
    {         
    /* PROPIERTIES */
Severity: Major
Found in src/es/xperiments/media/StageWebViewBridge.js and 1 other location - About 1 wk to fix
src/maps/StageWebViewBridge.js on lines 1..258

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 1657.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

(function(window)
{
        window.StageWebViewBridge = (function()
        {         
        /* PROPIERTIES */
Severity: Major
Found in src/maps/StageWebViewBridge.js and 1 other location - About 1 wk to fix
src/es/xperiments/media/StageWebViewBridge.js on lines 1..258

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 1657.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function StageWebViewBridge has 172 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        window.StageWebViewBridge = (function()
        {         
        /* PROPIERTIES */
                
                /* Stores callBack functions */
Severity: Major
Found in src/maps/StageWebViewBridge.js - About 6 hrs to fix

    Function StageWebViewBridge has 172 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        window.StageWebViewBridge = (function()
        {         
        /* PROPIERTIES */
            
            /* Stores callBack functions */
    Severity: Major
    Found in src/es/xperiments/media/StageWebViewBridge.js - About 6 hrs to fix

      Function deferredDoCall has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              var deferredDoCall = function( jsonArgs )
              {
                  var _serializeObject = JSON.parse( atob( jsonArgs ) );
                  var method = _serializeObject.method;
                  var returnValue = true;
      Severity: Minor
      Found in src/es/xperiments/media/StageWebViewBridge.js - About 1 hr to fix

        Function deferredDoCall has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                        var deferredDoCall = function( jsonArgs )
                        {
                                var _serializeObject = JSON.parse( atob( jsonArgs ) );
                                var method = _serializeObject.method;
                                var returnValue = true;
        Severity: Minor
        Found in src/maps/StageWebViewBridge.js - About 1 hr to fix
          Severity
          Category
          Status
          Source
          Language