Sign upLogin

hackiftekhar/IQKeyboardManager

View on GitHub
Star
Demo/Swift_Demo/ViewController/SearchViewController.swift

Summary

Maintainability
C
1 day
Test Coverage

Function searchForText has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    func searchForText(_ searchText: String?, scope: Int) {

        guard let text = searchText, !text.isEmpty else {
            self.filteredList = self.dataList
            return
Severity: Minor
Found in Demo/Swift_Demo/ViewController/SearchViewController.swift - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function searchForText has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    func searchForText(_ searchText: String?, scope: Int) {

        guard let text = searchText, !text.isEmpty else {
            self.filteredList = self.dataList
            return
Severity: Minor
Found in Demo/Swift_Demo/ViewController/SearchViewController.swift - About 1 hr to fix

    Avoid too many return statements within this function.
    Open

                        return false
    Severity: Major
    Found in Demo/Swift_Demo/ViewController/SearchViewController.swift - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                          return true
      Severity: Major
      Found in Demo/Swift_Demo/ViewController/SearchViewController.swift - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                            return false
        Severity: Major
        Found in Demo/Swift_Demo/ViewController/SearchViewController.swift - About 30 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if scope == 0 {
            self.filteredList = self.dataList.filter({ (obj: [String: String]) -> Bool in

                if obj["name"]?.contains(text) == true || obj["email"]?.contains(text) == true {
                    return true
          Severity: Major
          Found in Demo/Swift_Demo/ViewController/SearchViewController.swift and 1 other location - About 1 hr to fix
          Demo/Swift_Demo/ViewController/SearchViewController.swift on lines 75..93

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 104.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  } else if scope == 1 {
            self.filteredList = self.dataList.filter({ (obj: [String: String]) -> Bool in

                if obj["name"]?.contains(text) == true || obj["email"]?.contains(text) == true {
                    return true
          Severity: Major
          Found in Demo/Swift_Demo/ViewController/SearchViewController.swift and 1 other location - About 1 hr to fix
          Demo/Swift_Demo/ViewController/SearchViewController.swift on lines 66..93

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 104.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  } else {
            cell?.textLabel?.text         = filteredList[indexPath.row]["name"]
            cell?.detailTextLabel?.text   = filteredList[indexPath.row]["email"]
        }
          Severity: Minor
          Found in Demo/Swift_Demo/ViewController/SearchViewController.swift and 1 other location - About 45 mins to fix
          Demo/Swift_Demo/ViewController/SearchViewController.swift on lines 123..126

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if searchController.isActive == false {
            cell?.textLabel?.text         = dataList[indexPath.row]["name"]
            cell?.detailTextLabel?.text   = dataList[indexPath.row]["email"]
        } else {
          Severity: Minor
          Found in Demo/Swift_Demo/ViewController/SearchViewController.swift and 1 other location - About 45 mins to fix
          Demo/Swift_Demo/ViewController/SearchViewController.swift on lines 126..129

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status