Sign upLogin

hackiftekhar/IQKeyboardManager

View on GitHub
Star
IQKeyboardManagerSwift/IQKeyboardManager/IQKeyboardManager+Toolbar.swift

Summary

Maintainability
D
1 day
Test Coverage

Function addToolbarIfRequired has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
Open

    internal func addToolbarIfRequired() {

        // Either there is no inputAccessoryView or
        // if accessoryView is not appropriate for current situation
        // (There is Previous/Next/Done toolbar)
Severity: Minor
Found in IQKeyboardManagerSwift/IQKeyboardManager/IQKeyboardManager+Toolbar.swift - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function addToolbarIfRequired has 123 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    internal func addToolbarIfRequired() {

        // Either there is no inputAccessoryView or
        // if accessoryView is not appropriate for current situation
        // (There is Previous/Next/Done toolbar)
Severity: Major
Found in IQKeyboardManagerSwift/IQKeyboardManager/IQKeyboardManager+Toolbar.swift - About 4 hrs to fix

    Function removeToolbarIfRequired has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        internal func removeToolbarIfRequired() {    //  (Bug ID: #18)

        guard let siblings: [UIView] = responderViews(), !siblings.isEmpty,
              let textField: UIView = activeConfiguration.textFieldViewInfo?.textFieldView,
                textField.responds(to: #selector(setter: UITextField.inputAccessoryView)),
    Severity: Minor
    Found in IQKeyboardManagerSwift/IQKeyboardManager/IQKeyboardManager+Toolbar.swift - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function removeToolbarIfRequired has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        internal func removeToolbarIfRequired() {    //  (Bug ID: #18)

        guard let siblings: [UIView] = responderViews(), !siblings.isEmpty,
              let textField: UIView = activeConfiguration.textFieldViewInfo?.textFieldView,
                textField.responds(to: #selector(setter: UITextField.inputAccessoryView)),
    Severity: Minor
    Found in IQKeyboardManagerSwift/IQKeyboardManager/IQKeyboardManager+Toolbar.swift - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  if let configuration: IQBarButtonItemConfiguration = toolbarConfiguration.previousBarButtonConfiguration {
                configuration.action = #selector(self.previousAction(_:))
                prevConfiguration = configuration
            } else {
                prevConfiguration = IQBarButtonItemConfiguration(image: (UIImage.keyboardPreviousImage),
      Severity: Minor
      Found in IQKeyboardManagerSwift/IQKeyboardManager/IQKeyboardManager+Toolbar.swift and 1 other location - About 50 mins to fix
      IQKeyboardManagerSwift/IQKeyboardManager/IQKeyboardManager+Toolbar.swift on lines 128..135

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 60.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  if let configuration: IQBarButtonItemConfiguration = toolbarConfiguration.nextBarButtonConfiguration {
                configuration.action = #selector(self.nextAction(_:))
                nextConfiguration = configuration
            } else {
                nextConfiguration = IQBarButtonItemConfiguration(image: (UIImage.keyboardNextImage),
      Severity: Minor
      Found in IQKeyboardManagerSwift/IQKeyboardManager/IQKeyboardManager+Toolbar.swift and 1 other location - About 50 mins to fix
      IQKeyboardManagerSwift/IQKeyboardManager/IQKeyboardManager+Toolbar.swift on lines 118..125

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 60.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status