Sign upLogin

hammackj/risu

View on GitHub
Star

Showing 178 of 178 total issues

Method run has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

            def run
                parse_options

                if @options[:list_templates]
                    @template_manager.display_templates
Severity: Minor
Found in lib/risu/cli/application.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

                    def initialize
                        @info =
                        {
                            :description => "Adobe Acrobat Patch Rollup",
                            :plugin_id => -99975,
Severity: Major
Found in lib/risu/parsers/nessus/postprocess/adobe_acrobat.rb - About 2 hrs to fix

    Method render has 53 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                def render output
                @output.text Report.classification.upcase, :align => :center
                @output.text "\n"

                report_title Report.title
    Severity: Major
    Found in lib/risu/templates/authentication_summary.rb - About 2 hrs to fix

      Method render has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

                  def render output
                @output.font_size 10

                report_classification
      Severity: Minor
      Found in lib/risu/templates/findings_host.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method render has 52 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                  def render output
                output.text Report.classification.upcase, :align => :center
                output.text "\n"

                report_title Report.title
      Severity: Major
      Found in lib/risu/templates/exec_summary.rb - About 2 hrs to fix

        Method render has 51 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                    def render output
                @output.font_size 10

                report_classification
        Severity: Major
        Found in lib/risu/templates/findings_host.rb - About 2 hrs to fix

          Consider simplifying this complex logical expression.
          Open

                  if nt == 0 && w2k == 0 && xp == 0 && w2k3 == 0 && vista == 0 && w2k8 == 0 && w2k12 == 0 && w7 == 0 && w8 == 0 && other == 0
          return false
        else
          return true
        end
          Severity: Critical
          Found in lib/risu/graphs/windows_os_graph.rb - About 2 hrs to fix

            Consider simplifying this complex logical expression.
            Open

                                if nt == 0 && w2k == 0 && xp == 0 && w2k3 == 0 && vista == 0 && w2k8 == 0 && w2k12 == 0 && w7 == 0 && w8 == 0 && other == 0
                        return false
                    else
                        return true
                    end
            Severity: Critical
            Found in lib/risu/models/host.rb - About 2 hrs to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  module Parsers
        module Nessus
            module PostProcess
                class AdobeAir < Risu::Base::PostProcessBase
              Severity: Major
              Found in lib/risu/parsers/nessus/postprocess/adobe_air.rb and 1 other location - About 2 hrs to fix
              lib/risu/parsers/nessus/postprocess/openssl.rb on lines 23..93

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 77.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  module Parsers
        module Nessus
            module PostProcess
                class OpenSSLRollups < Risu::Base::PostProcessBase
              Severity: Major
              Found in lib/risu/parsers/nessus/postprocess/openssl.rb and 1 other location - About 2 hrs to fix
              lib/risu/parsers/nessus/postprocess/adobe_air.rb on lines 23..93

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 77.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Method render has 48 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                          def render output
                text Report.classification.upcase, :align => :center
                text "\n"

                report_title Report.title
              Severity: Minor
              Found in lib/risu/templates/pci_compliance.rb - About 1 hr to fix

                Method render has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                Open

                            def render output
                output.text Report.classification.upcase, :align => :center
                output.text "\n"

                output.font_size(22) do
                Severity: Minor
                Found in lib/risu/templates/missing_root_causes.rb - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method render has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                Open

                            def render output
                text Report.classification.upcase, :align => :center
                text "\n"

                report_title Report.title
                Severity: Minor
                Found in lib/risu/templates/assets.rb - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method exploitablity_matrix has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                Open

                                def exploitablity_matrix findings
                    results = Array.new

                    findings.each do |item|
                        plugin = Plugin.where(:id => item.plugin_id).first
                Severity: Minor
                Found in lib/risu/models/item.rb - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method initialize has 47 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                                    def initialize
                        @info =
                        {
                            :description => "Oracle Database Patch Rollup",
                            :plugin_id => -99993,
                Severity: Minor
                Found in lib/risu/parsers/nessus/postprocess/oracle_database.rb - About 1 hr to fix

                  Method end_report_item has 46 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                                  def end_report_item(_)
                    @ri.update(:plugin_output => @vals["plugin_output"],
                        :plugin_name => @vals["plugin_name"],
                        :cm_compliance_info => @vals["cm:compliance-info"],
                        :cm_compliance_actual_value => @vals["cm:compliance-actual-value"],
                  Severity: Minor
                  Found in lib/risu/parsers/nessus/nessus_sax_listener.rb - About 1 hr to fix

                    Method initialize has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                                        def initialize
                        @info =
                        {
                            :description => "Apache Patch Rollup",
                            :plugin_id => -99986,
                    Severity: Minor
                    Found in lib/risu/parsers/nessus/postprocess/apache.rb - About 1 hr to fix

                      Method initialize has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                                          def initialize
                        @info =
                        {
                            :description => "Apple QuickTime Patch Rollup",
                            :plugin_id => -99973,
                      Severity: Minor
                      Found in lib/risu/parsers/nessus/postprocess/apple_quicktime.rb - About 1 hr to fix

                        Method generate has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                        Open

                                    def generate
                begin
                    template = @template
                    template_manager = @template_manager
                        Severity: Minor
                        Found in lib/risu/base/templater.rb - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method render has 43 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                                    def render output
                text Report.classification.upcase, :align => :center
                text "\n"

                report_title Report.title
                        Severity: Minor
                        Found in lib/risu/templates/top_25.rb - About 1 hr to fix
                          Severity
                          Category
                          Status
                          Source
                          Language