Sign upLogin

haslo/lists_juggle_browser

View on GitHub
Star

Showing 48 of 48 total issues

Method generate_ships has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def generate_ships(context, ships, ship_pilots, ids = [])
          ::CSV.generate do |csv|
            csv << [
              context.t('ships.csv.position'),
              context.t('ships.csv.ship_name'),
Severity: Minor
Found in app/models/generators/csv/ships_generator.rb - About 1 hr to fix

    Method generate_upgrades has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def generate_upgrades(context, upgrades, ids = [])
              ::CSV.generate do |csv|
                csv << [
                  context.t('upgrades.csv.position'),
                  context.t('upgrades.csv.upgrade_name'),
    Severity: Minor
    Found in app/models/generators/csv/upgrades_generator.rb - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          respond_to do |format|
            format.html do
              # standard render pipeline
            end
            format.csv do
      Severity: Minor
      Found in app/controllers/ship_combos_controller.rb and 1 other location - About 55 mins to fix
      app/controllers/ships_controller.rb on lines 35..44

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          respond_to do |format|
            format.html do
              # standard render pipeline
            end
            format.csv do
      Severity: Minor
      Found in app/controllers/ships_controller.rb and 1 other location - About 55 mins to fix
      app/controllers/ship_combos_controller.rb on lines 34..43

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          respond_to do |format|
            format.html do
              # standard render pipeline
            end
            format.csv do
      Severity: Minor
      Found in app/controllers/pilots_controller.rb and 1 other location - About 50 mins to fix
      app/controllers/upgrades_controller.rb on lines 33..42

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          respond_to do |format|
            format.html do
              # standard render pipeline
            end
            format.csv do
      Severity: Minor
      Found in app/controllers/upgrades_controller.rb and 1 other location - About 50 mins to fix
      app/controllers/pilots_controller.rb on lines 33..42

      Method update has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def update
          ActiveRecord::Base.transaction do
            suggestion = ArchetypeNameSuggestion.find(params[:id])
            ship_combo = suggestion.ship_combo
            case params[:mod_action]
      Severity: Minor
      Found in app/controllers/archetype_name_suggestions_controller.rb - About 45 mins to fix

      Method build_squadron has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def build_squadron(squadron_xws)
              squadron_xws = JSON.parse(squadron_xws) if squadron_xws.is_a?(String)
              faction_xws  = squadron_xws.try(:[], 'faction')
              faction      = Faction.find_by(xws: faction_xws, is_subfaction: false)
              squadron     = Squadron.new({
      Severity: Minor
      Found in app/models/importers/squadron_from_xws.rb - About 45 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        def index
          @view = Rankers::PilotsRanker.new(ranking_configuration)
       
          respond_to do |format|
            format.html do
      Severity: Minor
      Found in app/controllers/pilots_controller.rb and 1 other location - About 45 mins to fix
      app/controllers/upgrades_controller.rb on lines 3..15

      Method sync_tournament has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def sync_tournament(tournament)
            uri      = URI.parse("http://lists.starwarsclubhouse.com/api/v2/tournament/#{tournament.lists_juggler_id}")
            response = Net::HTTP.get_response(uri)
            begin
              tournament_data  = JSON.parse(response.body).try(:[], 'tournament')
      Severity: Minor
      Found in app/models/importers/lists_juggler.rb - About 45 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        def index
          @view = Rankers::UpgradesRanker.new(ranking_configuration)
       
          respond_to do |format|
            format.html do
      Severity: Minor
      Found in app/controllers/upgrades_controller.rb and 1 other location - About 45 mins to fix
      app/controllers/pilots_controller.rb on lines 3..15

      Method sync_games has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def sync_games(tournament, rounds_data, squadron_container)
            rounds_data.each do |round_data|
              round_number = round_data['round-number']
              round_type   = round_data['round-type']
              round_data['matches'].each do |game_data|
      Severity: Minor
      Found in app/models/importers/lists_juggler.rb - About 45 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          respond_to do |format|
            format.html do
              # standard render pipeline
            end
            format.csv do
      Severity: Minor
      Found in app/controllers/ship_combos_controller.rb and 1 other location - About 40 mins to fix
      app/controllers/ships_controller.rb on lines 6..15

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          respond_to do |format|
            format.html do
              # standard render pipeline
            end
            format.csv do
      Severity: Minor
      Found in app/controllers/ships_controller.rb and 1 other location - About 40 mins to fix
      app/controllers/ship_combos_controller.rb on lines 6..15

      Method rebuild_all_ranking_data has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def rebuild_all_ranking_data(minimum_id: nil, start_date: nil)
            Tournament.includes(:squadrons).all.each do |tournament|
              if minimum_id.nil? || tournament.lists_juggler_id >= minimum_id
                if start_date.nil? || tournament.date.nil? || tournament.date >= DateTime.parse(start_date.to_s).beginning_of_day
                  build_ranking_data(tournament.lists_juggler_id)
      Severity: Minor
      Found in app/models/importers/ranking.rb - About 35 mins to fix

      Method initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def initialize(ranking_configuration, ship_id: nil, ship_combo_id: nil, pilot_id: nil, upgrade_id: nil, limit: nil)
            start_date      = ranking_configuration[:ranking_start]
            end_date        = ranking_configuration[:ranking_end]
            tournament_type = ranking_configuration[:tournament_type]
            joins           = <<-SQL
      Severity: Minor
      Found in app/models/rankers/ship_combos_ranker.rb - About 25 mins to fix

      Method initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def initialize(ranking_configuration, ship_id: nil, pilot_id: nil, limit: nil, upgrade_id: nil, ship_combo_id: nil)
            start_date      = ranking_configuration[:ranking_start]
            end_date        = ranking_configuration[:ranking_end]
            tournament_type = ranking_configuration[:tournament_type]
            joins           = <<-SQL
      Severity: Minor
      Found in app/models/rankers/upgrades_ranker.rb - About 25 mins to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  csv << [
                    context.t('ships.csv.position'),
                    context.t('ships.csv.ship_name'),
                    context.t('ships.csv.link'),
                    context.t('ships.csv.pilot_names'),
      Severity: Minor
      Found in app/models/generators/csv/ships_generator.rb and 2 other locations - About 20 mins to fix
      app/models/generators/csv/pilots_generator.rb on lines 10..19
      app/models/generators/csv/upgrades_generator.rb on lines 10..19

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  csv << [
                    context.t('pilots.csv.position'),
                    context.t('pilots.csv.pilot_name'),
                    context.t('pilots.csv.link'),
                    context.t('pilots.csv.ship_name'),
      Severity: Minor
      Found in app/models/generators/csv/pilots_generator.rb and 2 other locations - About 20 mins to fix
      app/models/generators/csv/ships_generator.rb on lines 10..19
      app/models/generators/csv/upgrades_generator.rb on lines 10..19

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              def generate_ship_combos(context, ship_combos, ships, ids = [])
                ship_combos.map.with_index do |ship_combo, index|
                  if ids.empty? || ids.map(&:to_i).include?(ship_combo.id)
                    generate_ship_combo(context, ship_combo, ships, index + 1)
                  end
      Severity: Minor
      Found in app/models/generators/json/ship_combos_generator.rb and 1 other location - About 20 mins to fix
      app/models/generators/json/ships_generator.rb on lines 6..10
      Severity
      Category
      Status
      Source
      Language