Sign upLogin

haslo/lists_juggle_browser

View on GitHub
Star

Showing 48 of 48 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                csv << [
                  index + 1,
                  pilot.name,
                  context.pilot_url(pilot.id),
                  ship.name,
Severity: Minor
Found in app/models/generators/csv/pilots_generator.rb and 1 other location - About 20 mins to fix
app/models/generators/csv/upgrades_generator.rb on lines 22..31

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                csv << [
                  index + 1,
                  upgrade.name,
                  context.upgrade_url(upgrade.id),
                  upgrade.upgrade_type,
Severity: Minor
Found in app/models/generators/csv/upgrades_generator.rb and 1 other location - About 20 mins to fix
app/models/generators/csv/pilots_generator.rb on lines 23..32

Similar blocks of code found in 3 locations. Consider refactoring.
Open

            csv << [
              context.t('upgrades.csv.position'),
              context.t('upgrades.csv.upgrade_name'),
              context.t('upgrades.csv.link'),
              context.t('upgrades.csv.upgrade_type'),
Severity: Minor
Found in app/models/generators/csv/upgrades_generator.rb and 2 other locations - About 20 mins to fix
app/models/generators/csv/pilots_generator.rb on lines 10..19
app/models/generators/csv/ships_generator.rb on lines 10..19

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        def generate_ships(context, ships, ship_pilots, ids = [])
          ships.map.with_index do |ship, index|
            if ids.empty? || ids.map(&:to_i).include?(ship.id)
              generate_ship(context, ship, ship_pilots, index + 1)
            end
Severity: Minor
Found in app/models/generators/json/ships_generator.rb and 1 other location - About 20 mins to fix
app/models/generators/json/ship_combos_generator.rb on lines 6..10

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        def generate_pilots(context, pilots, ids = [])
          pilots.map.with_index do |pilot, index|
            if ids.empty? || ids.map(&:to_i).include?(pilot.id)
              generate_pilot(context, pilot, index + 1)
            end
Severity: Minor
Found in app/models/generators/json/pilots_generator.rb and 1 other location - About 15 mins to fix
app/models/generators/json/upgrades_generator.rb on lines 6..10

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        def generate_upgrades(context, upgrades, ids = [])
          upgrades.map.with_index do |upgrade, index|
            if ids.empty? || ids.map(&:to_i).include?(upgrade.id)
              generate_upgrade(context, upgrade, index + 1)
            end
Severity: Minor
Found in app/models/generators/json/upgrades_generator.rb and 1 other location - About 15 mins to fix
app/models/generators/json/pilots_generator.rb on lines 6..10

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  def show
    about       = File.read(Rails.root + 'ABOUT.md')
    markdown    = Redcarpet::Markdown.new(Redcarpet::Render::HTML, autolink: true, tables: true)
    @html_about = markdown.render(about)
Severity: Minor
Found in app/controllers/abouts_controller.rb and 1 other location - About 15 mins to fix
app/controllers/news_controller.rb on lines 3..6

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  def index
    changelog       = File.read(Rails.root + 'CHANGELOG.md')
    markdown        = Redcarpet::Markdown.new(Redcarpet::Render::HTML, autolink: true, tables: true)
    @html_changelog = markdown.render(changelog)
Severity: Minor
Found in app/controllers/news_controller.rb and 1 other location - About 15 mins to fix
app/controllers/abouts_controller.rb on lines 3..6
Severity
Category
Status
Source
Language