Sign upLogin

hdachev/fakeredis

View on GitHub
Star
lib/connection.js

Summary

Maintainability
F
1 wk
Test Coverage

Function Connection has a Cognitive Complexity of 288 (exceeds 5 allowed). Consider refactoring.
Open

exports.Connection = function(backend, minLatency, maxLatency) {
  var connection = this
    , db = 0

    , queue, watch, block
Severity: Minor
Found in lib/connection.js - About 5 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function Connection has 291 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.Connection = function(backend, minLatency, maxLatency) {
  var connection = this
    , db = 0

    , queue, watch, block
Severity: Major
Found in lib/connection.js - About 1 day to fix

    Function NORMAL has 137 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function NORMAL(client, entry) {
    var i, n, matches;


    // Transactions.
    Severity: Major
    Found in lib/connection.js - About 5 hrs to fix

      File connection.js has 312 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      "use strict";


exports.Connection = function(backend, minLatency, maxLatency) {
  var connection = this
      Severity: Minor
      Found in lib/connection.js - About 3 hrs to fix

        Function exec has 54 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          function exec() {
    timeout = 0;
    var q = queue, entry, func, out, err, data, resp = [];
    queue = null;
        Severity: Major
        Found in lib/connection.js - About 2 hrs to fix

          Function override has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                entry.override = function(queue) {
        if (!queue) throw new Error('WOOT! no queue.');
        var w = watch, key, entry;
        watch = null;
        if (w) for (key in w)
          Severity: Minor
          Found in lib/connection.js - About 1 hr to fix

            Consider simplifying this complex logical expression.
            Open

                  else if (func.length && func.length !== entry.args.length) {
        err = new Error('Wrong number of arguments for \'' + entry.command.toLowerCase() + '\' command');
        data = null;
      }
            Severity: Critical
            Found in lib/connection.js - About 1 hr to fix

              Avoid deeply nested control flow statements.
              Open

                      if (w) for (key in w)
          if (backend.getRevision(key) !== w[key]) {

            // Abort because of a change in the watched keyspace.
            n = 0;
              Severity: Major
              Found in lib/connection.js - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                      if (queue && !timeout)
        timeout = setTimeout(exec, randLat());
                Severity: Major
                Found in lib/connection.js - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                            if (entry.command !== "EXEC") {

            // Collect replies for the EXEC output.
            entry.callback = cb;
                  Severity: Major
                  Found in lib/connection.js - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                              if (resp.length)
            flush(resp);
                    Severity: Major
                    Found in lib/connection.js - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                if (entry.block && typeof entry.block === 'number')
            setTimeout(unblock.bind(null, entry), entry.block * 1000);
                      Severity: Major
                      Found in lib/connection.js - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                  if (queue[i].command === "MULTI") {
            queue.splice(i, queue.length);

            // This will substitute the DISCARD command with an UNWATCH,
            // hence the recursive call to this.push.
                        Severity: Major
                        Found in lib/connection.js - About 45 mins to fix

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                if (typeof data === 'number')
        data = String(data);

      else if (data.length && data.map)
        data = data.map(finnerdata);
                          Severity: Major
                          Found in lib/connection.js and 1 other location - About 1 hr to fix
                          lib/connection.js on lines 380..387

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 64.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                if (typeof data === 'string' && !isNaN(data))
        data = Number(data);

      else if (data.length && data.map)
        data = data.map(finnerdata);
                          Severity: Major
                          Found in lib/connection.js and 1 other location - About 1 hr to fix
                          lib/connection.js on lines 398..405

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 64.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status