Sign upLogin

heap-data-structure/binomial-heap

View on GitHub
Star

Showing 10 of 10 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    const merge = function (compare, list, other) {
        if (other.length === 0) {
            return;
        }
Severity: Major
Found in src/BinomialHeap.js and 1 other location - About 2 days to fix
src/LazyBinomialHeap.js on lines 21..111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 412.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    const merge = function (compare, list, other) {
        if (other.length === 0) {
            return;
        }
Severity: Major
Found in src/LazyBinomialHeap.js and 1 other location - About 2 days to fix
src/BinomialHeap.js on lines 36..126

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 412.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function BinomialHeap has a Cognitive Complexity of 82 (exceeds 5 allowed). Consider refactoring.
Open

export default function BinomialHeap(BinomialTree) {
    const binomial_heap_push = function (compare, list, tree, rank) {
        // Ensures list has at least rank cells

        let i = rank - list.length;
Severity: Minor
Found in src/BinomialHeap.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function BinomialHeap has 210 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function BinomialHeap(BinomialTree) {
    const binomial_heap_push = function (compare, list, tree, rank) {
        // Ensures list has at least rank cells

        let i = rank - list.length;
Severity: Major
Found in src/BinomialHeap.js - About 1 day to fix

    Function LazyBinomialHeap has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
    Open

    export default function LazyBinomialHeap(BinomialTree) {
    const lazy_binomial_heap_push = function (lazy, tree, rank) {
        // Lightweight binomial heap containing a unique tree
        const sequence = [];
    Severity: Minor
    Found in src/LazyBinomialHeap.js - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function LazyBinomialHeap has 95 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export default function LazyBinomialHeap(BinomialTree) {
    const lazy_binomial_heap_push = function (lazy, tree, rank) {
        // Lightweight binomial heap containing a unique tree
        const sequence = [];
    Severity: Major
    Found in src/LazyBinomialHeap.js - About 3 hrs to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              for (++j; j < len; ++j) {
            const item = list[j];

            if (item !== null) {
                const candidate = item.value;
      Severity: Major
      Found in src/LazyBinomialHeap.js and 1 other location - About 2 hrs to fix
      src/BinomialHeap.js on lines 144..155

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 85.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              for (++j; j < len; ++j) {
            const item = list[j];

            if (item !== null) {
                const candidate = item.value;
      Severity: Major
      Found in src/BinomialHeap.js and 1 other location - About 2 hrs to fix
      src/LazyBinomialHeap.js on lines 138..149

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 85.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function merge has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          const merge = function (compare, list, other) {
        if (other.length === 0) {
            return;
        }
      Severity: Minor
      Found in src/BinomialHeap.js - About 1 hr to fix

        Function merge has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            const merge = function (compare, list, other) {
        if (other.length === 0) {
            return;
        }
        Severity: Minor
        Found in src/LazyBinomialHeap.js - About 1 hr to fix
          Severity
          Category
          Status
          Source
          Language