heiglandreas/JUnitDiff

View on GitHub
src/Command/CompareCommand.php

Summary

Maintainability
A
1 hr
Test Coverage

Method execute has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $style = new DiffStyle($input, $output);
        $style->title($this->getApplication()->getLongVersion());

Severity: Minor
Found in src/Command/CompareCommand.php - About 1 hr to fix

    The class CompareCommand has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13.
    Open

    class CompareCommand extends Command
    {
        protected function configure()
        {
            $this->setName('compare')
    Severity: Minor
    Found in src/Command/CompareCommand.php by phpmd

    CouplingBetweenObjects

    Since: 1.1.0

    A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

    Example

    class Foo {
        /**
         * @var \foo\bar\X
         */
        private $x = null;
    
        /**
         * @var \foo\bar\Y
         */
        private $y = null;
    
        /**
         * @var \foo\bar\Z
         */
        private $z = null;
    
        public function setFoo(\Foo $foo) {}
        public function setBar(\Bar $bar) {}
        public function setBaz(\Baz $baz) {}
    
        /**
         * @return \SplObjectStorage
         * @throws \OutOfRangeException
         * @throws \InvalidArgumentException
         * @throws \ErrorException
         */
        public function process(\Iterator $it) {}
    
        // ...
    }

    Source https://phpmd.org/rules/design.html#couplingbetweenobjects

    There are no issues that match your filters.

    Category
    Status