Sign upLogin

herpaderpaldent/seat-notifications

View on GitHub
Star

Showing 135 of 135 total issues

Avoid excessively long variable names like $affiliation_JSON_action. Keep variable name length under 20.
Open

    public function __construct(BuildAffiliationJSONAction $affiliation_JSON_action)
Severity: Minor
Found in src/Http/Actions/SubscribeAction.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $attacker_corporation_ids. Keep variable name length under 20.
Open

        $attacker_corporation_ids = $this->killmail_detail
Severity: Minor
Found in src/Jobs/KillmaillDispatcher.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Method callback has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function callback(Request $request)
    {
        // get back pending OAuth credentials validation from session
        $credentials = $request->session()->get('herpaderp.seatnotifications.slack.credentials');
Severity: Minor
Found in src/Http/Controllers/Slack/SlackServerOAuthController.php - About 1 hr to fix

    Avoid using short method names like CreateSeatNotificationsTable::up(). The configured minimum method name length is 3.
    Open

        public function up()
    {
        Schema::dropIfExists('seatnotifications');

        Schema::table('herpaderp_discord_users', function (Blueprint $table) {
    Severity: Minor
    Found in src/database/migrations/2019_01_22_194232_create_seat_notifications_table.php by phpmd

    ShortMethodName

    Since: 0.2

    Detects when very short method names are used.

    Example

    class ShortMethod {
    public function a( $index ) { // Violation
    }
}

    Source https://phpmd.org/rules/naming.html#shortmethodname

    Avoid using short method names like CreateRefreshTokenNotificationsTable::up(). The configured minimum method name length is 3.
    Open

        public function up()
    {
        Schema::create('herpaderp_refresh_token_notifications', function (Blueprint $table) {
            $table->string('channel_id');
            $table->enum('type', ['private', 'channel']);
    Severity: Minor
    Found in src/database/migrations/2018_12_26_132103_create_refresh_token_notifications_table.php by phpmd

    ShortMethodName

    Since: 0.2

    Detects when very short method names are used.

    Example

    class ShortMethod {
    public function a( $index ) { // Violation
    }
}

    Source https://phpmd.org/rules/naming.html#shortmethodname

    Avoid using short method names like SlackMessage::to(). The configured minimum method name length is 3.
    Open

        public function to($channel)
    {
        $this->channel = $channel;

        return $this;
    Severity: Minor
    Found in src/Channels/Slack/SlackMessage.php by phpmd

    ShortMethodName

    Since: 0.2

    Detects when very short method names are used.

    Example

    class ShortMethod {
    public function a( $index ) { // Violation
    }
}

    Source https://phpmd.org/rules/naming.html#shortmethodname

    Avoid using short method names like DeleteRefreshTokenNotifications::up(). The configured minimum method name length is 3.
    Open

        public function up()
    {
        Schema::dropIfExists('herpaderp_refresh_token_notifications');
    }
    Severity: Minor
    Found in src/database/migrations/2019_01_27_192647_delete_refresh_token_notifications.php by phpmd

    ShortMethodName

    Since: 0.2

    Detects when very short method names are used.

    Example

    class ShortMethod {
    public function a( $index ) { // Violation
    }
}

    Source https://phpmd.org/rules/naming.html#shortmethodname

    Avoid using short method names like CreateSeatnotificationTable::up(). The configured minimum method name length is 3.
    Open

        public function up()
    {
        Schema::create('seatnotifications', function (Blueprint $table) {
            $table->increments('id')->index();
            $table->integer('settings_id');
    Severity: Minor
    Found in src/database/migrations/2018_06_28_192012_create_seatnotification_table.php by phpmd

    ShortMethodName

    Since: 0.2

    Detects when very short method names are used.

    Example

    class ShortMethod {
    public function a( $index ) { // Violation
    }
}

    Source https://phpmd.org/rules/naming.html#shortmethodname

    Avoid using short method names like CreateSlackUsersTable::up(). The configured minimum method name length is 3.
    Open

        public function up()
    {
        Schema::create('herpaderp_slack_users', function (Blueprint $table) {
            $table->unsignedInteger('group_id');
            $table->string('slack_id');
    Severity: Minor
    Found in src/database/migrations/2018_12_29_085624_create_slack_users_table.php by phpmd

    ShortMethodName

    Since: 0.2

    Detects when very short method names are used.

    Example

    class ShortMethod {
    public function a( $index ) { // Violation
    }
}

    Source https://phpmd.org/rules/naming.html#shortmethodname

    Avoid using short method names like SeedSchedule::up(). The configured minimum method name length is 3.
    Open

        public function up()
    {
        foreach ($this->schedule as $job) {
            $existing = Schedule::where('command', $job['command'])
                ->first();
    Severity: Minor
    Found in src/database/migrations/2019_02_01_210024_seed_schedule.php by phpmd

    ShortMethodName

    Since: 0.2

    Detects when very short method names are used.

    Example

    class ShortMethod {
    public function a( $index ) { // Violation
    }
}

    Source https://phpmd.org/rules/naming.html#shortmethodname

    Avoid using short method names like CreateDiscordUsersTable::up(). The configured minimum method name length is 3.
    Open

        public function up()
    {
        Schema::create('herpaderp_discord_users', function (Blueprint $table) {
            $table->unsignedInteger('group_id');
            $table->bigInteger('discord_id');
    Severity: Minor
    Found in src/database/migrations/2018_12_26_110744_create_discord_users_table.php by phpmd

    ShortMethodName

    Since: 0.2

    Detects when very short method names are used.

    Example

    class ShortMethod {
    public function a( $index ) { // Violation
    }
}

    Source https://phpmd.org/rules/naming.html#shortmethodname

    Avoid using short method names like Version2Migrations::up(). The configured minimum method name length is 3.
    Open

        public function up()
    {
        Schema::dropIfExists('herpaderp_seat_notification_notification_recipients');
        Schema::dropIfExists('herpaderp_seat_notification_recipients');
    Severity: Minor
    Found in src/database/migrations/2019_02_26_195245_version_2_migrations.php by phpmd

    ShortMethodName

    Since: 0.2

    Detects when very short method names are used.

    Example

    class ShortMethod {
    public function a( $index ) { // Violation
    }
}

    Source https://phpmd.org/rules/naming.html#shortmethodname

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function join()
    {
        $state = time();

        $client_id = setting('herpaderp.seatnotifications.discord.credentials.client_id', true);
    Severity: Major
    Found in src/Http/Controllers/Discord/DiscordOAuthController.php and 1 other location - About 1 hr to fix
    src/Http/Controllers/Slack/SlackUserOAuthController.php on lines 51..64

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 104.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function join()
    {
        $state = time();

        $client_id = setting('herpaderp.seatnotifications.slack.credentials.client_id', true);
    Severity: Major
    Found in src/Http/Controllers/Slack/SlackUserOAuthController.php and 1 other location - About 1 hr to fix
    src/Http/Controllers/Discord/DiscordOAuthController.php on lines 55..68

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 104.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method callback has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function callback()
    {
        $state = request()->session()->get('herpaderp.seatnotifications.slack.user.state');

        request()->session()->forget('herpaderp.seatnotifications.slack.user.state');
    Severity: Minor
    Found in src/Http/Controllers/Slack/SlackUserOAuthController.php - About 1 hr to fix

      Method getCategories has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private static function getCategories(int $category_id = null): Collection
    {
        $params = [
            'api_key' => setting('herpaderp.seatnotifications.discourse.credentials.api_key', true),
        ];
      Severity: Minor
      Found in src/Drivers/DiscourseNotificationDriver.php - About 1 hr to fix

        Function execute has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            public function execute(array $data)
    {

        if (array_key_exists('characters_filter', $data) || array_key_exists('corporations_filter', $data)) {
        Severity: Minor
        Found in src/Http/Actions/BuildAffiliationJSONAction.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function mergeConfigs has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function mergeConfigs(array $original, array $merging)
    {
        $array = array_merge($original, $merging);

        foreach ($original as $key => $value) {
        Severity: Minor
        Found in src/SeatNotificationsServiceProvider.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method callback has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function callback()
    {
        $state = request()->session()->get('herpaderp.seatnotifications.discord.user.state');

        request()->session()->forget('herpaderp.seatnotifications.discord.user.state');
        Severity: Minor
        Found in src/Http/Controllers/Discord/DiscordOAuthController.php - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function postConfiguration(ValidateSlackOAuth $request)
    {
        $state = time();

        // store data into the session until OAuth confirmation
          Severity: Major
          Found in src/Http/Controllers/Slack/SlackServerOAuthController.php and 1 other location - About 1 hr to fix
          src/Http/Controllers/Discord/DiscordServerController.php on lines 58..71

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 102.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language