Sign upLogin

herpaderpaldent/seat-notifications

View on GitHub
Star

Showing 135 of 135 total issues

Avoid using static access to class '\Seat\Web\Models\Group' in method 'via'.
Open

            'private to: ' . $this->getMainCharacter(Group::find($notifiable->group_id))->name);
Severity: Minor
Found in src/Notifications/KillMail/SlackKillMailNotification.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused parameters such as '$notifiable'.
Open

    public function toDiscord($notifiable)
Severity: Minor
Found in src/Notifications/RefreshToken/DiscordRefreshTokenNotification.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid using static access to class '\Illuminate\Support\Arr' in method 'getGateway'.
Open

            $gateway = Arr::get(json_decode($response->getBody(), true), 'url', $gateway);
Severity: Minor
Found in src/Http/Controllers/Discord/DiscordServerController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Market\Price' in method 'getValue'.
Open

            ->push(Price::find($this->killmail_detail->victims->ship_type_id))
Severity: Minor
Found in src/Notifications/KillMail/AbstractKillMailNotification.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Web\Models\Group' in method 'via'.
Open

        array_push($this->tags, is_null($notifiable->group_id) ? 'to channel' : 'private to: ' . $this->getMainCharacter(Group::find($notifiable->group_id))->name);
Severity: Minor
Found in src/Notifications/RefreshToken/SlackRefreshTokenNotification.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Killmails\KillmailDetail' in method 'test'.
Open

        $killmail_detail = KillmailDetail::first();
Severity: Minor
Found in src/Observers/KillmailDetailObserver.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\Schema' in method 'up'.
Open

        Schema::create('herpaderp_seat_notification_recipients', function (Blueprint $table) {
            $table->increments('id');
            $table->string('driver_id');
            $table->string('driver');
            $table->integer('group_id')->nullable()->default(null);
Severity: Minor
Found in src/database/migrations/2019_02_26_195245_version_2_migrations.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\Schema' in method 'up'.
Open

        Schema::create('herpaderp_seat_notification_subscriptions', function (Blueprint $table) {
            $table->integer('recipient_id')->unsigned();
            $table->string('notification');
            $table->json('affiliations')->nullable()->default(null);
            $table->timestamps();
Severity: Minor
Found in src/database/migrations/2019_02_26_195245_version_2_migrations.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Herpaderpaldent\Seat\SeatNotifications\Models\Discord\DiscordUser' in method 'getPrivateChannel'.
Open

        return optional(DiscordUser::find(auth()->user()->group->id))->channel_id;
Severity: Minor
Found in src/Drivers/DiscordNotificationDriver.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Herpaderpaldent\Seat\SeatNotifications\Models\Slack\SlackUser' in method 'bindingUser'.
Open

        SlackUser::updateOrCreate([
            'group_id'   => auth()->user()->group_id,
        ], [
            'slack_id'    => $slack_id,
            'channel_id'  => $channel_id,
Severity: Minor
Found in src/Http/Controllers/Slack/SlackUserOAuthController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused parameters such as '$notifiable'.
Open

    public function toSlack($notifiable)
Severity: Minor
Found in src/Notifications/RefreshToken/SlackRefreshTokenNotification.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused private methods such as 'addTranslations'.
Open

    private function addTranslations()
    {
        $this->loadTranslationsFrom(__DIR__ . '/lang', 'seatnotifications');
    }
Severity: Minor
Found in src/SeatNotificationsServiceProvider.php by phpmd

UnusedPrivateMethod

Since: 0.2

Unused Private Method detects when a private method is declared but is unused.

Example

class Something
{
    private function foo() {} // unused
}

Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

Avoid using static access to class '\Illuminate\Support\Facades\Schema' in method 'up'.
Open

        Schema::create('herpaderp_refresh_token_notifications', function (Blueprint $table) {
            $table->string('channel_id');
            $table->enum('type', ['private', 'channel']);
            $table->string('via');
            $table->timestamps();
Severity: Minor
Found in src/database/migrations/2018_12_26_132103_create_refresh_token_notifications_table.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\Schema' in method 'up'.
Open

        Schema::table('herpaderp_discord_users', function (Blueprint $table) {
            $table->string('channel_id')->change();
            $table->unique('channel_id', 'herpaderp_discord_channel_id_unique');
        });
Severity: Minor
Found in src/database/migrations/2019_01_22_194232_create_seat_notifications_table.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\Schema' in method 'down'.
Open

        Schema::create('herpaderp_seat_notification_recipients', function (Blueprint $table) {
            $table->string('channel_id');
            $table->string('notification_channel');
            $table->boolean('is_channel')->default(false);
            $table->timestamps();
Severity: Minor
Found in src/database/migrations/2019_02_26_195245_version_2_migrations.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\Redis' in method 'getLastRequestTime'.
Open

        return Redis::hexists($key, 'last_request') ? floatval(Redis::hget($key, 'last_request')) : 0;
Severity: Minor
Found in src/Caches/RedisRateLimitProvider.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Market\Price' in method 'getValue'.
Open

                return Price::find($item->item_type_id);
Severity: Minor
Found in src/Notifications/KillMail/AbstractKillMailNotification.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Seat\Eveapi\Models\Sde\InvType' in method 'getDiscordKMStringPartial'.
Open

        $ship_type = optional(InvType::find($ship_type_id))->typeName;
Severity: Minor
Found in src/Notifications/KillMail/DiscordKillMailNotification.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\Schema' in method 'down'.
Open

        Schema::table('herpaderp_discord_users', function (Blueprint $table) {
            $table->bigInteger('channel_id')->change();
            $table->dropUnique('herpaderp_discord_channel_id_unique');
        });
Severity: Minor
Found in src/database/migrations/2019_01_22_194232_create_seat_notifications_table.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\Schema' in method 'up'.
Open

        Schema::dropIfExists('herpaderp_seat_notification_recipients');
Severity: Minor
Found in src/database/migrations/2019_02_26_195245_version_2_migrations.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Severity
Category
Status
Source
Language