Sign upLogin

herpaderpaldent/seat-notifications

View on GitHub
Star
src/Jobs/KillmaillDispatcher.php

Summary

Maintainability
A
1 hr
Test Coverage

Method handle has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function handle()
    {

        // Check if victim and attacker details are present yet.
        if(empty($this->killmail_detail->victims) || empty($this->killmail_detail->attackers)){
Severity: Minor
Found in src/Jobs/KillmaillDispatcher.php - About 1 hr to fix

    Avoid using static access to class '\Illuminate\Support\Facades\Notification' in method 'handle'.
    Open

                        Notification::send($grouped_recipients, (new $notification_class($this->killmail_id)));
    Severity: Minor
    Found in src/Jobs/KillmaillDispatcher.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Herpaderpaldent\Seat\SeatNotifications\Notifications\KillMail\AbstractKillMailNotification' in method 'handle'.
    Open

                        $notification_class = AbstractKillMailNotification::getDriverImplementation($driver);
    Severity: Minor
    Found in src/Jobs/KillmaillDispatcher.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    TODO found
    Open

            //TODO: check if delay if victim corporation_id is not available.
    Severity: Minor
    Found in src/Jobs/KillmaillDispatcher.php by fixme

    Avoid excessively long variable names like $victim_corporation_id. Keep variable name length under 20.
    Open

            $victim_corporation_id = optional($this->killmail_detail->victims)->corporation_id;
    Severity: Minor
    Found in src/Jobs/KillmaillDispatcher.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    Avoid excessively long variable names like $attacker_corporation_ids. Keep variable name length under 20.
    Open

            $attacker_corporation_ids = $this->killmail_detail
    Severity: Minor
    Found in src/Jobs/KillmaillDispatcher.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    There are no issues that match your filters.

    Category
    Status