hicknhack-software/redmine_hourglass

View on GitHub
app/controllers/hourglass/time_bookings_controller.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method bulk_create has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def bulk_create
      bulk do |_, params|
        result = nil
        ActiveRecord::Base.transaction do
          result = Hourglass::TimeLog.create create_time_log_params params
Severity: Minor
Found in app/controllers/hourglass/time_bookings_controller.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def create
      time_log, time_booking = nil
      ActiveRecord::Base.transaction do
        time_log = Hourglass::TimeLog.create create_time_log_params
        raise ActiveRecord::Rollback unless time_log.persisted?
Severity: Minor
Found in app/controllers/hourglass/time_bookings_controller.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status