Sign upLogin

hicknhack-software/redmine_hourglass

View on GitHub
Star
lib/hourglass/date_time_calculations.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method update_following_bookings has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def update_following_bookings(user, project_id, current_booking)
      booking = current_booking
      current_time_log = current_booking.time_log
      start = current_time_log.start
      loop do
Severity: Minor
Found in lib/hourglass/date_time_calculations.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method booking_process has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def booking_process(user, options)
      round = round?(options)
      if round
        previous_time_log = closest_booked_time_log user, options[:project_id], options[:start], after_current: false
        options[:start], options[:stop] = calculate_bookable_time options[:start], options[:stop], previous_time_log && previous_time_log.time_booking && previous_time_log.time_booking.rounding_carry_over, project: options[:project_id]
Severity: Minor
Found in lib/hourglass/date_time_calculations.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status