Sign upLogin

hipay/hipay-wallet-cashout-mirakl-library

View on GitHub
Star

Showing 101 of 101 total issues

File Processor.php has 815 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace HiPay\Wallet\Mirakl\Vendor;

use DateTime;
Severity: Major
Found in src/Vendor/Processor.php - About 1 day to fix

    File HiPay.php has 679 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace HiPay\Wallet\Mirakl\Api;

use DateTime;
    Severity: Major
    Found in src/Api/HiPay.php - About 1 day to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              try {
            $vendor = $this->getVendor($operation);

            if (!$vendor) {
                throw new WalletNotFoundException($vendor);
      Severity: Major
      Found in src/Cashout/Transfer.php and 1 other location - About 1 day to fix
      src/Cashout/Withdraw.php on lines 124..246

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 333.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              try {
            $vendor = $this->getVendor($operation);

            if (!$vendor) {
                throw new WalletNotFoundException($vendor);
      Severity: Major
      Found in src/Cashout/Withdraw.php and 1 other location - About 1 day to fix
      src/Cashout/Transfer.php on lines 131..231

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 333.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      UserAccount has 58 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class UserAccount extends ModelAbstract
{
    //Non mandatory properties
    /**
     * @var string
      Severity: Major
      Found in src/Api/HiPay/Model/Rest/UserAccount.php - About 1 day to fix

        UserAccountDetails has 55 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class UserAccountDetails extends ModelAbstract
{
    //Non mandatory properties

    /** @var int
        Severity: Major
        Found in src/Api/HiPay/Model/Soap/UserAccountDetails.php - About 7 hrs to fix

          Method transferFiles has 160 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function transferFiles(array $shopIds, $tmpFilePath)
    {
        if (count($shopIds) > 0) {
            // Fetches all Mirakl file names
            $allMiraklFiles = array();
          Severity: Major
          Found in src/Vendor/Processor.php - About 6 hrs to fix

            Function transferFiles has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
            Open

                public function transferFiles(array $shopIds, $tmpFilePath)
    {
        if (count($shopIds) > 0) {
            // Fetches all Mirakl file names
            $allMiraklFiles = array();
            Severity: Minor
            Found in src/Vendor/Processor.php - About 5 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            HiPay has 33 functions (exceeds 20 allowed). Consider refactoring.
            Open

            class HiPay implements ApiInterface
{
    /** @var  string the hipay webservice login */
    protected $login;
            Severity: Minor
            Found in src/Api/HiPay.php - About 4 hrs to fix

              Processor has 33 functions (exceeds 20 allowed). Consider refactoring.
              Open

              class Processor extends AbstractApiProcessor
{
    /** @var VendorManagerInterface */
    protected $vendorManager;
              Severity: Minor
              Found in src/Vendor/Processor.php - About 4 hrs to fix

                Method registerWallets has 100 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function registerWallets($miraklData)
    {
        $vendorCollection = array();

        foreach ($miraklData as $vendorData) {
                Severity: Major
                Found in src/Vendor/Processor.php - About 4 hrs to fix

                  Method withdraw has 99 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function withdraw(OperationInterface $operation)
    {
        try {
            $vendor = $this->getVendor($operation);
                  Severity: Major
                  Found in src/Cashout/Withdraw.php - About 3 hrs to fix

                    File Handler.php has 321 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    <?php

namespace HiPay\Wallet\Mirakl\Notification;

use DateTime;
                    Severity: Minor
                    Found in src/Notification/Handler.php - About 3 hrs to fix

                      File UserAccount.php has 319 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      <?php

namespace HiPay\Wallet\Mirakl\Api\HiPay\Model\Rest;

use HiPay\Wallet\Mirakl\Service\Country;
                      Severity: Minor
                      Found in src/Api/HiPay/Model/Rest/UserAccount.php - About 3 hrs to fix

                        Method transfer has 81 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function transfer(OperationInterface $operation)
    {
        try {
            $vendor = $this->getVendor($operation);
                        Severity: Major
                        Found in src/Cashout/Transfer.php - About 3 hrs to fix

                          File Initializer.php has 301 lines of code (exceeds 250 allowed). Consider refactoring.
                          Open

                          <?php

namespace HiPay\Wallet\Mirakl\Cashout;

use DateTime;
                          Severity: Minor
                          Found in src/Cashout/Initializer.php - About 3 hrs to fix

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                public function setHiPayData(array $hipayData)
    {
        $this->bankName = $hipayData['bank_name'];
        $this->bankAddress = $hipayData['bank_address'];
        $this->bankZipCode = $hipayData['bank_zip_code'];
                            Severity: Major
                            Found in src/Api/HiPay/Model/Rest/BankInfo.php and 1 other location - About 2 hrs to fix
                            src/Api/HiPay/Model/Soap/BankInfo.php on lines 122..136

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 141.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                public function setHiPayData(array $hipayData)
    {
        $this->bankName = $hipayData['bankName'];
        $this->bankAddress = $hipayData['bankAddress'];
        $this->bankZipCode = $hipayData['bankZipCode'];
                            Severity: Major
                            Found in src/Api/HiPay/Model/Soap/BankInfo.php and 1 other location - About 2 hrs to fix
                            src/Api/HiPay/Model/Rest/BankInfo.php on lines 122..136

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 141.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Method handleHiPayNotification has 71 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                public function handleHiPayNotification($xml)
    {
        if (!$xml) {
            return;
        }
                            Severity: Major
                            Found in src/Notification/Handler.php - About 2 hrs to fix

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                              <?php

namespace HiPay\Wallet\Mirakl\Exception;

use Exception;
                              Severity: Major
                              Found in src/Exception/BankAccountCreationFailedException.php and 1 other location - About 2 hrs to fix
                              src/Exception/InvalidBankInfoException.php on lines 1..74

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 133.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Severity
                              Category
                              Status
                              Source
                              Language