Sign upLogin

hipay/hipay-wallet-cashout-mirakl-library

View on GitHub
Star

Showing 101 of 101 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

namespace HiPay\Wallet\Mirakl\Exception;

use Exception;
Severity: Major
Found in src/Exception/InvalidBankInfoException.php and 1 other location - About 2 hrs to fix
src/Exception/BankAccountCreationFailedException.php on lines 1..75

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 133.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File UserAccountDetails.php has 272 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace HiPay\Wallet\Mirakl\Api\HiPay\Model\Soap;

use HiPay\Wallet\Mirakl\Service\Country;
Severity: Minor
Found in src/Api/HiPay/Model/Soap/UserAccountDetails.php - About 2 hrs to fix

    Method handleBankInfo has 61 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function handleBankInfo($vendorCollection, $miraklDataCollection, $tmpFilePath)
    {
        //Index mirakl Data
        $miraklDataCollection = $this->indexMiraklData($miraklDataCollection);
    Severity: Major
    Found in src/Vendor/Processor.php - About 2 hrs to fix

      BankInfo has 22 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class BankInfo extends ModelAbstract
{
    /**
     * @var string
     *
      Severity: Minor
      Found in src/Api/HiPay/Model/Soap/BankInfo.php - About 2 hrs to fix

        BankInfo has 22 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class BankInfo extends ModelAbstract
{
    /**
     * @var string
     *
        Severity: Minor
        Found in src/Api/HiPay/Model/Rest/BankInfo.php - About 2 hrs to fix

          Function registerWallets has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
          Open

              public function registerWallets($miraklData)
    {
        $vendorCollection = array();

        foreach ($miraklData as $vendorData) {
          Severity: Minor
          Found in src/Vendor/Processor.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method createOperationsFromInvoice has 55 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function createOperationsFromInvoice(array $invoice, VendorInterface $vendor, DateTime $cycleDate)
    {

        $operations = array();
          Severity: Major
          Found in src/Cashout/Initializer.php - About 2 hrs to fix

            Method process has 53 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function process($tmpFilesPath, DateTime $lastUpdate = null)
    {
        try {
            $this->logger->info('Control Mirakl Settings', array('miraklId' => null, "action" => "Wallet creation"));
            Severity: Major
            Found in src/Vendor/Processor.php - About 2 hrs to fix

              Function handleBankInfo has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function handleBankInfo($vendorCollection, $miraklDataCollection, $tmpFilePath)
    {
        //Index mirakl Data
        $miraklDataCollection = $this->indexMiraklData($miraklDataCollection);
              Severity: Minor
              Found in src/Vendor/Processor.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function withdraw has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function withdraw(OperationInterface $operation)
    {
        try {
            $vendor = $this->getVendor($operation);
              Severity: Minor
              Found in src/Cashout/Withdraw.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method __construct has 41 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function __construct(
        array $miraklData
    ) {
        $this->email = $miraklData['contact_informations']['email'];
        $this->controleType = 'CREDENTIALS';
              Severity: Minor
              Found in src/Api/HiPay/Model/Rest/UserAccount.php - About 1 hr to fix

                Method setNewStatus has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    private function setNewStatus(
        $operationId,
        $operation,
        $successStatus,
        $failStatus,
                Severity: Minor
                Found in src/Cashout/TransactionStatus.php - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  <?php

namespace HiPay\Wallet\Mirakl\Exception;

use Exception;
                  Severity: Major
                  Found in src/Exception/WalletNotFoundException.php and 1 other location - About 1 hr to fix
                  src/Exception/InvalidAmountException.php on lines 1..50

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 113.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  <?php

namespace HiPay\Wallet\Mirakl\Exception;

use Exception;
                  Severity: Major
                  Found in src/Exception/InvalidAmountException.php and 1 other location - About 1 hr to fix
                  src/Exception/WalletNotFoundException.php on lines 1..50

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 113.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method getAccountInfos has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function getAccountInfos(UserAccount $userAccount, $vendor = null)
    {
        $this->resetRestClient();

        $this->restClient->getConfig()->setPath(
                  Severity: Minor
                  Found in src/Api/HiPay.php - About 1 hr to fix

                    Method getBalance has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function getBalance(VendorInterface $vendor)
    {
        $this->resetRestClient();

        $this->restClient->getConfig()->setPath(
                    Severity: Minor
                    Found in src/Api/HiPay.php - About 1 hr to fix

                      Method identification has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          protected function identification($hipayId, $date, $status)
    {
        if ($status) {
            $eventName = 'identification.notification.success';
            $statusRequest = LogVendorsInterface::SUCCESS;
                      Severity: Minor
                      Found in src/Notification/Handler.php - About 1 hr to fix

                        Function handleHiPayNotification has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function handleHiPayNotification($xml)
    {
        if (!$xml) {
            return;
        }
                        Severity: Minor
                        Found in src/Notification/Handler.php - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method logOperation has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            protected function logOperation($miraklId, $paymentVoucherNumber, $status, $message)
    {
        $logOperation = $this->logOperationsManager->findByMiraklIdAndPaymentVoucherNumber(
            $miraklId,
            $paymentVoucherNumber
                        Severity: Minor
                        Found in src/Cashout/AbstractOperationProcessor.php - About 1 hr to fix

                          Method bankInfoValidation has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              protected function bankInfoValidation($vendor, $date, $status)
    {
        // if status is OK
        if ($status) {
            $this->mirakl->updateOneVendor(
                          Severity: Minor
                          Found in src/Notification/Handler.php - About 1 hr to fix
                            Severity
                            Category
                            Status
                            Source
                            Language