hipay/hipay-wallet-cashout-mirakl-library

View on GitHub
src/Api/HiPay.php

Summary

Maintainability
F
3 days
Test Coverage

File HiPay.php has 679 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace HiPay\Wallet\Mirakl\Api;

use DateTime;
Severity: Major
Found in src/Api/HiPay.php - About 1 day to fix

    HiPay has 33 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class HiPay implements ApiInterface
    {
        /** @var  string the hipay webservice login */
        protected $login;
    
    
    Severity: Minor
    Found in src/Api/HiPay.php - About 4 hrs to fix

      Method getBalance has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getBalance(VendorInterface $vendor)
          {
              $this->resetRestClient();
      
              $this->restClient->getConfig()->setPath(
      Severity: Minor
      Found in src/Api/HiPay.php - About 1 hr to fix

        Method getAccountInfos has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getAccountInfos(UserAccount $userAccount, $vendor = null)
            {
                $this->resetRestClient();
        
                $this->restClient->getConfig()->setPath(
        Severity: Minor
        Found in src/Api/HiPay.php - About 1 hr to fix

          Method createFullUseraccountV2 has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function createFullUseraccountV2(UserAccount $userAccount)
              {
                  $this->resetRestClient();
          
                  if (!$userAccount->getLocale()) {
          Severity: Minor
          Found in src/Api/HiPay.php - About 1 hr to fix

            Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    $baseSoapUrl,
                    $baseRestUrl,
                    $login,
                    $password,
                    $entity,
            Severity: Major
            Found in src/Api/HiPay.php - About 1 hr to fix

              Method executeRest has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function executeRest($command, $parameters = array())
                  {
                      $this->restClient->getConfig()->setPath(
                          'request.options/headers/x-professional-client-origin',
                          'hipay-mirakl-connector-v1'
              Severity: Minor
              Found in src/Api/HiPay.php - About 1 hr to fix

                Method callSoap has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    protected function callSoap($name, array $parameters)
                    {
                        $parameters = $this->mergeLoginParametersSoap($parameters);
                        //Make the call
                        $response = $this->getClient($name)->$name(
                Severity: Minor
                Found in src/Api/HiPay.php - About 1 hr to fix

                  Method uploadDocument has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          $userSpaceId,
                          $accountId,
                          $documentType,
                          $fileName,
                          \DateTime $validityDate = null,
                  Severity: Minor
                  Found in src/Api/HiPay.php - About 45 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            try {
                                $result = $this->executeRest($command);
                            } catch (HipayRestResponseException $e) {
                    
                                if ($e->getResponse()->getStatusCode() == '401') {
                    Severity: Minor
                    Found in src/Api/HiPay.php and 1 other location - About 50 mins to fix
                    src/Api/HiPay.php on lines 684..700

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 97.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            try {
                                $result = $this->executeRest($command);
                            } catch (HipayRestResponseException $e) {
                                /** retro compatible if old account */
                                if ($e->getResponse()->getStatusCode() == '401') {
                    Severity: Minor
                    Found in src/Api/HiPay.php and 1 other location - About 50 mins to fix
                    src/Api/HiPay.php on lines 572..589

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 97.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status