Sign upLogin

hipay/hipay-wallet-cashout-mirakl-library

View on GitHub
Star
src/Cashout/Initializer.php

Summary

Maintainability
C
1 day
Test Coverage

File Initializer.php has 301 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace HiPay\Wallet\Mirakl\Cashout;

use DateTime;
Severity: Minor
Found in src/Cashout/Initializer.php - About 3 hrs to fix

    Method createOperationsFromInvoice has 55 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function createOperationsFromInvoice(array $invoice, VendorInterface $vendor, DateTime $cycleDate)
    {

        $operations = array();
    Severity: Major
    Found in src/Cashout/Initializer.php - About 2 hrs to fix

      Method __construct has 10 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              EventDispatcherInterface $dispatcher,
        LoggerInterface $logger,
        Factory $factory,
        VendorInterface $operatorAccount,
        VendorInterface $technicalAccount,
      Severity: Major
      Found in src/Cashout/Initializer.php - About 1 hr to fix

        Method processInvoices has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function processInvoices(array $invoices, DateTime $cycleDate)
    {

        $operations = array();
        Severity: Minor
        Found in src/Cashout/Initializer.php - About 1 hr to fix

          Method process has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function process(DateTime $startDate, DateTime $endDate, DateTime $cycleDate)
    {
        $this->logger->info('Control Mirakl Settings', array('miraklId' => null, "action" => "Operations creation"));
        // control mirakl settings
        $boolControl = $this->getControlMiraklSettings($this->documentTypes);
          Severity: Minor
          Found in src/Cashout/Initializer.php - About 1 hr to fix

            Method createOperation has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    $amount,
        $originAmount,
        DateTime $cycleDate,
        $paymentVoucher,
        $vendor,
            Severity: Major
            Found in src/Cashout/Initializer.php - About 50 mins to fix

              Function processInvoices has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function processInvoices(array $invoices, DateTime $cycleDate)
    {

        $operations = array();
              Severity: Minor
              Found in src/Cashout/Initializer.php - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if ($boolControl === false) {
            // log critical
            $title = $this->criticalMessageMiraklSettings;
            $message = $this->formatNotification->formatMessage($title);
            $this->logger->critical($message, array('miraklId' => null, "action" => "Operations creation"));
              Severity: Minor
              Found in src/Cashout/Initializer.php and 1 other location - About 45 mins to fix
              src/Vendor/Processor.php on lines 112..122

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 95.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status