hnhdigital-os/laravel-model-filter

Avoid too many return statements within this method.

Open

                        return true;

The method returnSearchResult has a boolean flag argument $extra_response, which is a certain sign of a Single Responsibility Principle violation.

Open

    protected static function returnSearchResult($controller_name, $distinct_session, $search_request, $response, $extra_response = false)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method getSearchAppliedFilters has a boolean flag argument $use_session, which is a certain sign of a Single Responsibility Principle violation.

Open

    protected static function getSearchAppliedFilters($controller_name, $distinct_session = '', $use_session = false)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method getFilterAttributes has a boolean flag argument $first_call, which is a certain sign of a Single Responsibility Principle violation.

Open

    public static function getFilterAttributes($first_call = true)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method getFilterOperators has a boolean flag argument $operator, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function getFilterOperators($type, $operator = false)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

Avoid too many return statements within this method.

Open

                        return true;

Avoid too many return statements within this method.

Open

                        return true;

Avoid too many return statements within this method.

Open

                        return true;

Avoid too many return statements within this method.

Open

                        return true;

Avoid too many return statements within this method.

Open

                        return true;

Avoid too many return statements within this method.

Open

                        return true;

The method getCurrentSearchQuery has a boolean flag argument $model_filter, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function getCurrentSearchQuery($options, $class_name, $model_filter = false)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

Avoid too many return statements within this method.

Open

                        return true;

Avoid too many return statements within this method.

Open

                        return true;

Avoid too many return statements within this method.

Open

                        return true;

Avoid too many return statements within this method.

Open

                        return true;

Avoid too many return statements within this method.

Open

                        return true;

Avoid too many return statements within this method.

Open

        return false;

Avoid too many return statements within this method.

Open

                        return true;

The method applyFilterAttributeArray has a boolean flag argument $positive, which is a certain sign of a Single Responsibility Principle violation.

Open

    private static function applyFilterAttributeArray($query, $attribute_list, $method, $arguments, $positive = true)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}