Sign upLogin

hnhdigital-os/laravel-model-filter

View on GitHub
Star

Showing 194 of 194 total issues

Function getRelationQuery has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    private function getRelationQuery($model, $other_model, $method_source)
    {
        $method_name = camel_case($method_source);
        if (method_exists($other_model, $method_name.'s')) {
            $method_name .= 's';
Severity: Minor
Found in src/Traits/ControllerTrait.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The method compose() has 119 lines of code. Current threshold is set to 100. Avoid really long methods.
Open

    public function compose(View $view)
    {
        // Get the data assigned to this view
        $view_data = $view->getData();
        $filter_types = [];
Severity: Minor
Found in src/Composers/SearchPage.php by phpmd

Avoid assigning values to variables in if clauses and the like (line '68', column '68').
Open

    public function compose(View $view)
    {
        // Get the data assigned to this view
        $view_data = $view->getData();
        $filter_types = [];
Severity: Minor
Found in src/Composers/SearchPage.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

The method getFilterAttributes uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                    } else {
                        if ($filter_detail['attribute'][0] === '{') {
                            $filter_detail['attribute'] = new Expression(substr($filter_detail['attribute'], 1));
                        } elseif (strpos($filter_detail['attribute'], '.') === false) {
                            $filter_detail['attribute'] = $model->getTable().'.'.$filter_detail['attribute'];
Severity: Minor
Found in src/Traits/ModelTrait.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method pagination uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $search_request['page'] = 0;
            $search_request['paginate_current_page'] = 1;
            $search_request['paginate_has_more_pages'] = false;
            $search_request['paginate_last_page'] = 1;
Severity: Minor
Found in src/Traits/ControllerTrait.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid unused local variables such as '$model_class'.
Open

                foreach ($relationships as $method_name => $model_class) {
Severity: Minor
Found in src/Traits/ModelTrait.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

The method compose uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                            } else {
                                $list_filter_options[$filter_name] = [];
                            }
Severity: Minor
Found in src/Composers/SearchPage.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method getCurrentSearchQuery uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                if (isset($attached_method_source)) {
                    return $model->$attached_method_source();
                }
Severity: Minor
Found in src/Traits/ControllerTrait.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method validateOperators uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                    } else {
                        $value1 = [];
                    }
Severity: Minor
Found in src/Traits/ModelTrait.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid unused local variables such as '$unattached_tab'.
Open

        } elseif ($search_tab == $unattached_tab) {
Severity: Minor
Found in src/Traits/ControllerTrait.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

The method getCurrentSearchDetails uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $settings_data = (array) $settings;
        }
Severity: Minor
Found in src/Traits/ControllerTrait.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method loadFilter() has an NPath complexity of 504. The configured NPath complexity threshold is 200.
Open

    public function loadFilter(HttpRequest $request, ModelFilter $model_filter)
    {
        $model_name = 'App\\Models\\'.$request->get('model');
        $method_name = $request->get('method');
Severity: Minor
Found in src/Traits/ControllerTrait.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

Avoid unused local variables such as '$attached_tab'.
Open

        if ($search_tab == $attached_tab) {
Severity: Minor
Found in src/Traits/ControllerTrait.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid assigning values to variables in if clauses and the like (line '391', column '22').
Open

    protected static function checkSearchResults($table, $result, &$search_request, $name, $column_span = 1, $config = [])
    {
        self::pagination($result, $search_request);

        $thead = false;
Severity: Minor
Found in src/Traits/ControllerTrait.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

The method returnSearchResult uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $response['count'] = 'No results found.';
            }
Severity: Minor
Found in src/Traits/ControllerTrait.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method getCurrentSearchQuery() has an NPath complexity of 436. The configured NPath complexity threshold is 200.
Open

    public function getCurrentSearchQuery($options, $class_name, $model_filter = false)
    {
        $class_name = 'App\\Models\\'.$class_name;
        extract($options);
        $route_name = (!isset($route_name)) ? $current_model : $route_name;
Severity: Minor
Found in src/Traits/ControllerTrait.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method validateOperators() has 162 lines of code. Current threshold is set to 100. Avoid really long methods.
Open

    private static function validateOperators($filter, &$method, &$arguments, $model, $filter_setting, $operator, $value1, $value2)
    {
        // No space search.
        if (array_has($filter_setting, 'phone_search')) {
            $value1_numeric = str_replace(' ', '', $value1);
Severity: Minor
Found in src/Traits/ModelTrait.php by phpmd

The method compose() has an NPath complexity of 2142. The configured NPath complexity threshold is 200.
Open

    public function compose(View $view)
    {
        // Get the data assigned to this view
        $view_data = $view->getData();
        $filter_types = [];
Severity: Minor
Found in src/Composers/SearchPage.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method compose uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $view_data['search_data'] = ['setup' => new SearchViewOptions(), 'result' => new SearchViewResult()];
            $setup = $view_data['search_data']['setup'];
        }
Severity: Minor
Found in src/Composers/SearchPage.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid unused local variables such as '$config'.
Open

        $options['route_prefix'] = (empty($options['route_prefix'])) ? array_get($config, 0, '') : $options['route_prefix'];
Severity: Minor
Found in src/Traits/ControllerTrait.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Severity
Category
Status
Source
Language