Sign upLogin

hnhdigital-os/mysql-helper

View on GitHub
Star

Showing 85 of 103 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    private function selectConnection($profile)
    {
        $menu_options = [];

        foreach (array_keys(array_get($this->profiles, $profile.'.local', [])) as $name) {
Severity: Major
Found in app/Commands/DisplayCommand.php and 2 other locations - About 1 hr to fix
app/Commands/BackupCommand.php on lines 128..141
app/Commands/RestoreCommand.php on lines 169..182

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    private function selectLocalConnection($profile)
    {
        $menu_options = [];

        foreach (array_keys(array_get($this->profiles, $profile.'.local', [])) as $name) {
Severity: Major
Found in app/Commands/RestoreCommand.php and 2 other locations - About 1 hr to fix
app/Commands/BackupCommand.php on lines 128..141
app/Commands/DisplayCommand.php on lines 176..189

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    private function selectLocalConnection($profile)
    {
        $menu_options = [];

        foreach (array_keys(array_get($this->profiles, $profile.'.local', [])) as $name) {
Severity: Major
Found in app/Commands/BackupCommand.php and 2 other locations - About 1 hr to fix
app/Commands/DisplayCommand.php on lines 176..189
app/Commands/RestoreCommand.php on lines 169..182

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function sshConnect has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    private function sshConnect($host, $port, $method, $settings)
    {
        try {
            $session = ssh2_connect($host, $port);
        } catch (\Exception $e) {
Severity: Minor
Found in app/Commands/ConfigureCommand.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method cloneRemoteDatabases has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

    private function cloneRemoteDatabases($profile, $remote, $remote_profile, $remote_connection, $local_connection, $source_database, $destination_database)
Severity: Major
Found in app/Commands/CloneCommand.php - About 50 mins to fix

    Terminating statement must be indented to the same level as the CASE body
    Open

                break;
    Severity: Minor
    Found in app/Commands/ConfigureCommand.php by phpcodesniffer

    Terminating statement must be indented to the same level as the CASE body
    Open

                break;
    Severity: Minor
    Found in app/Commands/ConfigureCommand.php by phpcodesniffer

    Blank line found at start of control structure
    Open

                if (empty($new_value)) {
    Severity: Minor
    Found in app/Commands/ConfigureCommand.php by phpcodesniffer

    The CASE body must start on the line following the statement
    Open

                case 'password':
    Severity: Minor
    Found in app/Commands/ConfigureCommand.php by phpcodesniffer

    The CASE body must start on the line following the statement
    Open

                case 'agent':
    Severity: Minor
    Found in app/Commands/ConfigureCommand.php by phpcodesniffer

    Avoid too many return statements within this method.
    Open

                    return $this->updateRemoteProfileKey($profile, $name, $option);
    Severity: Major
    Found in app/Commands/ConfigureCommand.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                          return 1;
      Severity: Major
      Found in app/Commands/CloneCommand.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return 1;
        Severity: Major
        Found in app/Commands/CloneCommand.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return $this->cloneRemoteDatabases(
                $profile,
                $remote,
                $remote_profile,
                $remote_connection,
          Severity: Major
          Found in app/Commands/CloneCommand.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                return 1;
            Severity: Major
            Found in app/Commands/CloneCommand.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                  return 1;
              Severity: Major
              Found in app/Commands/CloneCommand.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return $this->updateRemoteProfileName($profile, $name, $option);
                Severity: Major
                Found in app/Commands/ConfigureCommand.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                          return $this->runRestore($profile, $connection, $sql_path, $database);
                  Severity: Major
                  Found in app/Commands/RestoreCommand.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return $this->runBackup($profile, $connection, $database);
                    Severity: Major
                    Found in app/Commands/BackupCommand.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                          return 1;
                      Severity: Major
                      Found in app/Commands/CloneCommand.php - About 30 mins to fix
                        Severity
                        Category
                        Status
                        Source
                        Language