Sign upLogin

houston/houston-core

View on GitHub
Star

Showing 1,937 of 1,937 total issues

Extra blank line detected.
Open
Severity: Minor
Found in lib/houston/boot/observer.rb by rubocop

This cops checks for two or more consecutive blank lines.

Example:

# bad - It has two empty lines.
some_method
# one empty line
# two empty lines
some_method

# good
some_method
# one empty line
some_method

Surrounding space missing in default value assignment.
Open

    def once(event, options={}, &block)
Severity: Minor
Found in lib/houston/boot/observer.rb by rubocop

Checks that the equals signs in parameter default assignments have or don't have surrounding space depending on configuration.

Example:

# bad
def some_method(arg1=:default, arg2=nil, arg3=[])
  # do something...
end

# good
def some_method(arg1 = :default, arg2 = nil, arg3 = [])
  # do something...
end

Line is too long. [85/80]
Open

      raise UnregisteredEventError, "#{event_name.inspect} is not a registered event"
Severity: Minor
Found in lib/houston/boot/observer.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

require "houston/boot/serializer"
Severity: Minor
Found in lib/houston/params_serializer.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    longest_params = actions.map { |action| action.required_params.join(", ").length }.max
Severity: Minor
Found in lib/tasks/actions.rake by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

  gem "simplecov-json", require: false
Severity: Minor
Found in Gemfile by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Line exceeds maximum allowed length
Open

        "<img alt=\"#{$1}\" height=\"20\" width=\"20\" src=\"#{App.relativeRoot()}/images/emoji/#{$1}.png\" class=\"emoji\" />"
Severity: Minor
Found in app/assets/javascripts/houston/core/app.coffee by coffeelint

Line exceeds maximum allowed length
Open

    ((html, i)-> html + Handlebars.helpers.timelineDate((i + 1).days().before(lastDate)))
Severity: Minor
Found in app/assets/javascripts/houston/core/timeline_helpers.coffee by coffeelint

Line exceeds maximum allowed length
Open

        # Interpolating the angles in polar coordinates, rather than the raw path
Severity: Minor
Found in app/assets/javascripts/houston/dashboard/refresher.coffee by coffeelint

Keep a blank line before and after private.
Open

  private
Severity: Minor
Found in lib/houston/boot/observer.rb by rubocop

Access modifiers should be surrounded by blank lines.

Example:

# bad
class Foo
  def bar; end
  private
  def baz; end
end

# good
class Foo
  def bar; end

  private

  def baz; end
end

Extra empty line detected at module body end.
Open


end
Severity: Minor
Found in lib/houston/try.rb by rubocop

This cops checks if empty lines around the bodies of modules match the configuration.

Example: EnforcedStyle: empty_lines

# good

module Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

module Foo
  module Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
module Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

module Foo
  def bar
    # ...
  end
end

Missing top-level module documentation comment.
Open

module Houston
Severity: Minor
Found in lib/houston/try.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

  gem "minitest-reporters", require: false
Severity: Minor
Found in Gemfile by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Extra empty line detected at class body end.
Open


  end
Severity: Minor
Found in lib/houston/boot/serializers/readonly_hash_serializer.rb by rubocop

This cops checks if empty lines around the bodies of classes match the configuration.

Example: EnforcedStyle: empty_lines

# good

class Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

class Foo
  class Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
class Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

class Foo
  def bar
    # ...
  end
end

Line is too long. [106/80]
Open

          rescue Exception # rescues StandardError by default; but we want to rescue and report all errors
Severity: Minor
Found in lib/houston/boot/observer.rb by rubocop

Line is too long. [82/80]
Open

      Rails.logger.warn "\e[31m[try] \e[1m#{$!.class}\e[0;31m: #{$!.message}\e[0m"
Severity: Minor
Found in lib/houston/try.rb by rubocop

Line exceeds maximum allowed length
Open

        <input type="hidden" name="#{App.meta('csrf-param')}" value="#{App.meta('csrf-token')}">
Severity: Minor
Found in app/assets/javascripts/houston/core/app.coffee by coffeelint
Severity
Category
Status
Source
Language