Sign upLogin

howardjones/network-weathermap

View on GitHub
Star
lib/Weathermap/Core/MapScale.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method colourFromValue has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function colourFromValue($value, $itemName = '', $isPercentage = true, $showScaleWarnings = true)
    {
        $scaleName = $this->name;

        MapUtility::debug("Finding a colour for value %s in scale %s\n", $value, $this->name);
Severity: Minor
Found in lib/Weathermap/Core/MapScale.php - About 1 hr to fix

    Function colourFromValue has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        public function colourFromValue($value, $itemName = '', $isPercentage = true, $showScaleWarnings = true)
    {
        $scaleName = $this->name;

        MapUtility::debug("Finding a colour for value %s in scale %s\n", $value, $this->name);
    Severity: Minor
    Found in lib/Weathermap/Core/MapScale.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function findScaleHit has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function findScaleHit($value)
    {
        $tag = '';
        $smallestMatchColour = null;
        $smallestMatchSize = null;
    Severity: Minor
    Found in lib/Weathermap/Core/MapScale.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method addSpan has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function addSpan($lowValue, $highValue, $lowColour, $highColour = null, $tag = '')
    Severity: Minor
    Found in lib/Weathermap/Core/MapScale.php - About 35 mins to fix

      Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed.
      Open

          public function colourFromValue($value, $itemName = '', $isPercentage = true, $showScaleWarnings = true)
      Severity: Critical
      Found in lib/Weathermap/Core/MapScale.php by sonar-php

      Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

      See

      There are no issues that match your filters.

      Category
      Status