Sign upLogin

howardjones/network-weathermap

View on GitHub
Star
lib/Weathermap/Plugins/Datasources/CactiTholdStatus.php

Summary

Maintainability
D
2 days
Test Coverage

Function readData has a Cognitive Complexity of 61 (exceeds 5 allowed). Consider refactoring.
Open

    public function readData($targetString, &$map, &$mapItem)
    {
        $this->data[IN] = null;
        $this->data[OUT] = null;
        $this->dataTime = time();
Severity: Minor
Found in lib/Weathermap/Plugins/Datasources/CactiTholdStatus.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method readData has 115 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function readData($targetString, &$map, &$mapItem)
    {
        $this->data[IN] = null;
        $this->data[OUT] = null;
        $this->dataTime = time();
Severity: Major
Found in lib/Weathermap/Plugins/Datasources/CactiTholdStatus.php - About 4 hrs to fix

    Function init has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

        public function init(&$map)
    {
        if ($map->context == 'cacti') {
            $pdo = weathermap_get_pdo();
    Severity: Minor
    Found in lib/Weathermap/Plugins/Datasources/CactiTholdStatus.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method init has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function init(&$map)
    {
        if ($map->context == 'cacti') {
            $pdo = weathermap_get_pdo();
    Severity: Minor
    Found in lib/Weathermap/Plugins/Datasources/CactiTholdStatus.php - About 1 hr to fix

      Refactor this function to reduce its Cognitive Complexity from 24 to the 15 allowed.
      Open

          public function init(&$map)
      Severity: Critical
      Found in lib/Weathermap/Plugins/Datasources/CactiTholdStatus.php by sonar-php

      Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

      See

      Refactor this function to reduce its Cognitive Complexity from 61 to the 15 allowed.
      Open

          public function readData($targetString, &$map, &$mapItem)
      Severity: Critical
      Found in lib/Weathermap/Plugins/Datasources/CactiTholdStatus.php by sonar-php

      Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

      See

      Reduce the number of returns of this function 4, down to the maximum allowed 3.
      Open

          public function init(&$map)
      Severity: Major
      Found in lib/Weathermap/Plugins/Datasources/CactiTholdStatus.php by sonar-php

      Having too many return statements in a function increases the function's essential complexity because the flow of execution is broken each time a return statement is encountered. This makes it harder to read and understand the logic of the function.

      Noncompliant Code Example

      With the default threshold of 3:

      function myFunction(){ // Noncompliant as there are 4 return statements
  if (condition1) {
    return true;
  } else {
    if (condition2) {
      return false;
    } else {
      return true;
    }
  }
  return false;
}

      This function "readData" has 159 lines, which is greater than the 150 lines authorized. Split it into smaller functions.
      Open

          public function readData($targetString, &$map, &$mapItem)
      Severity: Major
      Found in lib/Weathermap/Plugins/Datasources/CactiTholdStatus.php by sonar-php

      A function that grows too large tends to aggregate too many responsibilities.

      Such functions inevitably become harder to understand and therefore harder to maintain.

      Above a specific threshold, it is strongly advised to refactor into smaller functions which focus on well-defined tasks.

      Those smaller functions will not only be easier to understand, but also probably easier to test.

      Remove this commented out code.
      Open

                      // $SQL2 = "select rra_id, data_id, thold_alert from thold_data,data_local where thold_data.rra_id=data_local.id and data_local.host_id=$id and thold_enabled='on'";
      Severity: Major
      Found in lib/Weathermap/Plugins/Datasources/CactiTholdStatus.php by sonar-php

      Programmers should not comment out code as it bloats programs and reduces readability.

      Unused code should be deleted and can be retrieved from source control history if required.

      See

      • MISRA C:2004, 2.4 - Sections of code should not be "commented out".
      • MISRA C++:2008, 2-7-2 - Sections of code shall not be "commented out" using C-style comments.
      • MISRA C++:2008, 2-7-3 - Sections of code should not be "commented out" using C++ comments.
      • MISRA C:2012, Dir. 4.4 - Sections of code should not be "commented out"

      Merge this if statement with the enclosing one.
      Open

                      if (api_plugin_is_enabled('thold')) {
      Severity: Major
      Found in lib/Weathermap/Plugins/Datasources/CactiTholdStatus.php by sonar-php

      Merging collapsible if statements increases the code's readability.

      Noncompliant Code Example

      if (condition1) {
  if (condition2) {
    ...
  }
}

      Compliant Solution

      if (condition1 && condition2) {
  ...
}

      Remove this commented out code.
      Open

      //                $result = db_fetch_row($SQL);
      Severity: Major
      Found in lib/Weathermap/Plugins/Datasources/CactiTholdStatus.php by sonar-php

      Programmers should not comment out code as it bloats programs and reduces readability.

      Unused code should be deleted and can be retrieved from source control history if required.

      See

      • MISRA C:2004, 2.4 - Sections of code should not be "commented out".
      • MISRA C++:2008, 2-7-2 - Sections of code shall not be "commented out" using C-style comments.
      • MISRA C++:2008, 2-7-3 - Sections of code should not be "commented out" using C++ comments.
      • MISRA C:2012, Dir. 4.4 - Sections of code should not be "commented out"

      Define a constant instead of duplicating this literal "status" 3 times.
      Open

                          if ($result['status'] == 1) {
      Severity: Critical
      Found in lib/Weathermap/Plugins/Datasources/CactiTholdStatus.php by sonar-php

      Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

      On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

      Noncompliant Code Example

      With the default threshold of 3:

      function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

      Compliant Solution

      ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

      Exceptions

      To prevent generating some false-positives, literals having less than 5 characters are excluded.

      Remove this commented out code.
      Open

      //            $SQL2 = "select thold_alert from thold_data where rra_id=$rra_id and data_id=$data_id and thold_enabled='on'";
      Severity: Major
      Found in lib/Weathermap/Plugins/Datasources/CactiTholdStatus.php by sonar-php

      Programmers should not comment out code as it bloats programs and reduces readability.

      Unused code should be deleted and can be retrieved from source control history if required.

      See

      • MISRA C:2004, 2.4 - Sections of code should not be "commented out".
      • MISRA C++:2008, 2-7-2 - Sections of code shall not be "commented out" using C-style comments.
      • MISRA C++:2008, 2-7-3 - Sections of code should not be "commented out" using C++ comments.
      • MISRA C:2012, Dir. 4.4 - Sections of code should not be "commented out"

      Remove this commented out code.
      Open

      //            $result = db_fetch_row($SQL2);
      Severity: Major
      Found in lib/Weathermap/Plugins/Datasources/CactiTholdStatus.php by sonar-php

      Programmers should not comment out code as it bloats programs and reduces readability.

      Unused code should be deleted and can be retrieved from source control history if required.

      See

      • MISRA C:2004, 2.4 - Sections of code should not be "commented out".
      • MISRA C++:2008, 2-7-2 - Sections of code shall not be "commented out" using C-style comments.
      • MISRA C++:2008, 2-7-3 - Sections of code should not be "commented out" using C++ comments.
      • MISRA C:2012, Dir. 4.4 - Sections of code should not be "commented out"

      Remove this commented out code.
      Open

      //                $SQL2 = "select thold_alert from thold_data where id=$id and thold_enabled='on'";
      Severity: Major
      Found in lib/Weathermap/Plugins/Datasources/CactiTholdStatus.php by sonar-php

      Programmers should not comment out code as it bloats programs and reduces readability.

      Unused code should be deleted and can be retrieved from source control history if required.

      See

      • MISRA C:2004, 2.4 - Sections of code should not be "commented out".
      • MISRA C++:2008, 2-7-2 - Sections of code shall not be "commented out" using C-style comments.
      • MISRA C++:2008, 2-7-3 - Sections of code should not be "commented out" using C++ comments.
      • MISRA C:2012, Dir. 4.4 - Sections of code should not be "commented out"

      Remove this commented out code.
      Open

      //                $result = db_fetch_row($SQL2);
      Severity: Major
      Found in lib/Weathermap/Plugins/Datasources/CactiTholdStatus.php by sonar-php

      Programmers should not comment out code as it bloats programs and reduces readability.

      Unused code should be deleted and can be retrieved from source control history if required.

      See

      • MISRA C:2004, 2.4 - Sections of code should not be "commented out".
      • MISRA C++:2008, 2-7-2 - Sections of code shall not be "commented out" using C-style comments.
      • MISRA C++:2008, 2-7-3 - Sections of code should not be "commented out" using C++ comments.
      • MISRA C:2012, Dir. 4.4 - Sections of code should not be "commented out"

      Define a constant instead of duplicating this literal "thold_alert" 4 times.
      Open

                      if ($result['thold_alert'] > 0) {
      Severity: Critical
      Found in lib/Weathermap/Plugins/Datasources/CactiTholdStatus.php by sonar-php

      Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

      On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

      Noncompliant Code Example

      With the default threshold of 3:

      function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

      Compliant Solution

      ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

      Exceptions

      To prevent generating some false-positives, literals having less than 5 characters are excluded.

      Remove this commented out code.
      Open

      //                $SQL = "select * from host where id=$id";
      Severity: Major
      Found in lib/Weathermap/Plugins/Datasources/CactiTholdStatus.php by sonar-php

      Programmers should not comment out code as it bloats programs and reduces readability.

      Unused code should be deleted and can be retrieved from source control history if required.

      See

      • MISRA C:2004, 2.4 - Sections of code should not be "commented out".
      • MISRA C++:2008, 2-7-2 - Sections of code shall not be "commented out" using C-style comments.
      • MISRA C++:2008, 2-7-3 - Sections of code should not be "commented out" using C++ comments.
      • MISRA C:2012, Dir. 4.4 - Sections of code should not be "commented out"

      Remove this commented out code.
      Open

                      # $result = db_fetch_row($SQL2);
      Severity: Major
      Found in lib/Weathermap/Plugins/Datasources/CactiTholdStatus.php by sonar-php

      Programmers should not comment out code as it bloats programs and reduces readability.

      Unused code should be deleted and can be retrieved from source control history if required.

      See

      • MISRA C:2004, 2.4 - Sections of code should not be "commented out".
      • MISRA C++:2008, 2-7-2 - Sections of code shall not be "commented out" using C-style comments.
      • MISRA C++:2008, 2-7-3 - Sections of code should not be "commented out" using C++ comments.
      • MISRA C:2012, Dir. 4.4 - Sections of code should not be "commented out"

      There are no issues that match your filters.

      Category
      Status