Sign upLogin

hpi-swt2/workshop-portal

View on GitHub
Star

Showing 494 of 494 total issues

Use %i or %I for an array of symbols.
Open

      params.require(:event).permit(:name, :description, :max_participants, :kind, :organizer, :knowledge_level, :application_deadline, date_ranges_attributes: [:start_date, :end_date, :id])
Severity: Minor
Found in app/controllers/events_controller.rb by rubocop

This cop can check for array literals made up of symbols that are not using the %i() syntax.

Alternatively, it checks for symbol arrays using the %i() syntax on projects which do not want to use that syntax.

Configuration option: MinSize If set, arrays with fewer elements than this value will not trigger the cop. For example, a MinSize of3` will not enforce a style on an array of 2 or fewer elements.

Example: EnforcedStyle: percent (default)

# good
%i[foo bar baz]

# bad
[:foo, :bar, :baz]

Example: EnforcedStyle: brackets

# good
[:foo, :bar, :baz]

# bad
%i[foo bar baz]

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    vb.customize ["modifyvm", :id, "--hwvirtex", "on"]
Severity: Minor
Found in Vagrantfile by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Line is too long. [89/80]
Open

# Each Puma worker will be able to spawn up to the maximum number of threads you specify.
Severity: Minor
Found in config/puma.rb by rubocop

Line is too long. [82/80]
Open

    # Settings in config/environments/* take precedence over those specified here.
Severity: Minor
Found in config/application.rb by rubocop

Line is too long. [84/80]
Open

  # :database      = Support basic authentication with authentication key + password
Severity: Minor
Found in config/initializers/devise.rb by rubocop

Line is too long. [82/80]
Open

  # a value less than 10 in other environments. Note that, for bcrypt (the default
Severity: Minor
Found in config/initializers/devise.rb by rubocop

Space found before comma.
Open

      pdf.text_box name, :at => [x + width / 2 - 50 , y - 20], :width => width - 100, :height => height - 100, :overflow => :shrink_to_fit
Severity: Minor
Found in app/controllers/events_controller.rb by rubocop

Checks for comma (,) preceded by space.

Example:

# bad
[1 , 2 , 3]
a(1 , 2)
each { |a , b| }

# good
[1, 2, 3]
a(1, 2)
each { |a, b| }

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    pdf.stroke_color "000000"
Severity: Minor
Found in app/controllers/events_controller.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    send_data pdf.render, filename: "badges.pdf", type: "application/pdf", disposition: "inline"
Severity: Minor
Found in app/controllers/events_controller.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Line is too long. [137/80]
Open

  # @param hide_recipients - a boolean. `true` will send an email to the recipients one by one, `false` will send an email to all at once
Severity: Minor
Found in app/services/mailer.rb by rubocop

Line is too long. [125/80]
Open

  # @param recipients [Array<String>] - email addresses of recipients - can be a string of comma separated email adresses too
Severity: Minor
Found in app/mailers/portal_mailer.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

  config.vm.box = "swt2/trusty64"
Severity: Minor
Found in Vagrantfile by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    vb.customize ["modifyvm", :id, "--ioapic", "on"]
Severity: Minor
Found in Vagrantfile by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem capybara should appear before rspec-rails.
Open

  gem 'capybara', '~> 2.5'
Severity: Minor
Found in Gemfile by rubocop

Gems should be alphabetically sorted within groups.

Example:

# bad
gem 'rubocop'
gem 'rspec'

# good
gem 'rspec'
gem 'rubocop'

# good
gem 'rubocop'

gem 'rspec'

# good only if TreatCommentsAsGroupSeparators is true
# For code quality
gem 'rubocop'
# For tests
gem 'rspec'

Line is too long. [103/80]
Open

# With a typical Rails memory footprint, you can expect to run 2-4 Puma worker processes on a free dyno
Severity: Minor
Found in config/puma.rb by rubocop

Inconsistent indentation detected.
Open

    config.unreasonably_long_event_time_span = 300
Severity: Minor
Found in config/application.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Use 2 (not 4) spaces for indentation.
Open

      config.action_view.field_error_proc = Proc.new { |html_tag, instance|
Severity: Minor
Found in config/application.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Line is too long. [112/80]
Open

# You can also remove all the silencers if you're trying to debug a problem that might stem from framework code.
Severity: Minor
Found in config/initializers/backtrace_silencers.rb by rubocop

Line is too long. [83/80]
Open

  # session. If you need permissions, you should implement that in a before filter.
Severity: Minor
Found in config/initializers/devise.rb by rubocop

Line is too long. [83/80]
Open

  # given strategies, for example, `config.http_authenticatable = [:database]` will
Severity: Minor
Found in config/initializers/devise.rb by rubocop
Severity
Category
Status
Source
Language