Sign upLogin

hpi-swt2/workshop-portal

View on GitHub
Star

Showing 494 of 494 total issues

Line is too long. [108/80]
Open

  get 'events/:id/send-rejection-emails' => 'events#send_rejection_emails', as: :event_send_rejection_emails
Severity: Minor
Found in config/routes.rb by rubocop

Line is too long. [85/80]
Open

  # find_for_authentication method and considered in your model lookup. For instance,
Severity: Minor
Found in config/initializers/devise.rb by rubocop

Line is too long. [85/80]
Open

  # modifying a user and when used to authenticate or find a user. Default is :email.
Severity: Minor
Found in config/initializers/devise.rb by rubocop

Unused block argument - value. If it's necessary, use _ or _value as an argument name to indicate that it won't be used.
Open

      params.select { |key, value| key.include? "_print" }.values
Severity: Minor
Found in app/controllers/events_controller.rb by rubocop

This cop checks for unused block arguments.

Example:

# bad

do_something do |used, unused|
  puts used
end

do_something do |bar|
  puts :foo
end

define_method(:foo) do |bar|
  puts :baz
end

Example:

#good

do_something do |used, _unused|
  puts used
end

do_something do
  puts :foo
end

define_method(:foo) do |_bar|
  puts :baz
end

Line is too long. [87/80]
Open

      filters = (params[:filter] || {}).select { |k, v| v == '1' }.map{ |k, v| k.to_s }
Severity: Minor
Found in app/controllers/events_controller.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

Vagrant.configure("2") do |config|
Severity: Minor
Found in Vagrantfile by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    vb.customize ["modifyvm", :id, "--memory", "2048"]
Severity: Minor
Found in Vagrantfile by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Line is too long. [93/80]
Open

  # If you are using Rails 4.1+ you can use the database.yml to set your connection pool size
Severity: Minor
Found in config/puma.rb by rubocop

Line is too long. [81/80]
Open

  # It can be set to an array that will enable params authentication only for the
Severity: Minor
Found in config/initializers/devise.rb by rubocop

Unused block argument - k. If it's necessary, use _ or _k as an argument name to indicate that it won't be used.
Open

      filters = (params[:filter] || {}).select { |k, v| v == '1' }.map{ |k, v| k.to_s }
Severity: Minor
Found in app/controllers/events_controller.rb by rubocop

This cop checks for unused block arguments.

Example:

# bad

do_something do |used, unused|
  puts used
end

do_something do |bar|
  puts :foo
end

define_method(:foo) do |bar|
  puts :baz
end

Example:

#good

do_something do |used, _unused|
  puts used
end

do_something do
  puts :foo
end

define_method(:foo) do |_bar|
  puts :baz
end

Line is too long. [167/80]
Open

    @templates = [{subject: 'Absage 1', content: 'Lorem Ispum...'}, {subject: 'Absage 2', content: 'Lorem Ispum...'}, {subject: 'Absage 3', content: 'Lorem Ispum...'}]
Severity: Minor
Found in app/controllers/events_controller.rb by rubocop

Line is too long. [190/80]
Open

      params.require(:event).permit(:name, :description, :max_participants, :kind, :organizer, :knowledge_level, :application_deadline, date_ranges_attributes: [:start_date, :end_date, :id])
Severity: Minor
Found in app/controllers/events_controller.rb by rubocop

Line is too long. [86/80]
Open

    # @param x [Integer] is the x-coordinate of the upper left corner of the new badge
Severity: Minor
Found in app/controllers/events_controller.rb by rubocop

Use the new Ruby 1.9 hash syntax.
Open

      pdf.text_box name, :at => [x + width / 2 - 50 , y - 20], :width => width - 100, :height => height - 100, :overflow => :shrink_to_fit
Severity: Minor
Found in app/controllers/events_controller.rb by rubocop

This cop checks hash literal syntax.

It can enforce either the use of the class hash rocket syntax or the use of the newer Ruby 1.9 syntax (when applicable).

A separate offense is registered for each problematic pair.

The supported styles are:

  • ruby19 - forces use of the 1.9 syntax (e.g. {a: 1}) when hashes have all symbols for keys
  • hash_rockets - forces use of hash rockets for all hashes
  • nomixedkeys - simply checks for hashes with mixed syntaxes
  • ruby19nomixed_keys - forces use of ruby 1.9 syntax and forbids mixed syntax hashes

Example: EnforcedStyle: ruby19 (default)

# bad
{:a => 2}
{b: 1, :c => 2}

# good
{a: 2, b: 1}
{:c => 2, 'd' => 2} # acceptable since 'd' isn't a symbol
{d: 1, 'e' => 2} # technically not forbidden

Example: EnforcedStyle: hash_rockets

# bad
{a: 1, b: 2}
{c: 1, 'd' => 5}

# good
{:a => 1, :b => 2}

Example: EnforcedStyle: nomixedkeys

# bad
{:a => 1, b: 2}
{c: 1, 'd' => 2}

# good
{:a => 1, :b => 2}
{c: 1, d: 2}

Example: EnforcedStyle: ruby19nomixed_keys

# bad
{:a => 1, :b => 2}
{c: 2, 'd' => 3} # should just use hash rockets

# good
{a: 1, b: 2}
{:c => 3, 'd' => 4}

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    send_data pdf.render, filename: "badges.pdf", type: "application/pdf", disposition: "inline"
Severity: Minor
Found in app/controllers/events_controller.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Trailing whitespace detected.
Open
Severity: Minor
Found in app/mailers/portal_mailer.rb by rubocop

Final newline missing.
Open

end
Severity: Minor
Found in Vagrantfile by rubocop

Line is too long. [91/80]
Open

  # Stubbing external calls by blocking traffic with WebMock.disable_net_connect! or allow:
Severity: Minor
Found in Gemfile by rubocop

} at 13, 4 is not aligned with config.action_view.field_error_proc = Proc.new { |html_tag, instance| at 11, 6.
Open

    }
Severity: Minor
Found in config/application.rb by rubocop

This cop checks whether the end keywords are aligned properly for do end blocks.

Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

start_of_block : the end shall be aligned with the start of the line where the do appeared.

start_of_line : the end shall be aligned with the start of the line where the expression started.

either (which is the default) : the end is allowed to be in either location. The autofixer will default to start_of_line.

Example: EnforcedStyleAlignWith: either (default)

# bad

foo.bar
   .each do
     baz
       end

# good

variable = lambda do |i|
  i
end

Example: EnforcedStyleAlignWith: startofblock

# bad

foo.bar
   .each do
     baz
       end

# good

foo.bar
  .each do
     baz
   end

Example: EnforcedStyleAlignWith: startofline

# bad

foo.bar
   .each do
     baz
       end

# good

foo.bar
  .each do
     baz
end

Space inside { missing.
Open

    @templates = [{subject: 'Zusage 1', content: 'Lorem Ispum...'}, {subject: 'Zusage 2', content: 'Lorem Ispum...'}, {subject: 'Zusage 3', content: 'Lorem Ispum...'}]
Severity: Minor
Found in app/controllers/events_controller.rb by rubocop

Checks that braces used for hash literals have or don't have surrounding space depending on configuration.

Example: EnforcedStyle: space

# The `space` style enforces that hash literals have
# surrounding space.

# bad
h = {a: 1, b: 2}

# good
h = { a: 1, b: 2 }

Example: EnforcedStyle: no_space

# The `no_space` style enforces that hash literals have
# no surrounding space.

# bad
h = { a: 1, b: 2 }

# good
h = {a: 1, b: 2}

Example: EnforcedStyle: compact

# The `compact` style normally requires a space inside
# hash braces, with the exception that successive left
# braces or right braces are collapsed together in nested hashes.

# bad
h = { a: { b: 2 } }

# good
h = { a: { b: 2 }}
Severity
Category
Status
Source
Language