Sign upLogin

hpi-swt2/workshop-portal

View on GitHub
Star

Showing 494 of 494 total issues

Using width with border can sometimes make elements larger than you expect.
Open

  border: 2px solid red;
Severity: Minor
Found in app/assets/stylesheets/scaffold.css by csslint

Trailing whitespace detected.
Open
Severity: Minor
Found in app/models/agreement_letter.rb by rubocop

Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Open

    if params[:event_id]
Severity: Minor
Found in app/controllers/application_letters_controller.rb by rubocop

Checks for if and unless statements that would fit on one line if written as a modifier if/unless. The maximum line length is configured in the Metrics/LineLength cop.

Example:

# bad
if condition
  do_stuff(bar)
end

unless qux.empty?
  Foo.do_something
end

# good
do_stuff(bar) if condition
Foo.do_something unless qux.empty?

Extra empty line detected at class body end.
Open


end
Severity: Minor
Found in app/models/event.rb by rubocop

This cops checks if empty lines around the bodies of classes match the configuration.

Example: EnforcedStyle: empty_lines

# good

class Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

class Foo
  class Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
class Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

class Foo
  def bar
    # ...
  end
end

Put empty method definitions on a single line.
Open

  def edit
  end
Severity: Minor
Found in app/controllers/profiles_controller.rb by rubocop

This cop checks for the formatting of empty method definitions. By default it enforces empty method definitions to go on a single line (compact style), but it can be configured to enforce the end to go on its own line (expanded style).

Note: A method definition is not considered empty if it contains comments.

Example: EnforcedStyle: compact (default)

# bad
def foo(bar)
end

def self.foo(bar)
end

# good
def foo(bar); end

def foo(bar)
  # baz
end

def self.foo(bar); end

Example: EnforcedStyle: expanded

# bad
def foo(bar); end

def self.foo(bar); end

# good
def foo(bar)
end

def self.foo(bar)
end

Line is too long. [84/80]
Open

  validates_presence_of :hide_recipients, :recipients, :reply_to, :subject, :content
Severity: Minor
Found in app/models/email.rb by rubocop

Unnecessary spacing detected.
Open

      if filters.count > 0  # skip filtering if no filters have been set
Severity: Minor
Found in app/controllers/events_controller.rb by rubocop

This cop checks for extra/unnecessary whitespace.

Example:

# good if AllowForAlignment is true
name      = "RuboCop"
# Some comment and an empty line

website  += "/bbatsov/rubocop" unless cond
puts        "rubocop"          if     debug

# bad for any configuration
set_app("RuboCop")
website  = "https://github.com/bbatsov/rubocop"

Use proc instead of Proc.new.
Open

  validate :deadline_cannot_be_in_the_past, :if => Proc.new { |letter| !(letter.status_changed?) }
Severity: Minor
Found in app/models/application_letter.rb by rubocop

This cops checks for uses of Proc.new where Kernel#proc would be more appropriate.

Example:

# bad
p = Proc.new { |n| puts n }

# good
p = proc { |n| puts n }

Inconsistent indentation detected.
Open

    def valid_file?(file)
      if !is_file?(file)
        errors.add(:file, I18n.t("agreement_letters.not_a_file"))
        false
      elsif too_big?(file)
Severity: Minor
Found in app/models/agreement_letter.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

        errors.add(:file, I18n.t("agreement_letters.file_too_big"))
Severity: Minor
Found in app/models/agreement_letter.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Line is too long. [81/80]
Open

    return now.year - birth_date.year - (current_time_is_before_birthday ? 0 : 1)
Severity: Minor
Found in app/models/profile.rb by rubocop

Redundant self detected.
Open

    self.birth_date >= 18.years.ago
Severity: Minor
Found in app/models/profile.rb by rubocop

This cop checks for redundant uses of self.

The usage of self is only needed when:

  • Sending a message to same object with zero arguments in presence of a method name clash with an argument or a local variable.

  • Calling an attribute writer to prevent an local variable assignment.

Note, with using explicit self you can only send messages with public or protected scope, you cannot send private messages this way.

Note we allow uses of self with operators because it would be awkward otherwise.

Example:

# bad
def foo(bar)
  self.baz
end

# good
def foo(bar)
  self.bar  # Resolves name clash with the argument.
end

def foo
  bar = 1
  self.bar  # Resolves name clash with the local variable.
end

def foo
  %w[x y z].select do |bar|
    self.bar == bar  # Resolves name clash with argument of the block.
  end
end

Line is too long. [100/80]
Open

    accepted_applications = application_letters.where(status: ApplicationLetter.statuses[:accepted])
Severity: Minor
Found in app/models/event.rb by rubocop

Don't use IDs in selectors.
Open

#event-date-pickers .close {
Severity: Minor
Found in app/assets/stylesheets/events.css by csslint

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    first_name + " " +  last_name
Severity: Minor
Found in app/models/profile.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Line is too long. [100/80]
Open

    rejected_applications = application_letters.where(status: ApplicationLetter.statuses[:rejected])
Severity: Minor
Found in app/models/event.rb by rubocop

Extra empty line detected at class body beginning.
Open
Severity: Minor
Found in app/models/date_range.rb by rubocop

This cops checks if empty lines around the bodies of classes match the configuration.

Example: EnforcedStyle: empty_lines

# good

class Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

class Foo
  class Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
class Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

class Foo
  def bar
    # ...
  end
end

Line is too long. [82/80]
Open

    application_letters.where(status: ApplicationLetter.statuses[:accepted]).count
Severity: Minor
Found in app/models/event.rb by rubocop

Use 2 (not 0) spaces for indenting an expression spanning multiple lines.
Open

    (menu_item t(:events, scope: 'navbar'), events_path) +
Severity: Minor
Found in app/helpers/application_helper.rb by rubocop

This cop checks the indentation of the right hand side operand in binary operations that span more than one line.

Example:

# bad
if a +
b
  something
end

# good
if a +
   b
  something
end

Don't use IDs in selectors.
Open

#applicants_overview {
Severity: Minor
Found in app/assets/stylesheets/events.css by csslint
Severity
Category
Status
Source
Language