src/Driver/AMQPConnection.php
Method create
has 12 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
string $host,
int $port,
string $user,
string $password,
string $vHost = '/',
The method create has 12 parameters. Consider reducing the number of parameters to less than 10. Open
Open
public static function create(
string $host,
int $port,
string $user,
string $password,
- Exclude checks
The method create has a boolean flag argument $insist, which is a certain sign of a Single Responsibility Principle violation. Open
Open
bool $insist = false,
- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}
Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
The method create has a boolean flag argument $keepAlive, which is a certain sign of a Single Responsibility Principle violation. Open
Open
bool $keepAlive = false,
- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}