Sign upLogin

hummingbird-me/hummingbird

View on GitHub
Star
app/helpers/reviews_helper.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method sanitize_review has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def sanitize_review(html)
    allow_youtube_transformer = lambda do |env|
      node      = env[:node]
      node_name = env[:node_name]
Severity: Major
Found in app/helpers/reviews_helper.rb - About 2 hrs to fix

    Method rating_description has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      def rating_description(r)
    return "Pathetic" if r == 1
    return "Dreadful" if r == 2
    return "Poor"     if r == 3
    return "Mediocre" if r == 4
    Severity: Minor
    Found in app/helpers/reviews_helper.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method sanitize_review has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def sanitize_review(html)
    allow_youtube_transformer = lambda do |env|
      node      = env[:node]
      node_name = env[:node_name]
    Severity: Minor
    Found in app/helpers/reviews_helper.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

        return "Fair"     if r == 5
    Severity: Major
    Found in app/helpers/reviews_helper.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

          return "Great"    if r == 8
      Severity: Major
      Found in app/helpers/reviews_helper.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

            return "Amazing"  if r == 9
        Severity: Major
        Found in app/helpers/reviews_helper.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

              return "Good"     if r == 7
          Severity: Major
          Found in app/helpers/reviews_helper.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                return "Decent"   if r == 6
            Severity: Major
            Found in app/helpers/reviews_helper.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                  return "Flawless" if r == 10
              Severity: Major
              Found in app/helpers/reviews_helper.rb - About 30 mins to fix

                There are no issues that match your filters.

                Category
                Status