Sign upLogin

idealo/php-rdkafka-ffi

View on GitHub
Star

Showing 61 of 61 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace RdKafka\Admin;
Severity: Major
Found in src/RdKafka/Admin/DeleteGroup.php and 1 other location - About 2 hrs to fix
src/RdKafka/Admin/DeleteTopic.php on lines 1..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 128.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    protected function parse(): void
    {
        $this->version = $this->parseInt16();

        switch ($this->version) {
Severity: Major
Found in examples/Protocol/GroupMetadataValueParser.php and 1 other location - About 2 hrs to fix
examples/Protocol/OffsetCommitValueParser.php on lines 31..52

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 127.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    protected function parse(): void
    {
        $this->version = $this->parseInt16();

        switch ($this->version) {
Severity: Major
Found in examples/Protocol/OffsetCommitValueParser.php and 1 other location - About 2 hrs to fix
examples/Protocol/GroupMetadataValueParser.php on lines 31..52

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 127.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function resumePartitions(array $topicPartitions): array
    {
        $topicPartitionList = new TopicPartitionList(...$topicPartitions);
        $nativeTopicPartitionList = $topicPartitionList->getCData();
Severity: Major
Found in src/RdKafka.php and 1 other location - About 2 hrs to fix
src/RdKafka.php on lines 180..199

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 125.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function pausePartitions(array $topicPartitions): array
    {
        $topicPartitionList = new TopicPartitionList(...$topicPartitions);
        $nativeTopicPartitionList = $topicPartitionList->getCData();
Severity: Major
Found in src/RdKafka.php and 1 other location - About 2 hrs to fix
src/RdKafka.php on lines 206..225

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 125.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method producev has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function producev(
        int $partition,
        int $msgflags,
        ?string $payload = null,
        ?string $key = null,
Severity: Minor
Found in src/RdKafka/ProducerTopic.php - About 1 hr to fix

    Method enrich has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function enrich($element): void
    {
        foreach ($this->documentedElements as $documentedElement) {
            if (preg_match('/\b' . $element->getName() . '\b/', $documentedElement['name'])) {
                $element->getDocBlock()->addTag(
    Severity: Minor
    Found in resources/ffigen/LibrdkafkaDocumentation.php - About 1 hr to fix

      Method parseHeaders has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function parseHeaders(CData $nativeMessage): array
    {
        $headers = [];

        if ($nativeMessage->err !== RD_KAFKA_RESP_ERR_NO_ERROR) {
      Severity: Minor
      Found in src/RdKafka/Message.php - About 1 hr to fix

        Method generateConstantsFiles has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function generateConstantsFiles(): void
    {
        $versionRelatedConstants = [];
        $overAllConstants = [];
        /** @var Constant[] $constants */
        Severity: Minor
        Found in resources/ffigen/MultiVersionGenerator.php - About 1 hr to fix

          Method loadSupportedVersions has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function loadSupportedVersions(): array
    {
        echo 'Load librdkafka releases ...';

        $content = file_get_contents(
          Severity: Minor
          Found in resources/ffigen/LibrdkafkaHeaderFiles.php - About 1 hr to fix

            Method __construct has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function __construct(CData $nativeMessage)
    {
        $timestampType = Library::new('rd_kafka_timestamp_type_t');
        $this->timestamp = (int) Library::rd_kafka_message_timestamp($nativeMessage, FFI::addr($timestampType));
        $this->timestampType = (int) $timestampType->cdata;
            Severity: Minor
            Found in src/RdKafka/Message.php - About 1 hr to fix

              Method setPartitioner has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function setPartitioner(int $partitioner): void
    {
        switch ($partitioner) {
            case RD_KAFKA_MSG_PARTITIONER_RANDOM:
                $partitionerMethod = 'rd_kafka_msg_partitioner_random';
              Severity: Minor
              Found in src/RdKafka/TopicConf.php - About 1 hr to fix

                Method setReplicaAssignment has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function setReplicaAssignment(int $new_partition_id, array $broker_ids): void
    {
        if (empty($broker_ids) === true) {
            throw new \InvalidArgumentException('broker_ids array must not be empty');
        }
                Severity: Minor
                Found in src/RdKafka/Admin/NewPartitions.php - About 1 hr to fix

                  Method setReplicaAssignment has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function setReplicaAssignment(int $partition_id, array $broker_ids): void
    {
        if (empty($broker_ids) === true) {
            throw new \InvalidArgumentException('broker_ids array must not be empty');
        }
                  Severity: Minor
                  Found in src/RdKafka/Admin/NewTopic.php - About 1 hr to fix

                    Function parseHeaders has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private function parseHeaders(CData $nativeMessage): array
    {
        $headers = [];

        if ($nativeMessage->err !== RD_KAFKA_RESP_ERR_NO_ERROR) {
                    Severity: Minor
                    Found in src/RdKafka/Message.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method benchProduce100MessagesWithLogAndDrMsgCallbacksWithOpaque has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function benchProduce100MessagesWithLogAndDrMsgCallbacksWithOpaque(): void
    {
        $counter = new stdClass();
        $counter->count = 0;
                    Severity: Minor
                    Found in benchmarks/ProducerBench.php - About 1 hr to fix

                      Method parse has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          private function parse(string $version): void
    {
        echo '  Parse ...' . PHP_EOL;
        $parser = new Parser($this->config);
                      Severity: Minor
                      Found in resources/ffigen/MultiVersionGenerator.php - About 1 hr to fix

                        Method benchConsume100MessagesWithLogCallback has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function benchConsume100MessagesWithLogCallback(): void
    {
        $conf = new Conf();
        $conf->set('metadata.broker.list', 'kafka:9092');
        $conf->set('auto.offset.reset', 'earliest');
                        Severity: Minor
                        Found in benchmarks/ConsumerBench.php - About 1 hr to fix

                          Function setPartitioner has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function setPartitioner(int $partitioner): void
    {
        switch ($partitioner) {
            case RD_KAFKA_MSG_PARTITIONER_RANDOM:
                $partitionerMethod = 'rd_kafka_msg_partitioner_random';
                          Severity: Minor
                          Found in src/RdKafka/TopicConf.php - About 55 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function prepareVersion has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function prepareVersion(string $version): void
    {
        if (array_key_exists($version, $this->supportedVersions) === false) {
            throw new \InvalidArgumentException(sprintf('Version %s not supported', $version));
        }
                          Severity: Minor
                          Found in resources/ffigen/LibrdkafkaHeaderFiles.php - About 55 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Severity
                          Category
                          Status
                          Source
                          Language